[PATCH] D67025: Add .inl as valid C++ header type

2022-07-20 Thread Wasim Abbas via Phabricator via cfe-commits
abbaswasim added a comment. AFAICT Xcode understands and reads it as c++ header file. It highlights it fine and icon is "h+". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67025/new/ https://reviews.llvm.org/D67025 __

[PATCH] D67025: Add .inl as valid C++ header type

2022-07-20 Thread Wasim Abbas via Phabricator via cfe-commits
abbaswasim added a comment. Also I couldn't make the `-x` option to work with `lsp-mode` but that's not `clangd`s problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67025/new/ https://reviews.llvm.org/D67025 __

[PATCH] D67025: Add .inl as valid C++ header type

2022-07-20 Thread Wasim Abbas via Phabricator via cfe-commits
abbaswasim added a comment. > FWIW, I did a search over github repos and this file extension is used, but I > would hardly call it a common practice Fair enough. what would be sufficient evidence? I think in general whether its `.inl` or any other extension thats used to separate template impl

[PATCH] D67025: Add .inl as valid C++ header type

2019-10-21 Thread Wasim Abbas via Phabricator via cfe-commits
abbaswasim added a comment. Herald added a subscriber: usaxena95. Hi All, I am not fully aware of the process here could anyone point me to what is the next step? Has anyone looked at this Patch? //Wasim Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D67025: Add .inl as valid C++ header type

2019-08-30 Thread Wasim Abbas via Phabricator via cfe-commits
abbaswasim created this revision. Herald added subscribers: cfe-commits, kadircet, ilya-biryukov. Herald added a project: clang. `clangd` doesn't consider `.inl` a valid C++ source (https://github.com/clangd/clangd/issues/16#issuecomment-512942589) this pull request adds support for that. Until