[PATCH] D37187: [Analyzer] Fix Bug 25609 - Assertion UNREACHABLE: 'Unexpected ProgramPoint' with widen-loops=true

2017-08-31 Thread Wang Liushuai via Phabricator via cfe-commits
MTC marked an inline comment as done. MTC added inline comments. Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:694 + } else if (Optional BE = P.getAs()) { +CFGElement BlockFront = BE->getBlock()->front(); +if (BlockFront.getKind() == CFGElement::Statement) { ---

[PATCH] D37187: [Analyzer] Fix Bug 25609 - Assertion UNREACHABLE: 'Unexpected ProgramPoint' with widen-loops=true

2017-08-31 Thread Wang Liushuai via Phabricator via cfe-commits
MTC updated this revision to Diff 113427. MTC added a comment. (1) Modify the description of the bug report (2) Update loop-widening-notes.c (3) PathDiagnosticLocation::create() - Use the location of TerminatorCondition. https://reviews.llvm.org/D37187 Files: lib/StaticAnalyzer/Core/BugRepo

[PATCH] D37187: [Analyzer] Fix Bug 25609 - Assertion UNREACHABLE: 'Unexpected ProgramPoint' with widen-loops=true

2017-08-30 Thread Wang Liushuai via Phabricator via cfe-commits
MTC marked an inline comment as done. MTC added a comment. Hi peter, Thank you very much for your help. > - I think the current display information is ambiguous. If I did not know the > code then I would not understand what this stands for. (That is just my > opinon.) I think Artem's "Content