[PATCH] D146678: Summary: Fix ArgsAsWritten being null for ConceptSpecializationExpr in certain circumstances when parsing ASTs

yeswalrus added a comment. "Walter Gray" Thank you, and sorry about the back and forth. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146678/new/ https://reviews.llvm.org/D146678 ___ cfe-commits mailing

[PATCH] D146678: Summary: Fix ArgsAsWritten being null for ConceptSpecializationExpr in certain circumstances when parsing ASTs

yeswalrus added a comment. In D146678#4220408 , @erichkeane wrote: > In D146678#4220360 , @yeswalrus > wrote: > >> -I can handle it. - >> Edit: I cannot handle it, I don't have commit access. If you could commit

[PATCH] D146678: Summary: Fix ArgsAsWritten being null for ConceptSpecializationExpr in certain circumstances when parsing ASTs

yeswalrus updated this revision to Diff 509175. yeswalrus retitled this revision from "Fix unexpected nullptr in ConceptSpecializationExpr's ArgsAsWritten field" to "Summary: Fix ArgsAsWritten being null for ConceptSpecializationExpr in certain circumstances when parsing ASTs". yeswalrus added a

[PATCH] D146678: Fix unexpected nullptr in ConceptSpecializationExpr's ArgsAsWritten field

yeswalrus added a comment. I can handle it. The instructions here: https://llvm.org/docs/Contributing.html#how-to-submit-a-patch only talk about merging to main, but I was rather hoping to get this also merged into the eventual 16.0.1. Is there a feature branch for that already? Repository:

[PATCH] D146678: Fix unexpected nullptr in ConceptSpecializationExpr's ArgsAsWritten field

yeswalrus added a comment. @erichkeane What are the next steps to make this land? Looks like the build servers have been stuck waiting for an agent for over 24h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146678/new/ https://reviews.llvm.org/D14

[PATCH] D146680: Fix unexpected nullptr in ConceptSpecializationExpr's ArgsAsWritten field

yeswalrus added a comment. Hoping this can make it into clang-16.0.1, since the crash this causes makes clangd unusable in codebases using concepts in template arguments in this manner. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146680/new/ ht

[PATCH] D146680: Fix unexpected nullptr in ConceptSpecializationExpr's ArgsAsWritten field

yeswalrus added a comment. Resolves https://github.com/llvm/llvm-project/issues/61486, Similar to https://reviews.llvm.org/D146678 but targeting the llvm-16 series. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146680/new/ https://reviews.llvm.org

[PATCH] D146680: Add test for AST Writer crash

yeswalrus created this revision. Herald added a project: All. yeswalrus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix ArgsAsWritten being null in certain circumstances when parsing ASTs Repository: rG LLVM Github Monorepo https:/

[PATCH] D146678: Summary: Fix ArgsAsWritten being null for ConceptSpecializationExpr in certain circumstances when parsing ASTs

yeswalrus added a comment. Solves issue: https://github.com/llvm/llvm-project/issues/61486 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146678/new/ https://reviews.llvm.org/D146678 ___ cfe-commits maili

[PATCH] D146678: Summary: Fix ArgsAsWritten being null for ConceptSpecializationExpr in certain circumstances when parsing ASTs

yeswalrus created this revision. Herald added a project: All. yeswalrus requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D146678 Files: clang/include/clang/AST/ExprConcepts.h