w2yehia wrote:
@mstorsjo FYI: https://github.com/llvm/llvm-project/commit/9ef7287d425
https://github.com/llvm/llvm-project/pull/127858
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Wael Yehia
Date: 2025-03-12T03:13:33Z
New Revision: 9ef7287d42526014abb0cf2aa53ac2c3087198be
URL:
https://github.com/llvm/llvm-project/commit/9ef7287d42526014abb0cf2aa53ac2c3087198be
DIFF:
https://github.com/llvm/llvm-project/commit/9ef7287d42526014abb0cf2aa53ac2c3087198be.diff
LOG: [p
w2yehia wrote:
> So I believe this should be generalized to all of Windows (and/or generalized
> to check for a COFF object file format?) instead of singling out specifically
> MSVC only.
Thanks for checking. I can fix the condition but can you please let me know
which of the two options you
w2yehia wrote:
> Can you summarize the high level use case which didn't work before, and in
> which way it used to fail before, which gets fixed by this change?
Continuous profiling (that is continuous profile syncing to disk) is an
existing feature, which is OFF by default on most platforms.
https://github.com/w2yehia closed
https://github.com/llvm/llvm-project/pull/127858
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/w2yehia edited
https://github.com/llvm/llvm-project/pull/127858
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -6,6 +6,7 @@
// RUN: %clang --target=powerpc64-ibm-aix -fprofile-generate
-fprofile-continuous -### -c %s 2>&1 | FileCheck %s --check-prefix=RELOC
// RUN: %clang --target=x86_64-unknown-fuchsia -fprofile-generate
-fprofile-continuous -### -c %s 2>&1 | FileCheck %s --check
w2yehia wrote:
> Doesn't mingw target support it?
Sorry I don't know. I was hoping someone familiar with clang on windows to
comment.
https://github.com/llvm/llvm-project/pull/127858
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
https://github.com/w2yehia updated
https://github.com/llvm/llvm-project/pull/127858
>From 843f78e9826b037a7bfb0913728a11eb249f4181 Mon Sep 17 00:00:00 2001
From: Wael Yehia
Date: Wed, 19 Feb 2025 06:25:16 +
Subject: [PATCH 1/2] [profile] runtime counter relocation is needed on
windows-msvc
https://github.com/w2yehia created
https://github.com/llvm/llvm-project/pull/127858
Continuous profiling syncing is [supported on
windows,](https://github.com/llvm/llvm-project/pull/124353#issuecomment-2649075857)
and it also relies on runtime counter relocation (based on this
[test](https://
w2yehia wrote:
> > Just saw this in LLVM weekly. But this is not supported on Windows right?
> > Only the UNIX platforms that can mmap? In that case it the limitation needs
> > to be documented
>
> It is supported! We have [an `mmap` implementation for
> Windows](https://github.com/llvm/llvm-
w2yehia wrote:
> LLVM Buildbot has detected a new failure on builder `clang-m68k-linux-cross`
> running on `suse-gary-m68k-cross` while building `clang` at step 4 "build
> stage 1".
Unrelated or noise. That buildbot had the exact failure few drivers
[earlier](https://lab.llvm.org/buildbot/#/b
w2yehia wrote:
thanks @MaskRay
https://github.com/llvm/llvm-project/pull/124353
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/w2yehia updated
https://github.com/llvm/llvm-project/pull/124353
>From abef90fe8f46431a5fb8b7fe717c9fb65eb30266 Mon Sep 17 00:00:00 2001
From: Wael Yehia
Date: Thu, 23 Jan 2025 00:03:15 +
Subject: [PATCH 1/8] [PGO] Add a clang option -fprofile-continuous that
enables PGO
https://github.com/w2yehia closed
https://github.com/llvm/llvm-project/pull/124353
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/w2yehia updated
https://github.com/llvm/llvm-project/pull/124353
>From abef90fe8f46431a5fb8b7fe717c9fb65eb30266 Mon Sep 17 00:00:00 2001
From: Wael Yehia
Date: Thu, 23 Jan 2025 00:03:15 +
Subject: [PATCH 1/8] [PGO] Add a clang option -fprofile-continuous that
enables PGO
https://github.com/w2yehia updated
https://github.com/llvm/llvm-project/pull/124353
>From abef90fe8f46431a5fb8b7fe717c9fb65eb30266 Mon Sep 17 00:00:00 2001
From: Wael Yehia
Date: Thu, 23 Jan 2025 00:03:15 +
Subject: [PATCH 1/8] [PGO] Add a clang option -fprofile-continuous that
enables PGO
https://github.com/w2yehia updated
https://github.com/llvm/llvm-project/pull/124353
>From abef90fe8f46431a5fb8b7fe717c9fb65eb30266 Mon Sep 17 00:00:00 2001
From: Wael Yehia
Date: Thu, 23 Jan 2025 00:03:15 +
Subject: [PATCH 1/8] [PGO] Add a clang option -fprofile-continuous that
enables PGO
w2yehia wrote:
Thank you to the reviewers.
I'll merge this tonight if I get no further feedback.
https://github.com/llvm/llvm-project/pull/124353
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cf
@@ -0,0 +1,21 @@
+// 1) test on platforms that (do or do not) require runtime relocation
+//
+// RUN: %clang -target x86_64-darwin -fprofile-generate -fprofile-continuous
-### -c %s 2>&1 | FileCheck %s --check-prefix=NO_RELOC
+// NO_RELOC: "-cc1" {{.*}} "-fprofile-continuous"
+//
https://github.com/w2yehia edited
https://github.com/llvm/llvm-project/pull/124353
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3033,6 +3033,24 @@ indexed format, regardeless whether it is produced by
frontend or the IR pass.
overhead. ``prefer-atomic`` will be transformed to ``atomic`` when supported
by the target, or ``single`` otherwise.
+.. option:: -fprofile-continuous
+
+ Enables the co
https://github.com/w2yehia updated
https://github.com/llvm/llvm-project/pull/124353
>From abef90fe8f46431a5fb8b7fe717c9fb65eb30266 Mon Sep 17 00:00:00 2001
From: Wael Yehia
Date: Thu, 23 Jan 2025 00:03:15 +
Subject: [PATCH 1/7] [PGO] Add a clang option -fprofile-continuous that
enables PGO
@@ -1120,3 +1120,23 @@
// RUN:-c \
// RUN: | FileCheck --check-prefixes=CHECK-K-UNUSED %s
// CHECK-K-UNUSED: clang: warning: -K: 'linker' input unused
[-Wunused-command-line-argument]
+
+
+// This test verifies that the linker doesn't include '-latomic' when no
sani
@@ -1120,3 +1120,23 @@
// RUN:-c \
// RUN: | FileCheck --check-prefixes=CHECK-K-UNUSED %s
// CHECK-K-UNUSED: clang: warning: -K: 'linker' input unused
[-Wunused-command-line-argument]
+
+
+// This test verifies that the linker doesn't include '-latomic' when no
sani
@@ -1120,3 +1120,23 @@
// RUN:-c \
// RUN: | FileCheck --check-prefixes=CHECK-K-UNUSED %s
// CHECK-K-UNUSED: clang: warning: -K: 'linker' input unused
[-Wunused-command-line-argument]
+
+
+// This test verifies that the linker doesn't include '-latomic' when no
sani
https://github.com/w2yehia requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/125388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/w2yehia deleted
https://github.com/llvm/llvm-project/pull/125388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1120,3 +1120,23 @@
// RUN:-c \
// RUN: | FileCheck --check-prefixes=CHECK-K-UNUSED %s
// CHECK-K-UNUSED: clang: warning: -K: 'linker' input unused
[-Wunused-command-line-argument]
+
+
+// This test verifies that the linker doesn't include '-latomic' when no
sani
w2yehia wrote:
I believe all comments have been addressed.
friendly ping.
@petrhosek any feedback please?
https://github.com/llvm/llvm-project/pull/124353
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
@@ -338,6 +338,10 @@ void aix::Linker::ConstructJob(Compilation &C, const
JobAction &JA,
CmdArgs.push_back("-lpthread");
}
const char *Exec = Args.MakeArgString(ToolChain.GetLinkerPath());
+
+ if (Sanitize.hasAnySanitizer() && IsArch32Bit) {
w2yehia
@@ -239,6 +239,9 @@ append_list_if(SANITIZER_LIMIT_FRAME_SIZE
-Wframe-larger-than=570
append_list_if(COMPILER_RT_HAS_WGLOBAL_CONSTRUCTORS_FLAG -Wglobal-constructors
SANITIZER_CFLAGS)
+# Suppress -Watomic-alignment warnings by not treating them as errors
---
@@ -239,6 +239,9 @@ append_list_if(SANITIZER_LIMIT_FRAME_SIZE
-Wframe-larger-than=570
append_list_if(COMPILER_RT_HAS_WGLOBAL_CONSTRUCTORS_FLAG -Wglobal-constructors
SANITIZER_CFLAGS)
+# Suppress -Watomic-alignment warnings by not treating them as errors
---
https://github.com/w2yehia edited
https://github.com/llvm/llvm-project/pull/125388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -785,6 +786,34 @@ static void addPGOAndCoverageFlags(const ToolChain &TC,
Compilation &C,
D.Diag(diag::err_drv_unsupported_option_argument)
<< A->getSpelling() << Val;
}
+ if (const auto *A = Args.getLastArg(options::OPT_fprofile_continuous)) {
+if (!
@@ -0,0 +1,21 @@
+// 1) test on platforms that (do or do not) require runtime relocation
+//
+// RUN: %clang -target x86_64-darwin -fprofile-generate -fprofile-continuous
-### -c %s 2>&1 | FileCheck %s --check-prefix=NO_RELOC
+// NO_RELOC: "-cc1" {{.*}} "-fprofile-continuous"
+//
https://github.com/w2yehia updated
https://github.com/llvm/llvm-project/pull/124353
>From abef90fe8f46431a5fb8b7fe717c9fb65eb30266 Mon Sep 17 00:00:00 2001
From: Wael Yehia
Date: Thu, 23 Jan 2025 00:03:15 +
Subject: [PATCH 1/5] [PGO] Add a clang option -fprofile-continuous that
enables PGO
https://github.com/w2yehia edited
https://github.com/llvm/llvm-project/pull/124353
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -785,6 +786,34 @@ static void addPGOAndCoverageFlags(const ToolChain &TC,
Compilation &C,
D.Diag(diag::err_drv_unsupported_option_argument)
<< A->getSpelling() << Val;
}
+ if (const auto *A = Args.getLastArg(options::OPT_fprofile_continuous)) {
+if (!
https://github.com/w2yehia edited
https://github.com/llvm/llvm-project/pull/124353
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,16 @@
+// RUN: %clang %s -S -emit-llvm -fprofile-generate -fprofile-continuous -o - |
FileCheck %s --check-prefix=IRPGO
w2yehia wrote:
In this test, I'm testing both the driver (lines 4,5,8) and the clang codegen
(lines 1,2,3,6).
Should I split it in
https://github.com/w2yehia edited
https://github.com/llvm/llvm-project/pull/124353
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -785,6 +786,34 @@ static void addPGOAndCoverageFlags(const ToolChain &TC,
Compilation &C,
D.Diag(diag::err_drv_unsupported_option_argument)
<< A->getSpelling() << Val;
}
+ if (const auto *A = Args.getLastArg(options::OPT_fprofile_continuous)) {
+if (!
@@ -133,6 +133,16 @@ std::string getDefaultProfileGenName() {
: "default_%m.profraw";
}
+// Path and name of file used for profile generation
+std::string getProfileGenName(const CodeGenOptions &CodeGenOpts) {
w2yehia wrote:
sure. FYI I was follo
https://github.com/w2yehia updated
https://github.com/llvm/llvm-project/pull/124353
>From abef90fe8f46431a5fb8b7fe717c9fb65eb30266 Mon Sep 17 00:00:00 2001
From: Wael Yehia
Date: Thu, 23 Jan 2025 00:03:15 +
Subject: [PATCH 1/2] [PGO] Add a clang option -fprofile-continuous that
enables PGO
@@ -1886,6 +1886,11 @@ def fprofile_update_EQ : Joined<["-"],
"fprofile-update=">,
Values<"atomic,prefer-atomic,single">,
MetaVarName<"">, HelpText<"Set update method of profile counters">,
MarshallingInfoFlag>;
+def fprofile_continuous : Flag<["-"], "fprofile-cont
@@ -3033,6 +3033,14 @@ indexed format, regardeless whether it is produced by
frontend or the IR pass.
overhead. ``prefer-atomic`` will be transformed to ``atomic`` when supported
by the target, or ``single`` otherwise.
+.. option:: -fprofile-continuous
w2
@@ -3033,6 +3033,14 @@ indexed format, regardeless whether it is produced by
frontend or the IR pass.
overhead. ``prefer-atomic`` will be transformed to ``atomic`` when supported
by the target, or ``single`` otherwise.
+.. option:: -fprofile-continuous
w2
@@ -3033,6 +3033,14 @@ indexed format, regardeless whether it is produced by
frontend or the IR pass.
overhead. ``prefer-atomic`` will be transformed to ``atomic`` when supported
by the target, or ``single`` otherwise.
+.. option:: -fprofile-continuous
w2
w2yehia wrote:
Follow up PR https://github.com/w2yehia/llvm-project/pull/1 to switch all
applicable tests in `compiler-rt/test/profile/ContinuousSyncMode` to use
`-fprofile-continuous`
https://github.com/llvm/llvm-project/pull/124353
___
cfe-commits
https://github.com/w2yehia created
https://github.com/llvm/llvm-project/pull/124353
None
>From abef90fe8f46431a5fb8b7fe717c9fb65eb30266 Mon Sep 17 00:00:00 2001
From: Wael Yehia
Date: Thu, 23 Jan 2025 00:03:15 +
Subject: [PATCH] [PGO] Add a clang option -fprofile-continuous that enables
P
https://github.com/w2yehia approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/120276
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -12,14 +12,27 @@
// CHECK-CC-S-NOT: -emit-llvm
// CHECK-CC-S-NOT: -ffat-lto-objects
-/// When LTO is enabled, we expect LLVM IR output and -ffat-lto-objects to be
passed to cc1.
+/// When fat LTO is enabled with -S, we expect asm output and
-ffat-lto-objects to be passed
https://github.com/w2yehia approved this pull request.
https://github.com/llvm/llvm-project/pull/78285
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
w2yehia wrote:
@qiongsiwu explained to me offline that the issue on Windows is that calls
__llvm_orderfile_dump fail so he's not able to execute the instrumented program
if it calls that function.
Regarding the `compiler-rt/test/profile/instrprof-api.c` test. The disadvantage
of having a profd
w2yehia wrote:
will need instructions for how to recreate this file in the future.
https://github.com/llvm/llvm-project/pull/78285
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
https://github.com/w2yehia approved this pull request.
https://github.com/llvm/llvm-project/pull/76471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/w2yehia approved this pull request.
https://github.com/llvm/llvm-project/pull/68389
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Wael Yehia
Date: 2023-09-01T03:17:54Z
New Revision: 534e23e47b03292f80a3c8265a88a790f610d3f5
URL:
https://github.com/llvm/llvm-project/commit/534e23e47b03292f80a3c8265a88a790f610d3f5
DIFF:
https://github.com/llvm/llvm-project/commit/534e23e47b03292f80a3c8265a88a790f610d3f5.diff
LOG: [T
Author: Wael Yehia
Date: 2023-07-19T17:37:15Z
New Revision: 645f6dcd69a5315dbe2a6b49fdd8d356512544e8
URL:
https://github.com/llvm/llvm-project/commit/645f6dcd69a5315dbe2a6b49fdd8d356512544e8
DIFF:
https://github.com/llvm/llvm-project/commit/645f6dcd69a5315dbe2a6b49fdd8d356512544e8.diff
LOG: [T
Author: Wael Yehia
Date: 2023-07-11T16:26:48Z
New Revision: 7ec844c881a23bf0d2e4450ac9ca97091490084f
URL:
https://github.com/llvm/llvm-project/commit/7ec844c881a23bf0d2e4450ac9ca97091490084f
DIFF:
https://github.com/llvm/llvm-project/commit/7ec844c881a23bf0d2e4450ac9ca97091490084f.diff
LOG: [D
Author: Wael Yehia
Date: 2023-03-28T14:53:12Z
New Revision: 256914bf1c13a7f2dc1343b9761cae15b8b37e00
URL:
https://github.com/llvm/llvm-project/commit/256914bf1c13a7f2dc1343b9761cae15b8b37e00
DIFF:
https://github.com/llvm/llvm-project/commit/256914bf1c13a7f2dc1343b9761cae15b8b37e00.diff
LOG: [A
Author: Wael Yehia
Date: 2023-03-27T15:36:41Z
New Revision: da92f2fb33c4e5fc570a51b0615e3d30a5b0bf8f
URL:
https://github.com/llvm/llvm-project/commit/da92f2fb33c4e5fc570a51b0615e3d30a5b0bf8f
DIFF:
https://github.com/llvm/llvm-project/commit/da92f2fb33c4e5fc570a51b0615e3d30a5b0bf8f.diff
LOG: [A
Author: Paul Scoropan
Date: 2023-01-26T00:39:51Z
New Revision: 5e72407635a43b8b7f85c1658b6738f023a21f03
URL:
https://github.com/llvm/llvm-project/commit/5e72407635a43b8b7f85c1658b6738f023a21f03
DIFF:
https://github.com/llvm/llvm-project/commit/5e72407635a43b8b7f85c1658b6738f023a21f03.diff
LOG:
Author: Wael Yehia
Date: 2022-10-21T16:32:42Z
New Revision: 461a1836d3d77371bb6271fefd645897997a22b8
URL:
https://github.com/llvm/llvm-project/commit/461a1836d3d77371bb6271fefd645897997a22b8
DIFF:
https://github.com/llvm/llvm-project/commit/461a1836d3d77371bb6271fefd645897997a22b8.diff
LOG: [P
Author: Wael Yehia
Date: 2022-05-05T04:10:39Z
New Revision: 2407c13aa4a42f3a3438ae2d03fa38df0a5fd30b
URL:
https://github.com/llvm/llvm-project/commit/2407c13aa4a42f3a3438ae2d03fa38df0a5fd30b
DIFF:
https://github.com/llvm/llvm-project/commit/2407c13aa4a42f3a3438ae2d03fa38df0a5fd30b.diff
LOG: [A
Author: Wael Yehia
Date: 2022-04-21T17:01:37Z
New Revision: f296b4c444625f84be1db27cfd52a3d16387f456
URL:
https://github.com/llvm/llvm-project/commit/f296b4c444625f84be1db27cfd52a3d16387f456
DIFF:
https://github.com/llvm/llvm-project/commit/f296b4c444625f84be1db27cfd52a3d16387f456.diff
LOG: [A
Author: Tarique Islam
Date: 2021-11-30T22:49:55Z
New Revision: 0850655da69a700b7def4fe8d9a44d1c8d55877c
URL:
https://github.com/llvm/llvm-project/commit/0850655da69a700b7def4fe8d9a44d1c8d55877c
DIFF:
https://github.com/llvm/llvm-project/commit/0850655da69a700b7def4fe8d9a44d1c8d55877c.diff
LOG:
Author: Wael Yehia
Date: 2021-04-26T17:02:06Z
New Revision: 91db11c98db5de3e6079bddc0aba896ec3d3d0ad
URL:
https://github.com/llvm/llvm-project/commit/91db11c98db5de3e6079bddc0aba896ec3d3d0ad
DIFF:
https://github.com/llvm/llvm-project/commit/91db11c98db5de3e6079bddc0aba896ec3d3d0ad.diff
LOG: XF
Author: Wael Yehia
Date: 2021-04-19T16:39:48Z
New Revision: 369c0e0f48dd3585566d251cc99955dbdeed84a1
URL:
https://github.com/llvm/llvm-project/commit/369c0e0f48dd3585566d251cc99955dbdeed84a1
DIFF:
https://github.com/llvm/llvm-project/commit/369c0e0f48dd3585566d251cc99955dbdeed84a1.diff
LOG: [A
70 matches
Mail list logo
