[PATCH] D133633: [CMake] Add ClangBootstrap configuration

thevinster added inline comments. Comment at: clang/cmake/modules/ClangBootstrap.cmake:11 +macro(clang_bootstrap_add name) + cmake_parse_arguments(ARG "" "LINKER;AR;RANLIB;OBJCOPY;STRIP" +"DEPENDS;TABLEGEN;CMAKE_ARGS;BUILD_TOOL_ARGS" Were you planning to als

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

thevinster added inline comments. Comment at: lld/lib/CMakeLists.txt:1 add_subdirectory(Core) Just wondering, can't we delete this too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/ https://reviews.l

[PATCH] D113738: [LTO] Allow passing -Os/-Oz as the optimization level

thevinster added inline comments. Comment at: lld/Common/Args.cpp:29 +OptimizationLevel args::getOptLevel(llvm::opt::InputArgList &args, +unsigned int key, nit: `getOptLevel` seems a bit too generic for something that's LTO s