bansan added a comment.
About my template example: I wanted to say that the actual
`bugprone-implicit-widening-of-multiplication-result` rule looks to not analyze
template calculation problem. So I think it's better to use the desugared type
(`size_t`).
It's not acceptable (IMHO) that the hard
bansan added a comment.
The current rule is quite simple. I tried this example:
template
T h(int x) {
return 1024 * 1024 * 1024 * x;
}
int main() {
h(1024);
}
The rule does not complain. So I think that the "resolved" type (`size_t`)
should be use instead of the templated o
bansan added a comment.
Herald added a subscriber: StephenFan.
I just made a test:
#include
#include
int64_t f(int x) {
return 1024 * 1024 * 1024 * x;
}
void g(int x) {
std::vector b;
b.reserve(1024 * 1024 * 1024 * x);
}
int main() {
f(1024);
g(1024);
bansan added a comment.
@kbobyrev Thanks, it's probably that. I thought I could send a patch/commit
with my Phabricator account.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104981/new/
https://reviews.llvm.org/D104981
__
bansan added a comment.
@kbobyrev Yes please. I downloaded arc. I created a commit where last line is
"Differential Revision: https://reviews.llvm.org/D104981";.
I linked my github account to llvm's phabricator.
But when I `arc land`, I can't logon with my github username.
STRATEGY Merging
bansan added a comment.
Right, this is my first patch. I based this one on
https://reviews.llvm.org/D28334
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104981/new/
https://reviews.llvm.org/D104981
___
bansan created this revision.
bansan added a reviewer: clang-tools-extra.
bansan added a project: clang-tools-extra.
Herald added a subscriber: xazax.hun.
bansan requested review of this revision.
Herald added a subscriber: cfe-commits.
This patch allows the use of --line-filter in clang-tidy.py f
