[PATCH] D135804: [clang][ExtractAPI] Ignore fully anonymous RecordDecls

QuietMisdreavus accepted this revision. QuietMisdreavus added a comment. This revision is now accepted and ready to land. It would be ideal to be able to properly handle nested types like this, but for right now this is causing a crash in Swift-DocC, so this patch will at least get that working.

[PATCH] D125678: [clang][extract-api] Don't emit symbols prefixed with an underscore

QuietMisdreavus added a comment. clang-format failed: --- clang-format changed files: clang/test/ExtractAPI/underscored.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125678/new/ https://reviews.llvm.org/D125678

[PATCH] D125678: [clang][extract-api] Don't emit symbols prefixed with an underscore

QuietMisdreavus accepted this revision. QuietMisdreavus added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125678/new/ https://reviews.llvm.org/D125678 _

[PATCH] D123391: [clang][extract-api] Emit "navigator" property of "name" in SymbolGraph

QuietMisdreavus accepted this revision. QuietMisdreavus added a comment. This revision is now accepted and ready to land. Looks great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123391/new/ https://reviews.llvm.org/D123391 _

[PATCH] D123391: [clang][extract-api] Emit "navigator" property of "name" in SymbolGraph

QuietMisdreavus added a comment. This looks good! Just one question. Comment at: clang/test/ExtractAPI/objc_interface.m:198 +"kind": "identifier", +"spelling": "getWithProperty:" + } I'm curious: Does this properly handle Object

[PATCH] D123259: [clang][ExtractAPI] Fix appendSpace in DeclarationFragments

QuietMisdreavus accepted this revision. QuietMisdreavus added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123259/new/ https://reviews.llvm.org/D123259 _

[PATCH] D123261: [clang][ExtractAPI] Fix declaration fragments for ObjC methods

QuietMisdreavus accepted this revision. QuietMisdreavus added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123261/new/ https://reviews.llvm.org/D123261 _

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

QuietMisdreavus accepted this revision. QuietMisdreavus added a comment. This revision is now accepted and ready to land. I like the idea of using the RAII context/guard to manage the path components stack. I have one non-blocking comment about the rest of the patch now. Comme

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

QuietMisdreavus added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:510 Symbols.emplace_back(std::move(*Obj)); + PathComponentContext.pop_back(); } dang wrote: > dang wrote: > > zixuw wrote: > > > zixuw wrote: > >

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

QuietMisdreavus added a comment. In D123045#3427992 , @zixuw wrote: > In D123045#3427699 , > @QuietMisdreavus wrote: > >> After a quick scan comparing the current output of these symbol graphs with >> the primar

[PATCH] D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer

QuietMisdreavus added a comment. After a quick scan comparing the current output of these symbol graphs with the primary library used for reading them , the last thing i can spot that's "off" is that the "function signature" is currently being seri

[PATCH] D117809: [clang] Add an extract-api driver option

QuietMisdreavus added inline comments. Comment at: clang/include/clang/Driver/Types.def:103 TYPE("hip-fatbin", HIP_FATBIN, INVALID, "hipfb", phases::Compile, phases::Backend, phases::Assemble, phases::Link) +TYPE("api-information", API_INFO,