[PATCH] D50942: SemaExceptionSpec: ensure old/new specs are both parsed and evaluated when comparing

vitaut added inline comments. Comment at: lib/Sema/SemaExceptionSpec.cpp:915 + // lexically-surrounding class. + switch (New->getType()->castAs()->getExceptionSpecType()) { + case EST_Unparsed: Did you mean `Old` here? Repository: rC Clang https://review

[PATCH] D50002: [coroutines] Fix handling of dependent co_await in StmtProfiler

vitaut added a comment. > Do you need someone to commit this for you? Yes, please. I don't have commit rights. Repository: rC Clang https://reviews.llvm.org/D50002 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D50002: [coroutines] Fix handling of dependent co_await in StmtProfiler

vitaut created this revision. vitaut added reviewers: rsmith, GorNishanov, EricWF. Herald added subscribers: cfe-commits, modocache. Fix "Invalid operator call kind" error (`llvm_unreachable`) in `DecodeOperatorCall` when compiling the following example with `-emit-pch`: struct S {}; S operat

[PATCH] D49813: [libc++] Make compile with gcc 4.8.5

vitaut added a comment. @EricWF could you or someone else commit this as I don't have commit access? Thanks. Repository: rCXX libc++ https://reviews.llvm.org/D49813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D49813: [libc++] Make compile with gcc 4.8.5

vitaut created this revision. vitaut added a reviewer: EricWF. Herald added subscribers: ldionne, christof. This fixes an error when compiling `` with gcc 4.8.5: .../libcxx/src/experimental/filesystem/filesystem_common.h:137:34: error: redeclaration ‘T std::experimental::filesystem::v1::det