[PATCH] D52578: Thread safety analysis: Allow scoped releasing of capabilities

2018-11-27 Thread Victor Costan via Phabricator via cfe-commits
pwnall added a comment. In D52578#1307145 , @aaronpuchert wrote: > To be clear, I'm not a big fan of this change myself, I just wanted to see if > it was feasible. My personal opinion, as I wrote in the bug report, is that > scoped releasing of mutexes

[PATCH] D52578: Thread safety analysis: Allow scoped releasing of capabilities

2018-10-05 Thread Victor Costan via Phabricator via cfe-commits
pwnall added a comment. Thank you for clarifying, Aaron! I probably used Phabricator incorrectly. My intent was to state that the tests LGTM and express support for the functionality in this patch. Please definitely address all review comments before landing. Repository: rC Clang https://r

[PATCH] D52578: Thread safety analysis: Allow scoped releasing of capabilities

2018-10-05 Thread Victor Costan via Phabricator via cfe-commits
pwnall accepted this revision. pwnall added a comment. This revision is now accepted and ready to land. test/SemaCXX/warn-thread-safety-analysis.cpp LGTM -- this is the functionality that we need in Chrome to use thread safety annotations for AutoUnlock. very non-authoritative opinion - I think