loumalouomega wrote:
> > I have a certain version of Ubuntu with a certain version of Clang, not
> > custom compiled.
>
> @loumalouomega Can you please confirm if the Clang comes from the official
> Debian or Ubuntu APT repository?
>
> If that is the case, I think we can, going forward, conta
https://github.com/loumalouomega updated
https://github.com/llvm/llvm-project/pull/127066
From 6c210298a5aab4eeb0d155534d739e21ba315469 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Vicente=20Mataix=20Ferr=C3=A1ndiz?=
Date: Thu, 13 Feb 2025 15:28:30 +0100
Subject: [PATCH 1/5] [tool] Remove legacy ar
https://github.com/loumalouomega closed
https://github.com/llvm/llvm-project/pull/127066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
loumalouomega wrote:
> > should have delivered a run-clang-tidy.py that is appropriate for that
> > version.
>
> It should, but does it? A typical installation comes from installing the
> Ubuntu packages, do they include `run-clang-tidy.py` at all?
>
> If not, then I don't think `run-clang-ti
loumalouomega wrote:
> I am a bit confused here. If you're using the **system** Clang toolchain
> assembled by your company (outside of your control), that toolchain should
> have delivered a `run-clang-tidy.py` that is appropriate for that version.
>
> If you are using `run-clang-tidy.py` fro
@@ -446,6 +448,12 @@ async def main() -> None:
action="store_true",
help="Allow empty enabled checks.",
)
+parser.add_argument(
+"-ignore-insert-conflict",
loumalouomega wrote:
The problem is that `-ignore-insert-conflict` does
https://github.com/loumalouomega updated
https://github.com/llvm/llvm-project/pull/127066
From 6c210298a5aab4eeb0d155534d739e21ba315469 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Vicente=20Mataix=20Ferr=C3=A1ndiz?=
Date: Thu, 13 Feb 2025 15:28:30 +0100
Subject: [PATCH 1/5] [tool] Remove legacy ar
https://github.com/loumalouomega edited
https://github.com/llvm/llvm-project/pull/127066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/loumalouomega edited
https://github.com/llvm/llvm-project/pull/127066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -446,6 +448,12 @@ async def main() -> None:
action="store_true",
help="Allow empty enabled checks.",
)
+parser.add_argument(
+"-ignore-insert-conflict",
loumalouomega wrote:
Should be Okay now.
https://github.com/llvm/llvm-p
https://github.com/loumalouomega updated
https://github.com/llvm/llvm-project/pull/127066
From 6c210298a5aab4eeb0d155534d739e21ba315469 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Vicente=20Mataix=20Ferr=C3=A1ndiz?=
Date: Thu, 13 Feb 2025 15:28:30 +0100
Subject: [PATCH 1/5] [tool] Remove legacy ar
https://github.com/loumalouomega updated
https://github.com/llvm/llvm-project/pull/127066
From 6c210298a5aab4eeb0d155534d739e21ba315469 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Vicente=20Mataix=20Ferr=C3=A1ndiz?=
Date: Thu, 13 Feb 2025 15:28:30 +0100
Subject: [PATCH 1/4] [tool] Remove legacy ar
@@ -446,6 +448,12 @@ async def main() -> None:
action="store_true",
help="Allow empty enabled checks.",
)
+parser.add_argument(
+"-ignore-insert-conflict",
loumalouomega wrote:
Sorry if I use an old version of clang, the system
https://github.com/loumalouomega edited
https://github.com/llvm/llvm-project/pull/127066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -446,6 +448,12 @@ async def main() -> None:
action="store_true",
help="Allow empty enabled checks.",
)
+parser.add_argument(
+"-ignore-insert-conflict",
+action="store_true",
+default=True,
loumalouomega wrote:
loumalouomega wrote:
> LGTM. Please update release note also. After that, feel free to ping me to
> merge it if you do not have permission.
Can you help me?, I have no experience in this repository
https://github.com/llvm/llvm-project/pull/127066
__
https://github.com/loumalouomega updated
https://github.com/llvm/llvm-project/pull/127066
From 6c210298a5aab4eeb0d155534d739e21ba315469 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Vicente=20Mataix=20Ferr=C3=A1ndiz?=
Date: Thu, 13 Feb 2025 15:28:30 +0100
Subject: [PATCH 1/4] [tool] Remove legacy ar
@@ -198,9 +198,11 @@ def find_binary(arg: str, name: str, build_path: str) ->
str:
def apply_fixes(
args: argparse.Namespace, clang_apply_replacements_binary: str, tmpdir: str
) -> None:
-"""Calls clang-apply-fixes on a given directory."""
+"""Calls clang-apply-rep
https://github.com/loumalouomega updated
https://github.com/llvm/llvm-project/pull/127066
From 6c210298a5aab4eeb0d155534d739e21ba315469 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Vicente=20Mataix=20Ferr=C3=A1ndiz?=
Date: Thu, 13 Feb 2025 15:28:30 +0100
Subject: [PATCH 1/4] [tool] Remove legacy ar
@@ -198,9 +198,11 @@ def find_binary(arg: str, name: str, build_path: str) ->
str:
def apply_fixes(
args: argparse.Namespace, clang_apply_replacements_binary: str, tmpdir: str
) -> None:
-"""Calls clang-apply-fixes on a given directory."""
+"""Calls clang-apply-rep
https://github.com/loumalouomega updated
https://github.com/llvm/llvm-project/pull/127066
From 6c210298a5aab4eeb0d155534d739e21ba315469 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Vicente=20Mataix=20Ferr=C3=A1ndiz?=
Date: Thu, 13 Feb 2025 15:28:30 +0100
Subject: [PATCH 1/3] [tool] Remove legacy ar
https://github.com/loumalouomega edited
https://github.com/llvm/llvm-project/pull/127066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/loumalouomega edited
https://github.com/llvm/llvm-project/pull/127066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
loumalouomega wrote:
> LGTM except for some minor nits. Also, the commit message is misleading, it
> should be something like:
>
> ```
> [clang-tidy] Add support for `-ignore-insert-conflict` in `run-clang-tidy.py`
> ```
Okay, I don'w know the style. BTW,I applied tour comments
https://github
https://github.com/loumalouomega updated
https://github.com/llvm/llvm-project/pull/127066
From 6c210298a5aab4eeb0d155534d739e21ba315469 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Vicente=20Mataix=20Ferr=C3=A1ndiz?=
Date: Thu, 13 Feb 2025 15:28:30 +0100
Subject: [PATCH 1/3] [tool] Remove legacy ar
https://github.com/loumalouomega updated
https://github.com/llvm/llvm-project/pull/127066
From 6c210298a5aab4eeb0d155534d739e21ba315469 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Vicente=20Mataix=20Ferr=C3=A1ndiz?=
Date: Thu, 13 Feb 2025 15:28:30 +0100
Subject: [PATCH 1/2] [tool] Remove legacy ar
loumalouomega wrote:
@PiotrZSL FYI
https://github.com/llvm/llvm-project/pull/127066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/loumalouomega edited
https://github.com/llvm/llvm-project/pull/127066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/loumalouomega edited
https://github.com/llvm/llvm-project/pull/127066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/loumalouomega updated
https://github.com/llvm/llvm-project/pull/127066
From 6c210298a5aab4eeb0d155534d739e21ba315469 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Vicente=20Mataix=20Ferr=C3=A1ndiz?=
Date: Thu, 13 Feb 2025 15:28:30 +0100
Subject: [PATCH 1/2] [tool] Remove legacy ar
loumalouomega wrote:
Ok, so is not legacy, but the contrary. My version of Clang is old. I can
refactor if you want.
https://github.com/llvm/llvm-project/pull/127066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
loumalouomega wrote:
> Best would be to add that option to script and let user decide whatever use
> it or not.
Do you want me to do it?
https://github.com/llvm/llvm-project/pull/127066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://
loumalouomega wrote:
> > Remove legacy argument `-ignore-insert-conflict` flag from
> > `run-clang-tidy.py`
>
> Could you explain more about `legacy` argument `-ignore-insert-conflict`. It
> still in `clang-apply-replacements` tool.
>
> ```
> USAGE: clang-apply-replacements [options]
>
> OP
33 matches
Mail list logo
