[PATCH] D144027: [NFC][IR] Make Module::getGlobalList() private

vporpo added a comment. Yeah sorry about that, I reverted it here: b5f239363a3 Revert "[NFC][IR] Make Module::getGlobalList() private" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144027/new/ https://reviews.llvm.org/D144027

[PATCH] D144027: [NFC][IR] Make Module::getGlobalList() private

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed3e3ee9e30d: [NFC][IR] Make Module::getGlobalList() private (authored by vporpo). Changed prior to commit: https://reviews.llvm.org/D144027?vs=49

[PATCH] D144027: [NFC][IR] Make Module::getGlobalList() private

vporpo updated this revision to Diff 497403. vporpo added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144027/new/ https://reviews.llvm.org/D144027 Files: clang/lib/CodeGen/CGHLSLRuntime.cpp clang/lib/CodeGen/CGObjCMac.cpp

[PATCH] D144027: [NFC][IR] Make Module::getGlobalList() private

vporpo added inline comments. Comment at: llvm/unittests/IR/ModuleTest.cpp:47-49 // Sort the globals by name. EXPECT_FALSE(std::is_sorted(M.global_begin(), M.global_end(), compare)); -M.getGlobalList().sort(compare); I removed this because it is tes

[PATCH] D144027: [NFC][IR] Make Module::getGlobalList() private

vporpo updated this revision to Diff 497367. vporpo marked an inline comment as done. vporpo added a comment. Removed commented out lines from ModuleTest.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144027/new/ https://reviews.llvm.org/D144027

[PATCH] D144027: [NFC][IR] Make Module::getGlobalList() private

vporpo created this revision. vporpo added a reviewer: aeubanks. Herald added subscribers: mattd, gchakrabarti, asavonic, snehasish, ormris, hiraditya. Herald added a project: All. vporpo requested review of this revision. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, jholewin

[PATCH] D140085: [NFC] Rename Instruction::insertAt() to Instruction::insertInto(), to be consistent with BasicBlock::insertInto()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG32b38d248fd3: [NFC] Rename Instruction::insertAt() to Instruction::insertInto(), to be… (authored by vporpo). Repository: rG LLVM Github Monorepo

[PATCH] D140085: [NFC] Rename Instruction::insertAt() to Instruction::insertInto(), to be consistent with BasicBlock::insertInto()

vporpo updated this revision to Diff 483222. vporpo added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140085/new/ https://reviews.llvm.org/D140085 Files: clang/lib/CodeGen/CGCleanup.cpp llvm/docs/ProgrammersManual.rst llv

[PATCH] D140068: [NFC] Rename Function::insertBasicBlockAt() to Function::insert().

This revision was automatically updated to reflect the committed changes. Closed by commit rG80f2f1eabc49: [NFC] Rename Function::insertBasicBlockAt() to Function::insert(). (authored by vporpo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140068/n

[PATCH] D140085: [NFC] Rename Instruction::insertAt() to Instruction::insertInto(), to be consistent with BasicBlock::insertInto()

vporpo created this revision. vporpo added reviewers: aeubanks, asbirlea. Herald added subscribers: kmitropoulou, Enna1, pmatos, asb, ormris, wenlei, hiraditya, jgravelle-google, sbc100, dschuff. Herald added a project: All. vporpo requested review of this revision. Herald added subscribers: llvm-

[PATCH] D140068: [NFC] Rename Function::insertBasicBlockAt() to Function::insert().

vporpo updated this revision to Diff 483032. vporpo added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixed a couple more files that were missing from the original patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D139910: [NFC] Cleanup: Remove Function::getBasicBlockList() when not required.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGadfb23c607ce: [NFC] Cleanup: Remove Function::getBasicBlockList() when not required. (authored by vporpo). Repository: rG LLVM Github Monorepo CH

[PATCH] D139910: [NFC] Cleanup: Remove Function::getBasicBlockList() when not required.

vporpo created this revision. vporpo added reviewers: aeubanks, asbirlea. Herald added subscribers: Moerafaat, zero9178, Enna1, bzcheeseman, mattd, awarzynski, sdasgup3, wenzhicui, wrengr, ormris, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aa

[PATCH] D139906: [IR][NFC] Adds Function::insertBasicBlockAt() to replace things like F->getBasicBlockList().insert()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa19ae77d2a90: [IR][NFC] Adds Function::insertBasicBlockAt() to replace things like F… (authored by vporpo). Changed prior to commit: https://revie

[PATCH] D139906: [IR][NFC] Adds Function::insertBasicBlockAt() to replace things like F->getBasicBlockList().insert()

vporpo created this revision. vporpo added reviewers: aeubanks, asbirlea. Herald added subscribers: zzheng, hiraditya. Herald added a project: All. vporpo requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This is part of a s

[PATCH] D138877: [NFC] Cleanup: Replaces BB->getInstList().insert() with I->insertAt().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG06911ba6ea1e: [NFC] Cleanup: Replaces BB->getInstList().insert() with I->insertAt(). (authored by vporpo). Repository: rG LLVM Github Monorepo CH

[PATCH] D138877: [NFC] Cleanup: Replaces BB->getInstList().insert() with I->insertAt().

vporpo added a comment. Herald added a subscriber: kmitropoulou. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138877/new/ https://reviews.llvm.org/D138877 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D138979: [NFC] Cleanup: Replaces BB->getInstList().splice() with BB->splice().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbebca2b6d559: [NFC] Cleanup: Replaces BB->getInstList().splice() with BB->splice(). (authored by vporpo). Repository: rG LLVM Github Monorepo CHA

[PATCH] D138979: [NFC] Cleanup: Replaces BB->getInstList().splice() with BB->splice().

vporpo created this revision. vporpo added reviewers: asbirlea, aeubanks. Herald added subscribers: ChuanqiXu, hiraditya. Herald added a project: All. vporpo requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This is part of

[PATCH] D138877: [NFC] Cleanup: Replaces BB->getInstList().insert() with I->insertAt().

vporpo created this revision. vporpo added a reviewer: asbirlea. Herald added subscribers: Enna1, ormris, wenlei, hiraditya. Herald added a project: All. vporpo requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This is part