[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

2021-03-18 Thread Varju Janos via Phabricator via cfe-commits
varjujan added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SuspiciousCallArgumentCheck.cpp:51 +{true, 40, 50}, // Substring. +{true, 50, 66}, // Levenshtein. +{true, 75, 85}, // Jaro-Winkler. whisperity wrote: >

[PATCH] D20689: [clang-tidy] Suspicious Call Argument checker

2017-02-08 Thread Varju Janos via Phabricator via cfe-commits
varjujan added a comment. @xazax.hun Yes I do. Obviously some of them seem to be better than the others so I can remove a couple if needed. https://reviews.llvm.org/D20689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D20689: [clang-tidy] Suspicious Call Argument checker

2017-01-03 Thread Varju Janos via Phabricator via cfe-commits
varjujan added a comment. I ran the check on multiple projects and tried to categorize the warnings: real errors, false positives, naming errors and coincidences. The results are attached. I got no warnings on LLVM. F2902037: postgres F2902036: linuxKernel <

[PATCH] D20689: [clang-tidy] Suspicious Call Argument checker

2017-01-03 Thread Varju Janos via Phabricator via cfe-commits
varjujan updated this revision to Diff 82859. varjujan added a comment. Herald added subscribers: JDevlieghere, mgorny. I have implemented some more heuristics to achieve better results. https://reviews.llvm.org/D20689 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp