[PATCH] D126908: [VerifyDiagnosticConsumer] Fix last line being discarded when parsing newline

vangthao added inline comments. Comment at: clang/test/SemaCXX/references.cpp:93 -struct C : B, A { }; // expected-warning {{direct base 'A' is inaccessible due to ambiguity:\nstruct C -> struct B -> struct A\nstruct C -> struct A}} +struct C : B, A { }; // expected-warnin

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67357739c6d3: [AMDGPU] Add remarks to output some resource usage (authored by vangthao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

vangthao updated this revision to Diff 444844. vangthao added a comment. Change `auto &&Argument` to `auto Argument`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123878/new/ https://reviews.llvm.org/D123878 Files: clang/test/Frontend/amdgcn-ma

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

vangthao updated this revision to Diff 444759. vangthao added a comment. Change "Kernel Name" to "Function Name" and rebased patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123878/new/ https://reviews.llvm.org/D123878 Files: clang/test/Fron

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

vangthao added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:1222 + // printing multiple diagnostic location and diag opts. + EmitResourceUsageRemark("KernelName", "Kernel Name", + MF.getFunction().getName());

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

vangthao marked 5 inline comments as done. vangthao added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123878/new/ https://reviews.llvm.org/D123878 ___ cfe-commits mailing list cfe-commi

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

vangthao updated this revision to Diff 440447. vangthao added a comment. Remove "" delimiter. Change ScratchSize [bytes/thread] to ScratchSize [bytes/lane]. Use lambda expression to emit remarks. Do not output yaml if specific remark is not enabled. Add indentation to make it easier to t

[PATCH] D127923: [Diagnostics] Accept newline and format diag opts on first line

vangthao added a comment. In D127923#3599451 , @aaron.ballman wrote: > Is there a reason the remarks can't use individual diagnostic emissions to > simulate newlines? Or is this perhaps a demonstration that the remarks should > not be using the diagnos

[PATCH] D127923: [Diagnostics] Accept newline and format diag opts on first line

vangthao updated this revision to Diff 437593. vangthao added a comment. Update commit message to include the motivation behind the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127923/new/ https://reviews.llvm.org/D127923 Files: clang/li

[PATCH] D127923: [Diagnostics] Accept newline and format diag opts on first line

vangthao created this revision. Herald added a subscriber: martong. Herald added a project: All. vangthao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Accept newlines when the diagnostic string is being given by an outside source instead

[PATCH] D126908: [VerifyDiagnosticConsumer] Fix last line being discarded when parsing newline

vangthao added a comment. Ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126908/new/ https://reviews.llvm.org/D126908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D126908: [VerifyDiagnosticConsumer] Fix last line being discarded when parsing newline

vangthao created this revision. Herald added a project: All. vangthao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In expected diagnostic checks containing newlines, anything after the last newline would be discarded since we stop parsin

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

vangthao added a comment. I am not sure if allowing clang to accept newlines is a good idea. It seems like clang wants to know what type of message is being outputted. For example whether this is a remark, warning, etc. but allowing for a diagnostic to output their own newline makes it ambiguou

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

vangthao added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:1178-1266 + +void AMDGPUAsmPrinter::emitResourceUsageRemarks( +const MachineFunction &MF, const SIProgramInfo &CurrentProgramInfo, +bool isModuleEntryFunction, bool hasMAIInsts) { + i

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

vangthao added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:596 + MF.getFunction().getSubprogram(), &MF.front()) + << "--"; + }); scott.linder wrote: > This seems like the wrong plac

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

vangthao updated this revision to Diff 424344. vangthao added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Move remarks into its own function. Skip if !ORE. Add clang frontend test. Remove LDSSpillSize. Repository: rG LLVM Github Monorepo CHANGES SINCE LA