[clang] [analyzer] Do not destruct fields of unions (PR #122330)

2025-02-06 Thread Valentin Churavy via cfe-commits
https://github.com/vchuravy closed https://github.com/llvm/llvm-project/pull/122330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] target ABI: improve call parameters extensions handling (PR #100757)

2024-08-27 Thread Valentin Churavy via cfe-commits
vchuravy wrote: The JIT tests should be fixed so that they reflect what a front-end developer should actually emit as LLVM IR. https://github.com/llvm/llvm-project/pull/100757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

2016-09-20 Thread Valentin Churavy via cfe-commits
vchuravy added a comment. @jpienaar Since I don't have commit access, I think somebody else needs to commit this. https://reviews.llvm.org/D9168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

2016-09-20 Thread Valentin Churavy via cfe-commits
vchuravy updated this revision to Diff 71951. vchuravy added a comment. Fix spelling in comment https://reviews.llvm.org/D9168 Files: lib/Target/NVPTX/NVPTXISelLowering.cpp lib/Target/NVPTX/NVPTXISelLowering.h test/CodeGen/NVPTX/zero-cs.ll Index: test/CodeGen/NVPTX/zero-cs.ll ===

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

2016-09-20 Thread Valentin Churavy via cfe-commits
vchuravy updated this revision to Diff 71946. vchuravy added a comment. addresses review comments. https://reviews.llvm.org/D9168 Files: lib/Target/NVPTX/NVPTXISelLowering.cpp lib/Target/NVPTX/NVPTXISelLowering.h test/CodeGen/NVPTX/zero-cs.ll Index: test/CodeGen/NVPTX/zero-cs.ll

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

2016-09-20 Thread Valentin Churavy via cfe-commits
vchuravy added a comment. > You don't own revision D9168: "[NVPTX] Check if callsite is defined when > computing argument allignment". Normally, you should only update > revisions you own. You can "Commandeer" this revision from the web > interface if you want to become the owner. I w

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

2016-09-20 Thread Valentin Churavy via cfe-commits
vchuravy updated this revision to Diff 71936. vchuravy added a comment. Rebases the original changes and adds a test-case https://reviews.llvm.org/D9168 Files: lib/Target/NVPTX/NVPTXISelLowering.cpp lib/Target/NVPTX/NVPTXISelLowering.h test/CodeGen/NVPTX/zero-cs.ll Index: test/CodeGen/NV

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

2016-09-20 Thread Valentin Churavy via cfe-commits
vchuravy added a comment. This is my first contribution to llvm so please let me know if I did something wrong in the process https://reviews.llvm.org/D9168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

2016-09-19 Thread Valentin Churavy via cfe-commits
vchuravy added a comment. @jpienaar are you planning to work on this again? Or should I give it a go? https://reviews.llvm.org/D9168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

2016-09-19 Thread Valentin Churavy via cfe-commits
vchuravy added a comment. I have a potential test-case for this, but the patch doesn't apply cleanly to master so I was unable to test if this solves the problem. F2433038: strip.ll https://reviews.llvm.org/D9168 __