[PATCH] D146942: PowerPC ABI incompatibility with GNU on complex arguments

2023-03-27 Thread Umesh Kalappa via Phabricator via cfe-commits
umesh.kalappa0 created this revision. umesh.kalappa0 added a reviewer: nikic. umesh.kalappa0 added projects: LLVM, clang. Herald added subscribers: StephenFan, shchenz, nemanjai. Herald added a project: All. umesh.kalappa0 requested review of this revision. Herald added a subscriber: cfe-commits.

[PATCH] D142872: Honor the fwrapv option when generating the inbounds GEP .

2023-01-31 Thread Umesh Kalappa via Phabricator via cfe-commits
umesh.kalappa0 added a comment. @nikic ,is that changes are ok ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142872/new/ https://reviews.llvm.org/D142872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D142872: Honor the fwrapv option when generating the inbounds GEP .

2023-01-31 Thread Umesh Kalappa via Phabricator via cfe-commits
umesh.kalappa0 updated this revision to Diff 493623. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142872/new/ https://reviews.llvm.org/D142872 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGen/inbounds.c llvm/include/llvm/IR/ConstantFold.h llvm/lib/IR/ConstantFold.cpp Ind

[PATCH] D142872: Honor the fwrapv option when generating the inbounds GEP .

2023-01-31 Thread Umesh Kalappa via Phabricator via cfe-commits
umesh.kalappa0 added a comment. In D142872#4093093 , @nikic wrote: > @umesh.kalappa0 This issue should be fixed by > https://github.com/llvm/llvm-project/commit/5f01a626dd0615df49773d419c75aeb33666ee83. > Can you please give it another try? Thank you @

[PATCH] D142872: Honor the fwrapv option when generating the inbounds GEP .

2023-01-31 Thread Umesh Kalappa via Phabricator via cfe-commits
umesh.kalappa0 updated this revision to Diff 493612. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142872/new/ https://reviews.llvm.org/D142872 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGen/inbounds.c llvm/include/llvm/IR/ConstantFold.h llvm/lib/IR/ConstantFold.cpp Ind

[PATCH] D142872: Honor the fwrapv option when generating the inbounds GEP .

2023-01-30 Thread Umesh Kalappa via Phabricator via cfe-commits
umesh.kalappa0 added a comment. In D142872#4090304 , @nikic wrote: > CreateConstArrayGEP currently always creates an inbounds GEP. You need to > modify it make inbounds optional or use a different method, not suppress it > in the constant folding infras

[PATCH] D142872: Honor the fwrapv option when generating the inbounds GEP .

2023-01-30 Thread Umesh Kalappa via Phabricator via cfe-commits
umesh.kalappa0 added a comment. In D142872#4090317 , @nikic wrote: > You also shouldn't need to introduce any new handling for the fwrapv option. > I'm not sure how exactly it is currently threaded through, but there must be > existing handling for it a

[PATCH] D142872: Honor the fwrapv option when generating the inbounds GEP .

2023-01-30 Thread Umesh Kalappa via Phabricator via cfe-commits
umesh.kalappa0 updated this revision to Diff 493282. umesh.kalappa0 edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142872/new/ https://reviews.llvm.org/D142872 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGen/inbounds.c llvm/include/llvm/IR

[PATCH] D142872: Honor the fwrapv option when generating the inbounds GEP .

2023-01-30 Thread Umesh Kalappa via Phabricator via cfe-commits
umesh.kalappa0 created this revision. umesh.kalappa0 added a reviewer: nikic. umesh.kalappa0 added a project: LLVM. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. umesh.kalappa0 requested review of this revision. Herald added a project: clang. Herald added subscribers

[PATCH] D108421: Mark openmp internal global dso_local

2021-09-02 Thread Umesh Kalappa via Phabricator via cfe-commits
umesh.kalappa0 added a comment. In D108421#2977216 , @MaskRay wrote: > In D108421#2977107 , @kamleshbhalui > wrote: > >> In D108421#2958848 , @MaskRay >> wrote: >> >>> I

[PATCH] D103131: support debug info for alias variable

2021-05-26 Thread Umesh Kalappa via Phabricator via cfe-commits
umesh.kalappa0 added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4949 +void CGDebugInfo::EmitGlobalAlias(llvm::GlobalAlias *Var, const VarDecl *D) { + if (!CGM.getCodeGenOpts().hasReducedDebugInfo()) +return; check is redundant ,no require

[PATCH] D103131: support debug info for alias variable

2021-05-25 Thread Umesh Kalappa via Phabricator via cfe-commits
umesh.kalappa0 added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4948 +void CGDebugInfo::EmitGlobalAlias(llvm::GlobalAlias *Var, const VarDecl *D) { + if (!CGM.getCodeGenOpts().hasReducedDebugInfo()) Var is never used in the EmitGlobalAlias

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

2019-11-30 Thread Umesh Kalappa via Phabricator via cfe-commits
umesh.kalappa0 added a comment. @SouraVX and @yonghong-song cat extern.c int global_var = 2; compile as an extern.c shared a library ,then final executable a.out doesn't have debugInfo for global_var. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or