[clang] [clang-format] Break after string literals with trailing line breaks (PR #76795)

s1Sharp wrote: It seems your changes remain compatible with the old clang-format behavior. Сode looks quite correct https://github.com/llvm/llvm-project/pull/76795 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [clang-format] unexpected break after binOp '<<' (PR #69859)

s1Sharp wrote: > @s1Sharp are there any conclusions here? our code also incidentally relied on > having new lines between string literals, mostly for the sake of having a > line break after string literals that end with `\n`. > > what do people think about restoring the functionality to break

[clang] [clang-format] unexpected break after binOp '<<' (PR #69859)

s1Sharp wrote: yes, issue with breaking after << is gone. I want to get your point about functionality clang-format and implementing new option such as "BreakAfterStreamOperator". As i can see, @HazardyKnusperkeks you agree with "owenca" point? May be i can do something with this feature htt

[clang] [clang-format] unexpected break after binOp '<<' (PR #69859)

https://github.com/s1Sharp edited https://github.com/llvm/llvm-project/pull/69859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't break between string literal operands of << (PR #69871)

s1Sharp wrote: I think adding the possibility of breaking '<<' is a good idea if it's optional, what do u think? https://github.com/llvm/llvm-project/pull/69871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] [clang-format] unexpected break after binOp '<<' (PR #69859)

https://github.com/s1Sharp updated https://github.com/llvm/llvm-project/pull/69859 >From 5bbff07c636c2fc8b0432e5ca615d4cd7fd0c2b1 Mon Sep 17 00:00:00 2001 From: Tsarkov Maksim Date: Sun, 22 Oct 2023 02:09:21 +0300 Subject: [PATCH] [clang-format] unexpected break after binOp '<<' the problem oc

[clang] [clang-format] Don't break between string literal operands of << (PR #69871)

s1Sharp wrote: this is good to be respectful. Please, lets check my mr https://github.com/llvm/llvm-project/pull/69859 also https://github.com/llvm/llvm-project/pull/69871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] [clang-format] unexpected break after binOp '<<' (PR #69859)

https://github.com/s1Sharp updated https://github.com/llvm/llvm-project/pull/69859 >From a5c62614113b4c42e9051905bb6165331192ded0 Mon Sep 17 00:00:00 2001 From: Tsarkov Maksim Date: Sun, 22 Oct 2023 02:09:21 +0300 Subject: [PATCH] [clang-format] unexpected break after binOp '<<' the problem oc

[clang] [clang-format] unexpected break after binOp '<<' (PR #69859)

https://github.com/s1Sharp reopened https://github.com/llvm/llvm-project/pull/69859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] unexpected break after binOp '<<' (PR #69859)

s1Sharp wrote: I have no way to link the issues related to the PR issue. I don't know why, but add a link to issue to this comment https://github.com/llvm/llvm-project/issues/44363 . So, I want to start a little discussion about the solution. I'll start with the problem - when using the BreakB

[clang] [clang-format] unexpected break after binOp '<<' (PR #69859)

https://github.com/s1Sharp created https://github.com/llvm/llvm-project/pull/69859 the problem occurred while checking for the correctness of the break after binary operators. The output statement 'tok::lessless' is then break line every possible time, which is not expected with the BreakBefor