@@ -835,16 +835,22 @@ class LLVM_LIBRARY_VISIBILITY UEFIX86_64TargetInfo
public:
UEFIX86_64TargetInfo(const llvm::Triple &Triple, const TargetOptions &Opts)
: UEFITargetInfo(Triple, Opts) {
+LongWidth = LongAlign = 32;
+DoubleAlign = LongLongAlign = 64;
+Int
RossComputerGuy wrote:
Alright, if it does fix it then we should get this moving so libc pre-commits
working with UEFI isn't blocked.
https://github.com/llvm/llvm-project/pull/127290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://list
RossComputerGuy wrote:
Would this unblock #131376?
https://github.com/llvm/llvm-project/pull/127290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/RossComputerGuy updated
https://github.com/llvm/llvm-project/pull/120632
>From e0d525f801f65588aa6b22a2827036a4c2d9c91c Mon Sep 17 00:00:00 2001
From: Tristan Ross
Date: Thu, 19 Dec 2024 10:54:58 -0800
Subject: [PATCH 1/4] [clang] fix uefi data layout on x86 & aarch64
---
c
https://github.com/RossComputerGuy updated
https://github.com/llvm/llvm-project/pull/129084
>From 8fed3873f228232081533b614ac534473f6aa996 Mon Sep 17 00:00:00 2001
From: Tristan Ross
Date: Thu, 27 Feb 2025 09:10:22 -0800
Subject: [PATCH] [libunwind] Add unw_strerror function
Co-authored-by: Ra
https://github.com/RossComputerGuy updated
https://github.com/llvm/llvm-project/pull/129084
>From b976a982b6ea9963bd88744b8ca1314852948a60 Mon Sep 17 00:00:00 2001
From: Tristan Ross
Date: Thu, 27 Feb 2025 09:10:22 -0800
Subject: [PATCH] [libunwind] Add unw_strerror function
Co-authored-by: Ra
https://github.com/RossComputerGuy updated
https://github.com/llvm/llvm-project/pull/129084
>From 144809d95fab64843761629b384f9d41c1887cf3 Mon Sep 17 00:00:00 2001
From: Tristan Ross
Date: Thu, 27 Feb 2025 09:10:22 -0800
Subject: [PATCH] [libunwind] Add unw_strerror function
Co-authored-by: Ra
https://github.com/RossComputerGuy updated
https://github.com/llvm/llvm-project/pull/129084
>From 9357008872e3b12b3601a45d4fd5453dfa779ff3 Mon Sep 17 00:00:00 2001
From: Tristan Ross
Date: Thu, 27 Feb 2025 09:10:22 -0800
Subject: [PATCH] [libunwind] Add unw_strerror function
Co-authored-by: Ra
https://github.com/RossComputerGuy created
https://github.com/llvm/llvm-project/pull/129084
Original implementation comes from
https://github.com/reckenrode/nixpkgs/commit/099adeef42048d853df03f181103c6985c356d21
with permission from @reckenrode
This implements the `unw_strerror` function whi
https://github.com/RossComputerGuy approved this pull request.
https://github.com/llvm/llvm-project/pull/126352
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -713,8 +713,8 @@ class LLVM_LIBRARY_VISIBILITY X86_64TargetInfo : public
X86TargetInfo {
X86_64TargetInfo(const llvm::Triple &Triple, const TargetOptions &Opts)
: X86TargetInfo(Triple, Opts) {
const bool IsX32 = getTriple().isX32();
-bool IsWinCOFF =
-
RossComputerGuy wrote:
> @RossComputerGuy FYI
Already have seen this, I'm not sure I understand what the flag does exactly.
I've got LLVM libc PR subscriptions so I'll see any future PR's.
https://github.com/llvm/llvm-project/pull/121875
___
cfe-comm
https://github.com/RossComputerGuy updated
https://github.com/llvm/llvm-project/pull/120632
>From 1a76395c0dbe55146d1dd1ff943909f34c19a90a Mon Sep 17 00:00:00 2001
From: Tristan Ross
Date: Thu, 19 Dec 2024 10:54:58 -0800
Subject: [PATCH 1/5] [clang] fix uefi data layout on x86 & aarch64
---
c
@@ -820,43 +820,6 @@ class LLVM_LIBRARY_VISIBILITY X86_64TargetInfo : public
X86TargetInfo {
}
};
-// x86-64 UEFI target
-class LLVM_LIBRARY_VISIBILITY UEFIX86_64TargetInfo
-: public UEFITargetInfo {
-public:
- UEFIX86_64TargetInfo(const llvm::Triple &Triple, const Tar
RossComputerGuy wrote:
> That said, I tend to agree with the review at [#121123
> (comment)](https://github.com/llvm/llvm-project/pull/121123#discussion_r1900548165)
> that this doesn't seem like the right approach.
Yeah I agree too, I'm not sure what the right approach is but that's one of th
RossComputerGuy wrote:
Why close? LLVM libc is maturing and one of the goals I had was to try using it
in Nixpkgs to build whatever I can. LLVM libc doesn't work well in an overlay
mode so we have to use full builds. It's true that a lot of functions are still
missing or not implemented but by
@@ -1531,7 +1531,7 @@ Compilation *Driver::BuildCompilation(ArrayRef ArgList) {
// Check if the environment version is valid except wasm case.
llvm::Triple Triple = TC.getTriple();
- if (!Triple.isWasm()) {
+ if (!Triple.isWasm() && Triple.getEnvironment() != llvm::Tripl
https://github.com/RossComputerGuy updated
https://github.com/llvm/llvm-project/pull/121123
>From f5ef9c9fc9aac6058f5dd070f9e24932b4e4cf9a Mon Sep 17 00:00:00 2001
From: Tristan Ross
Date: Wed, 25 Dec 2024 14:38:30 -0800
Subject: [PATCH] [clang] add llvm abi support
---
clang/lib/Driver/Drive
https://github.com/RossComputerGuy updated
https://github.com/llvm/llvm-project/pull/121123
>From 23922b886739b2e298e4288dd53d6f59e8e2e86e Mon Sep 17 00:00:00 2001
From: Tristan Ross
Date: Wed, 25 Dec 2024 14:38:30 -0800
Subject: [PATCH] [clang] add llvm abi support
---
clang/lib/Driver/Drive
https://github.com/RossComputerGuy created
https://github.com/llvm/llvm-project/pull/121123
This PR makes it possible to use the LLVM ABI which uses LLVM libc.
>From 058c4d297822cbde97641eb9c35d78d5742b96f2 Mon Sep 17 00:00:00 2001
From: Tristan Ross
Date: Wed, 25 Dec 2024 14:38:30 -0800
Subje
RossComputerGuy wrote:
We have a problem where everything related to `i128` / `long double` fail to
compile in LLVM libc without compiler-rt on aarch64 and possibly x86_64, this
is a problem. Related ABI info:
-
[aarch64](https://github.com/ARM-software/abi-aa/releases/download/2024Q3/aapcs64.
RossComputerGuy wrote:
This has been rebased now, conflicts are gone.
https://github.com/llvm/llvm-project/pull/120632
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/RossComputerGuy updated
https://github.com/llvm/llvm-project/pull/120632
>From 1a76395c0dbe55146d1dd1ff943909f34c19a90a Mon Sep 17 00:00:00 2001
From: Tristan Ross
Date: Thu, 19 Dec 2024 10:54:58 -0800
Subject: [PATCH 1/4] [clang] fix uefi data layout on x86 & aarch64
---
c
RossComputerGuy wrote:
Will rebase tonight since #111719 was just merged. If we can get this merged
soon then I can try more testing.
https://github.com/llvm/llvm-project/pull/120632
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://list
https://github.com/RossComputerGuy updated
https://github.com/llvm/llvm-project/pull/120632
>From a9b162f2dbf8e2e102bc8f4cf7af51331e648502 Mon Sep 17 00:00:00 2001
From: Tristan Ross
Date: Thu, 19 Dec 2024 10:54:58 -0800
Subject: [PATCH 1/5] [clang] fix uefi data layout on x86 & aarch64
---
c
@@ -788,16 +789,28 @@ class LLVM_LIBRARY_VISIBILITY ZOSTargetInfo : public
OSTargetInfo {
// UEFI target
template
class LLVM_LIBRARY_VISIBILITY UEFITargetInfo : public OSTargetInfo {
+ llvm::Triple Triple;
+
protected:
void getOSDefines(const LangOptions &Opts, const llv
@@ -788,16 +789,28 @@ class LLVM_LIBRARY_VISIBILITY ZOSTargetInfo : public
OSTargetInfo {
// UEFI target
template
class LLVM_LIBRARY_VISIBILITY UEFITargetInfo : public OSTargetInfo {
+ llvm::Triple Triple;
+
protected:
void getOSDefines(const LangOptions &Opts, const llv
https://github.com/RossComputerGuy approved this pull request.
Looks good to me.
https://github.com/llvm/llvm-project/pull/111473
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
RossComputerGuy wrote:
Some of the clang changes seem kinda *odd*, maybe some of this work and #120632
could be conjoined? The LLVM stuff itself looks great, it's mainly the target
stuff in clang seems odd to me.
https://github.com/llvm/llvm-project/pull/109320
@@ -820,43 +820,6 @@ class LLVM_LIBRARY_VISIBILITY X86_64TargetInfo : public
X86TargetInfo {
}
};
-// x86-64 UEFI target
-class LLVM_LIBRARY_VISIBILITY UEFIX86_64TargetInfo
-: public UEFITargetInfo {
-public:
- UEFIX86_64TargetInfo(const llvm::Triple &Triple, const Tar
@@ -788,16 +789,28 @@ class LLVM_LIBRARY_VISIBILITY ZOSTargetInfo : public
OSTargetInfo {
// UEFI target
template
class LLVM_LIBRARY_VISIBILITY UEFITargetInfo : public OSTargetInfo {
+ llvm::Triple Triple;
protected:
void getOSDefines(const LangOptions &Opts, const llvm:
https://github.com/RossComputerGuy updated
https://github.com/llvm/llvm-project/pull/120632
>From 2ee88359c3be20f3b6697bf75466fa44e7b10ab5 Mon Sep 17 00:00:00 2001
From: Tristan Ross
Date: Thu, 19 Dec 2024 10:54:58 -0800
Subject: [PATCH 1/5] [clang] fix uefi data layout on x86 & aarch64
---
c
@@ -820,43 +820,6 @@ class LLVM_LIBRARY_VISIBILITY X86_64TargetInfo : public
X86TargetInfo {
}
};
-// x86-64 UEFI target
-class LLVM_LIBRARY_VISIBILITY UEFIX86_64TargetInfo
-: public UEFITargetInfo {
-public:
- UEFIX86_64TargetInfo(const llvm::Triple &Triple, const Tar
RossComputerGuy wrote:
Clang driver unit tests have been fixed.
https://github.com/llvm/llvm-project/pull/120632
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/RossComputerGuy updated
https://github.com/llvm/llvm-project/pull/120632
>From 2ee88359c3be20f3b6697bf75466fa44e7b10ab5 Mon Sep 17 00:00:00 2001
From: Tristan Ross
Date: Thu, 19 Dec 2024 10:54:58 -0800
Subject: [PATCH 1/5] [clang] fix uefi data layout on x86 & aarch64
---
c
RossComputerGuy wrote:
Tests have been adjusted, they should pass now.
https://github.com/llvm/llvm-project/pull/120632
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -820,43 +820,6 @@ class LLVM_LIBRARY_VISIBILITY X86_64TargetInfo : public
X86TargetInfo {
}
};
-// x86-64 UEFI target
-class LLVM_LIBRARY_VISIBILITY UEFIX86_64TargetInfo
-: public UEFITargetInfo {
-public:
- UEFIX86_64TargetInfo(const llvm::Triple &Triple, const Tar
@@ -820,43 +820,6 @@ class LLVM_LIBRARY_VISIBILITY X86_64TargetInfo : public
X86TargetInfo {
}
};
-// x86-64 UEFI target
-class LLVM_LIBRARY_VISIBILITY UEFIX86_64TargetInfo
-: public UEFITargetInfo {
-public:
- UEFIX86_64TargetInfo(const llvm::Triple &Triple, const Tar
@@ -165,6 +165,9 @@ std::unique_ptr AllocateTarget(const
llvm::Triple &Triple,
case llvm::Triple::OpenBSD:
return std::make_unique>(Triple,
Opts);
+case llvm::Triple::UEFI:
+ return std::m
https://github.com/RossComputerGuy updated
https://github.com/llvm/llvm-project/pull/120632
>From 2ee88359c3be20f3b6697bf75466fa44e7b10ab5 Mon Sep 17 00:00:00 2001
From: Tristan Ross
Date: Thu, 19 Dec 2024 10:54:58 -0800
Subject: [PATCH 1/5] [clang] fix uefi data layout on x86 & aarch64
---
c
@@ -165,6 +165,9 @@ std::unique_ptr AllocateTarget(const
llvm::Triple &Triple,
case llvm::Triple::OpenBSD:
return std::make_unique>(Triple,
Opts);
+case llvm::Triple::UEFI:
+ return std::m
https://github.com/RossComputerGuy updated
https://github.com/llvm/llvm-project/pull/120632
>From 2ee88359c3be20f3b6697bf75466fa44e7b10ab5 Mon Sep 17 00:00:00 2001
From: Tristan Ross
Date: Thu, 19 Dec 2024 10:54:58 -0800
Subject: [PATCH 1/5] [clang] fix uefi data layout on x86 & aarch64
---
c
@@ -165,6 +165,9 @@ std::unique_ptr AllocateTarget(const
llvm::Triple &Triple,
case llvm::Triple::OpenBSD:
return std::make_unique>(Triple,
Opts);
+case llvm::Triple::UEFI:
+ return std::m
https://github.com/RossComputerGuy updated
https://github.com/llvm/llvm-project/pull/120632
>From 2ee88359c3be20f3b6697bf75466fa44e7b10ab5 Mon Sep 17 00:00:00 2001
From: Tristan Ross
Date: Thu, 19 Dec 2024 10:54:58 -0800
Subject: [PATCH 1/5] [clang] fix uefi data layout on x86 & aarch64
---
c
https://github.com/RossComputerGuy updated
https://github.com/llvm/llvm-project/pull/120632
>From 2ee88359c3be20f3b6697bf75466fa44e7b10ab5 Mon Sep 17 00:00:00 2001
From: Tristan Ross
Date: Thu, 19 Dec 2024 10:54:58 -0800
Subject: [PATCH 1/4] [clang] fix uefi data layout on x86 & aarch64
---
c
@@ -790,7 +790,9 @@ template
class LLVM_LIBRARY_VISIBILITY UEFITargetInfo : public OSTargetInfo {
protected:
void getOSDefines(const LangOptions &Opts, const llvm::Triple &Triple,
-MacroBuilder &Builder) const override {}
+MacroBuilder
https://github.com/RossComputerGuy updated
https://github.com/llvm/llvm-project/pull/120632
>From 2ee88359c3be20f3b6697bf75466fa44e7b10ab5 Mon Sep 17 00:00:00 2001
From: Tristan Ross
Date: Thu, 19 Dec 2024 10:54:58 -0800
Subject: [PATCH 1/2] [clang] fix uefi data layout on x86 & aarch64
---
c
RossComputerGuy wrote:
> Should we have an entry for `-fdefine-target-os-macros` as well?
I think so, it wouldn't be a bad idea.
> Also needs a test
I might need some guidance on adding a test since I'm not fully familiar with
the clang side of LLVM.
https://github.com/llvm/llvm-project/pull
@@ -790,7 +790,9 @@ template
class LLVM_LIBRARY_VISIBILITY UEFITargetInfo : public OSTargetInfo {
protected:
void getOSDefines(const LangOptions &Opts, const llvm::Triple &Triple,
-MacroBuilder &Builder) const override {}
+MacroBuilder
@@ -790,7 +790,9 @@ template
class LLVM_LIBRARY_VISIBILITY UEFITargetInfo : public OSTargetInfo {
protected:
void getOSDefines(const LangOptions &Opts, const llvm::Triple &Triple,
-MacroBuilder &Builder) const override {}
+MacroBuilder
https://github.com/RossComputerGuy updated
https://github.com/llvm/llvm-project/pull/120632
>From 2ee88359c3be20f3b6697bf75466fa44e7b10ab5 Mon Sep 17 00:00:00 2001
From: Tristan Ross
Date: Thu, 19 Dec 2024 10:54:58 -0800
Subject: [PATCH 1/2] [clang] fix uefi data layout on x86 & aarch64
---
c
https://github.com/RossComputerGuy created
https://github.com/llvm/llvm-project/pull/120632
This PR introduces some fixes where the data layout wasn't propagated
correctly. To test this, feed clang any C file (I used an empty main for
testing) and pass `-target aarch64-uefi` or `-target x86_64
RossComputerGuy wrote:
Replaced by #109817
https://github.com/llvm/llvm-project/pull/109601
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/RossComputerGuy closed
https://github.com/llvm/llvm-project/pull/109601
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -31,6 +31,7 @@ set(LLVM_LINK_COMPONENTS
Target
TargetParser
TransformUtils
+ CodeGenTypes
RossComputerGuy wrote:
Removed.
https://github.com/llvm/llvm-project/pull/109601
___
cfe-commits mailing list
cfe-c
@@ -31,6 +31,7 @@ set(LLVM_LINK_COMPONENTS
Target
TargetParser
TransformUtils
+ LLVMCodeGenTypes
RossComputerGuy wrote:
Oh, didn't realize that.
https://github.com/llvm/llvm-project/pull/109601
___
cfe-commit
https://github.com/RossComputerGuy updated
https://github.com/llvm/llvm-project/pull/109601
>From 6902072452f92d8893b42dc7ef32fb610a579f8d Mon Sep 17 00:00:00 2001
From: Tristan Ross
Date: Sun, 22 Sep 2024 21:02:12 -0700
Subject: [PATCH] [Clang] Replace vt_gen with LLVMCodeGenTypes
---
clang/
RossComputerGuy wrote:
You're welcome, though it looks like CI is borked.
```
ld.lld: error: unable to find library -lLLVMLLVMCodeGenTypes
clang: error: linker command failed with exit code 1 (use -v to see invocation)
```
I've changed it from `LLVMCodeGenTypes` to `CodeGenTypes` so hopefully CI
https://github.com/RossComputerGuy updated
https://github.com/llvm/llvm-project/pull/109601
>From b97cb5af6dbf92edeeceedac38d0b657e3856fbe Mon Sep 17 00:00:00 2001
From: Tristan Ross
Date: Sun, 22 Sep 2024 21:02:12 -0700
Subject: [PATCH] [Clang] Replace vt_gen with LLVMCodeGenTypes
---
clang/
@@ -1,3 +1,7 @@
+if(EXISTS ${LLVM_MAIN_SRC_DIR}/include/llvm/CodeGen AND CLANG_BUILT_STANDALONE)
+ add_subdirectory(${LLVM_MAIN_SRC_DIR}/include/llvm/CodeGen llvm/lib/CodeGen)
+endif()
RossComputerGuy wrote:
Looks like CMake accepted that change, let's see if it
@@ -1,3 +1,7 @@
+if(EXISTS ${LLVM_MAIN_SRC_DIR}/include/llvm/CodeGen AND CLANG_BUILT_STANDALONE)
+ add_subdirectory(${LLVM_MAIN_SRC_DIR}/include/llvm/CodeGen llvm/lib/CodeGen)
+endif()
RossComputerGuy wrote:
Ok, so the solution is to set `-DLLVM_DIR` which is do
RossComputerGuy wrote:
> The `add_subdirectory` is definitely odd and I'm not sure if that is a proper
> solution.
I'm not familiar with how LLVM CodeGen works and I am a bit new to LLVM but I
looked at
[`clang/CMakeLists.txt`](https://github.com/llvm/llvm-project/blob/d61b2590f8e360695a52983
@@ -1,3 +1,7 @@
+if(EXISTS ${LLVM_MAIN_SRC_DIR}/include/llvm/CodeGen AND CLANG_BUILT_STANDALONE)
+ add_subdirectory(${LLVM_MAIN_SRC_DIR}/include/llvm/CodeGen llvm/lib/CodeGen)
+endif()
RossComputerGuy wrote:
I'm not exactly sure what you're meaning.
https://git
RossComputerGuy wrote:
> Yes, it should be built along with the core (but doesn't need to ship in the
> same package as the core).
Sounds good, I'll communicate with the other LLVM Nix maintainers and see if
this is a good idea to fully go ahead on.
https://github.com/llvm/llvm-project/pull/1
@@ -1,3 +1,7 @@
+if(EXISTS ${LLVM_MAIN_SRC_DIR}/include/llvm/CodeGen AND CLANG_BUILT_STANDALONE)
RossComputerGuy wrote:
Ok, will do.
https://github.com/llvm/llvm-project/pull/109601
___
cfe-commits mailing list
cfe-com
@@ -1,3 +1,7 @@
+if(EXISTS ${LLVM_MAIN_SRC_DIR}/include/llvm/CodeGen AND CLANG_BUILT_STANDALONE)
+ add_subdirectory(${LLVM_MAIN_SRC_DIR}/include/llvm/CodeGen llvm/lib/CodeGen)
+endif()
RossComputerGuy wrote:
I'm not sure, are you meaning to use `LLVM_DIR` instea
RossComputerGuy wrote:
> IMO libclc should not support the standalone build, and this should be
> version locked to the exact compiler commit.
So it should be built along with the core of LLVM? Also, we package LLVM per
version per subproject.
> could this be avoided by changing the Nixpkgs b
RossComputerGuy wrote:
> Apologies, but I'm having a bit of trouble understanding the scenario that
> this PR addresses.
Nixpkgs adds the tools being used to `$PATH` so find program needs to use path.
https://github.com/llvm/llvm-project/pull/105969
RossComputerGuy wrote:
> The nix build should probably migrate to using the non-standalone build
Nixpkgs has no intention of moving away from standalone builds.
https://github.com/llvm/llvm-project/pull/105969
___
cfe-commits mailing list
cfe-commits@
https://github.com/RossComputerGuy updated
https://github.com/llvm/llvm-project/pull/109601
>From cab2a5cebdc63425ed03a31028e6eb2aee00e5d9 Mon Sep 17 00:00:00 2001
From: Tristan Ross
Date: Sun, 22 Sep 2024 21:02:12 -0700
Subject: [PATCH] [Clang] Include LLVM CodeGen CMake file
---
clang/lib/C
https://github.com/RossComputerGuy created
https://github.com/llvm/llvm-project/pull/109601
Fixes a build failure with Clang being built from standalone sources
(environments like Nix).
Exact error:
```
CMake Error at
/nix/store/h9yw8mg03z3dz6rgcjr7gbzkjysqc2sj-llvm-20.0.0-unstable-2024-09-22
https://github.com/RossComputerGuy updated
https://github.com/llvm/llvm-project/pull/105969
>From 056e0f9b7c7b788ad0d85a1479000fd1af4f98ce Mon Sep 17 00:00:00 2001
From: Tristan Ross
Date: Sat, 24 Aug 2024 19:56:24 -0700
Subject: [PATCH] [libclc] use default paths with find_program when possibl
https://github.com/RossComputerGuy created
https://github.com/llvm/llvm-project/pull/105969
Patch pulled from https://github.com/NixOS/nixpkgs/pull/336465
This PR removes `NO_DEFAULT_PATH` where possible, the flag prevents Nix from
building libclc correctly.
>From e8b910246d0c7c3d9fff994f71c6
73 matches
Mail list logo
