[PATCH] D125373: [pp-trace] Print HashLoc in InclusionDirective callback

This revision was automatically updated to reflect the committed changes. Closed by commit rG8df2b1a86680: [pp-trace] Print HashLoc in InclusionDirective callback (authored by oToToT). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125373/new/ https:

[PATCH] D125373: [pp-trace] Print HashLoc in InclusionDirective callback

oToToT added a comment. Thanks for reviewing! I will commit it myself later. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125373/new/ https://reviews.llvm.org/D125373 ___ cfe-commits mailing list cfe

[PATCH] D125373: [pp-trace] Print HashLoc in InclusionDirective callback

oToToT updated this revision to Diff 433722. oToToT added a comment. Added a release note for the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125373/new/ https://reviews.llvm.org/D125373 Files: clang-tools-extra/docs/ReleaseNotes.rst

[PATCH] D125373: [pp-trace] Print HashLoc in InclusionDirective callback

oToToT added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125373/new/ https://reviews.llvm.org/D125373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D125373: [pp-trace] Print HashLoc in InclusionDirective callback

oToToT created this revision. oToToT added reviewers: jtsoftware, klimek. Herald added subscribers: kbarton, nemanjai. Herald added a project: All. oToToT requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The HashLoc in InclusionD

[PATCH] D125258: [docs][pp-trace] Remove FileNotFound callback

This revision was automatically updated to reflect the committed changes. Closed by commit rGba7b6f46b37b: [docs][pp-trace] Remove FileNotFound callback (authored by oToToT). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125258/new/ https://reviews.

[PATCH] D125258: [docs][pp-trace] Remove FileNotFound callback

oToToT created this revision. oToToT added a reviewer: jansvoboda11. Herald added a project: All. oToToT requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. `FileNotFound` preprocessor callback is removed in D119708

[PATCH] D108756: [clang] Add '-ast-dump-filter=' support

oToToT added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108756/new/ https://reviews.llvm.org/D108756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D108756: [clang] Add '-ast-dump-filter=' support

oToToT created this revision. oToToT added reviewers: rsmith, alexfh. oToToT added a project: clang. Herald added a subscriber: dang. oToToT requested review of this revision. Herald added a subscriber: cfe-commits. Before this patch, we only support syntax like `clang -cc1 -ast-dump -ast-dump-fil

[PATCH] D100024: [clang] Check AuxTarget exists when creating target in CompilerInstance.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc1117df5b87: [clang] Check AuxTarget exists when creating target in CompilerInstance (authored by oToToT). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100

[PATCH] D100024: [clang] Check AuxTarget exists when creating target in CompilerInstance.

oToToT updated this revision to Diff 335778. oToToT added a comment. Simply use `!getAuxTarget()` to check the existence of AuxTarget. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100024/new/ https://reviews.llvm.org/D100024 Files: clang/lib/Fr

[PATCH] D100024: [clang] Check AuxTarget exists when creating target in CompilerInstance.

oToToT added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:109 + // other side of CUDA/OpenMP/SYCL compilation. + if (!hasAuxTarget() && + (getLangOpts().CUDA || getLangOpts().OpenMPIsDevice || kadircet wrote: > can we just do `!getA

[PATCH] D100024: [clang] Check AuxTarget exists when creating target in CompilerInstance.

oToToT created this revision. oToToT added reviewers: sammccall, kadircet. oToToT added a project: clang. oToToT requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. D97493 separate target creation

[PATCH] D98128: [clang][clangd] Avoid inconsistent target creation

This revision was automatically updated to reflect the committed changes. Closed by commit rG14a7296c0120: [clang][clangd] Avoid inconsistent target creation (authored by oToToT). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98128/new/ https://revi

[PATCH] D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478)

This revision was automatically updated to reflect the committed changes. Closed by commit rGa89fb29398dc: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (authored by oToToT). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99407/new

[PATCH] D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478)

oToToT updated this revision to Diff 334848. oToToT added a comment. Remove redundant trailing spaces. Sorry for not checking this at the first time I submit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99407/new/ https://reviews.llvm.org/D99407

[PATCH] D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478)

oToToT updated this revision to Diff 334840. oToToT added a comment. Updated tests to check mangled type name. However, I not sure whether it is proper to put the tests here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99407/new/ https://reviews

[PATCH] D98128: [clang][clangd] Avoid inconsistent target creation

oToToT added a comment. ping. After some investigation, I think it is quite hard to add tests to avoid inconsistency between clang and clangd. Maybe I could add some tests for CUDA, OpenMP if needed. WDYT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478)

oToToT added inline comments. Comment at: clang/test/AST/ast-dump-array-json.cpp:6 + +// CHECK: "mangledName": "_ZN1A4TestE", +// CHECK: "mangledName": "_ZN1A4TestE", rsmith wrote: > oToToT wrote: > > yaxunl wrote: > > > I am not sure if this test tests the code

[PATCH] D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478)

oToToT added inline comments. Comment at: clang/test/AST/ast-dump-array-json.cpp:6 + +// CHECK: "mangledName": "_ZN1A4TestE", +// CHECK: "mangledName": "_ZN1A4TestE", yaxunl wrote: > I am not sure if this test tests the code you change since the mangled > variab

[PATCH] D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478)

oToToT updated this revision to Diff 333526. oToToT added a comment. Remove redundant whitespace in comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99407/new/ https://reviews.llvm.org/D99407 Files: clang/lib/AST/ItaniumMangle.cpp clang/

[PATCH] D99407: [clang][ItaniumMangle] Check SizeExpr for DependentSizedArrayType (PR49478)

oToToT created this revision. oToToT added reviewers: rsmith, gbenyei, MaskRay, yaxunl. oToToT added a project: clang. oToToT requested review of this revision. Herald added a subscriber: cfe-commits. As `ArrayType::ArrayType` mentioned in `clang/lib/AST/Type.cpp`, a DependentSizedArrayType might

[PATCH] D98128: [clang][clangd] Avoid inconsistent target creation

oToToT added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98128/new/ https://reviews.llvm.org/D98128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D80464: [CUDA] Missing __syncthreads intrinsic in __clang_cuda_device_functions.h

oToToT added a comment. I found this patch occasionally, I think D98128 is what you need to solve this problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80464/new/ https://reviews.llvm.org/D80464 ___

[PATCH] D98128: [clang][clangd] Avoid inconsistent target creation

oToToT added a comment. Kindly ping. Maybe I should add a test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98128/new/ https://reviews.llvm.org/D98128 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D98128: [clang][clangd] Avoid inconsistent target creation

oToToT updated this revision to Diff 328814. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98128/new/ https://reviews.llvm.org/D98128 Files: clang-tools-extra/clangd/Compiler.cpp clang/lib/Frontend/ASTUnit.cpp clang/lib/Frontend/PrecompiledPre

[PATCH] D98128: [clang][clangd] Avoid inconsistent target creation

oToToT created this revision. oToToT added reviewers: sammccall, rsmith, ilya-biryukov. oToToT added projects: clang, clang-tools-extra. Herald added subscribers: usaxena95, kadircet, arphaman. oToToT requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Heral

[PATCH] D97561: [clang] Use CompilerInstance::createTarget to createTarget

oToToT abandoned this revision. oToToT added a comment. Since, originally, I think it is OK to submit patch just by project, but I agree that it's better to make patch as minimal as possible. Thus, I will abandon this and resubmit another patch. (I think reuploading patch and changing the whole p

[PATCH] D97561: [clang] Use CompilerInstance::createTarget to createTarget

oToToT added a comment. Kindly ping. Since the part I modified is quite... old (about 4 to 7 years ago?), I hope I've found the right person to review for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97561/new/ https://reviews.llvm.org/D97

[PATCH] D97561: [clang] Use CompilerInstance::createTarget to createTarget

oToToT added inline comments. Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:368 // Create the target instance. - Clang->setTarget(TargetInfo::CreateTargetInfo( - Clang->getDiagnostics(), Clang->getInvocation().TargetOpts)); - if (!Clang->hasTarget()) + if (!Cl

[PATCH] D97561: [clang] Use CompilerInstance::createTarget to createTarget

oToToT created this revision. oToToT added reviewers: sammccall, rsmith, klimek, dexonsmith. oToToT added a project: clang. oToToT requested review of this revision. Herald added a subscriber: cfe-commits. As proposed in D97109 , I tried to replace all similar tar

[PATCH] D97493: [clang][NFC] Extract Target and AuxTarget creation in CompilerInstance to new function

oToToT added a comment. Since I don't have commit access currently, might @sammccall commit this for me with `--author="Yu-Hsun Chiang "`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97493/new/ https://reviews.llvm.org/D97493 __

[PATCH] D97493: [clang][NFC] Extract Target and AuxTarget creation in CompilerInstance to new function

oToToT updated this revision to Diff 326581. oToToT added a comment. Fix typo and rename function to `createTarget`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97493/new/ https://reviews.llvm.org/D97493 Files: clang/include/clang/Frontend/Com

[PATCH] D97493: [clang][NFC] Extract Target and AuxTarget creation in CompilerInstance to new function

oToToT created this revision. oToToT added reviewers: sammccall, rsmith. oToToT added a project: clang. oToToT requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. As @sammccall mentioned in D97109

[PATCH] D97109: [clangd] Add support for auxiliary triple specification

oToToT abandoned this revision. oToToT added a comment. Thanks sammccall for reviewing this and for the great idea of the whole plan. I will work on the plan (maybe without the third one) to fix the problem described here. Sorry for a poor submission here again. Repository: rG LLVM Github M

[PATCH] D97109: [clangd] Add support for auxiliary triple specification

oToToT added inline comments. Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:311 llvm::ErrorOr PrecompiledPreamble::Build( const CompilerInvocation &Invocation, Though this file is in clang, clangd use this function to prepare preamble in `Preamb

[PATCH] D97109: [clangd] Add support for auxiliary triple specification

oToToT updated this revision to Diff 325186. oToToT added a comment. re-upload diff with full context, sorry for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97109/new/ https://reviews.llvm.org/D97109 Files: clang-tools-extra/clangd/Compi

[PATCH] D97109: [clangd] Add support for auxiliary triple specification

oToToT created this revision. oToToT added reviewers: jdoerfert, sammccall, ilya-biryukov. oToToT added a project: clang-tools-extra. Herald added subscribers: usaxena95, kadircet, arphaman. oToToT requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald a

[PATCH] D96102: [clangd] Fix missing __syncthreads.

oToToT abandoned this revision. oToToT added a comment. OK, I've found what's wrong with my fix here. I should check for the clangd compile mechanism with more detail to fix this problem. Sorry for disturbance. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96102/new/ https://reviews.l

[PATCH] D96102: [clangd] Fix missing __syncthreads.

oToToT updated this revision to Diff 321652. oToToT added a comment. I guess __nvvm_bar_sync is the right instruction. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96102/new/ https://reviews.llvm.org/D96102 Files: clang/lib/Headers/__clang_cuda_device_functions.h Index: clang/lib/

[PATCH] D96102: [clangd] Fix missing __syncthreads.

oToToT created this revision. oToToT added reviewers: tra, chandlerc, jdoerfert, gtbercea, emankov, JDevlieghere. Herald added subscribers: usaxena95, kadircet, arphaman. oToToT requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project