[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

TWeaver added a comment. Good afternoon from the UK! It looks as though this change has caused the following buildbot to start failing: https://lab.llvm.org/buildbot/#/builders/216/builds/26407 are you able to take a look? Thanks in advance, Tom W Repository: rG LLVM Github Monorepo CHAN

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

TWeaver added a comment. In D153366#4471460 , @sammccall wrote: > In D153366#4471320 , @TWeaver wrote: > >> My apologies but I've had to revert this change for now until the author can >> address the buildbot fai

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

TWeaver added a comment. My apologies but I've had to revert this change for now until the author can address the buildbot failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153366/new/ https://reviews.llvm.org/D153366 __

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

TWeaver added a comment. Hello and good afternoon from the UK, I believe this change has introduced test failures on the following buildbot: https://lab.llvm.org/buildbot/#/builders/139/builds/44269 are you able to take a look see? Much appreciated, Tom W Repository: rG LLVM Github Monorep

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines= as a driver option

TWeaver added a comment. Thanks for the fix! 👍 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152090/new/ https://reviews.llvm.org/D152090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines= as a driver option

TWeaver added a comment. Hello and good afternoon from the UK, It looks as though this change has caused the following buildbot to start failing (it's temporarily on staging server so you may not have seen it on the public build bot page): https://lab.llvm.org/staging/#/builders/204/builds/214

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

TWeaver added a comment. Thanks for the speedy reply and action! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150902/new/ https://reviews.llvm.org/D150902 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

TWeaver added a comment. Good morning from the UK! I believe this change has caused the following buildbot to start failing: https://lab.llvm.org/buildbot/#/builders/139/builds/42214 Is anyone able to take a look? Much obliged, Tom W Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

TWeaver added a comment. The build bot failures have been going for a while now so I've had to revert this until the author can address them, my apologies. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149516/new/ https://reviews.llvm.org/D149516

[PATCH] D150817: Use windows baskslash on anonymous tag locations if using MSVCFormatting and it's not absolute path.

TWeaver added a comment. Hello and good afternoon from the UK, I believe this patch has caused failures on the following buildbot: https://lab.llvm.org/buildbot/#/builders/216/builds/21493 are you able to take a look? thanks, Tom W Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D148223: [SiFive][RISCV][clang] Support C intrinsics for xsfvcp extension.

TWeaver added a comment. In D148223#4312352 , @4vtomat wrote: > I'll take a look, thanks! Much obliged and thanks for the speedy reply! 👍 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148223/new/ https://

[PATCH] D148223: [SiFive][RISCV][clang] Support C intrinsics for xsfvcp extension.

TWeaver added a comment. Hello and Good Afternoon from the UK, I believe this revision has started the following build bot to start failing on these 5 tests: https://lab.llvm.org/buildbot/#/builders/216/builds/20627 xsfvcp-x-rv64.c xsfvcp-x.c xsfvcp-xv.c xsfvcp-xvv.c xsfvcp-xvw.c Is anyone ab

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

TWeaver added a comment. Good morning, I believe the two tests added in this patch, clang::ohos.c and clang::ohos.cpp are failing on the following buildbot: https://lab.llvm.org/buildbot/#/builders/216/builds/18323 is anyone able to take a look? thanks, Tom W Repository: rG LLVM Github Mo

[PATCH] D137527: [C++20] [Modules] [ClangScanDeps] Add ClangScanDeps support for C++20 Named Modules in P1689 format (2/4)

TWeaver added a comment. @thakis @ChuanqiXu I have a revision up for review here https://reviews.llvm.org/D143749 that adds back the UNSUPPORTED: system-windows that was reverted in https://reviews.llvm.org/D139168 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

TWeaver added a comment. @ChuanqiXu Hi there, the revert of this patch has caused the following buildbot to start failing: https://lab.llvm.org/buildbot/#/builders/192/builds/267 It looks as though the removal of the // REQUIRES: !system-windows has caused the test to start running, and theref

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

TWeaver added a comment. Hello all, sorry to be a bother, but I believe this patch has caused a failure in this buildbot (and potentially others). https://lab.llvm.org/buildbot/#/builders/109/builds/57277 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D136156: [Clang][Diagnostic] Add hidden-reinterpret-cast diagnostic warning

TWeaver abandoned this revision. TWeaver added a comment. Hi all, thanks for your time and effort reviewing this patch. I'm going to close this now due to the lack of interest in it's current form. thanks again and happy coding, Tom CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136156

[PATCH] D136156: [Clang][Diagnostic] Add hidden-reinterpret-cast diagnostic warning

TWeaver added a comment. Hello all, First of all, thank you so much for your reviews, comments and time. Secondly, I apologise for the late reply. I've be thinking about your statements and I have to somewhat agree. This doesn't catch undefined behaviour, at least by its self. It may help catc

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

TWeaver added a comment. Hello all, really sorry but I've had to revert this patch due to failures on windows build bots: http://lab.llvm.org:8011/#/builders/216 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114115/new/ https://reviews.llvm.org/

[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

TWeaver added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-vararg-ms.cpp:7 + +// RUN: %check_clang_tidy %s cppcoreguidelines-pro-type-vararg %t + njames93 wrote: > TWeaver wrote: > > Is the missing FileCheck

[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

TWeaver added a comment. whilst investigating an unrelated issue on our internal branch, I tried editting the check lines in this test and wasn't able to create a failure. but if I add '| FileCheck %s -check-prefix=CHECK-MESSAGES' to the run line and then edit the checks, I can induce an error

[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

TWeaver added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-vararg-ms.cpp:7 + +// RUN: %check_clang_tidy %s cppcoreguidelines-pro-type-vararg %t + Is the missing FileCheck call here on purpose? it seems to me

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

TWeaver added a comment. Hiya, this patch (probably) broke the build bot at: http://lab.llvm.org:8011/#/builders/53/builds/1184 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76802/new/ https://reviews.llvm.org/D76802

[PATCH] D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction

TWeaver added a comment. Hi there, just checking in, is this patch still going ahead? thanks Tom W Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66716/new/ https://reviews.llvm.org/D66716 ___ cfe-com

[PATCH] D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction

TWeaver added a comment. Hi there! thanks so much for this patch, can confirm that with this patch applied my local machine no longer crashes for the loop-widening.cpp test. LGTM for me, but this isn't really my area of expertise so I can't judge one whether these changes are the correct ones

[PATCH] D54036: [fix][clang-tidy] fix for r345961 that introduced a test failure on Windows builds

TWeaver added a comment. Oh, I don't have commit access, are you able to commit for me Sam? Thanks Repository: rL LLVM https://reviews.llvm.org/D54036 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D54036: [fix][clang-tidy] fix for r345961 that introduced a test failure on Windows builds

TWeaver added a comment. I'm happy as is. thanks for the review. Repository: rL LLVM https://reviews.llvm.org/D54036 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54036: [fix][clang-tidy] fix for r345961 that introduced a test failure on Windows builds

TWeaver added a comment. The test failed on the following build bot: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/21169 Repository: rL LLVM https://reviews.llvm.org/D54036 ___ cfe-commits mailing list

[PATCH] D54036: [fix][clang-tidy] fix for r345961 that introduced a test failure on Windows builds

TWeaver created this revision. TWeaver added a reviewer: sammccall. Herald added subscribers: llvm-commits, xazax.hun. r345961 introduced a path check in .\tools\clang\tools\extra\test\clang-tidy\clang-tidy-run-with-database.cpp. r345961 added a check line for a path that only handled / on unix