[PATCH] D123155: [analyzer] Expose Taint.h to plugins

tomrittervg added a comment. Please commit on my behalf; you can use "Tom Ritter " Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123155/new/ https://reviews.llvm.org/D123155 ___ cfe-commits mailing list

[PATCH] D123155: [analyzer] Expose Taint.h to plugins

tomrittervg added a comment. Just a note - I was able to test this finally and it works for what I was trying to do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123155/new/ https://reviews.llvm.org/D123155 __

[PATCH] D123155: [analyzer] Expose Taint.h to plugins

tomrittervg created this revision. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. tomrittervg requested review of this revision. Herald added a projec

[PATCH] D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior

tomrittervg updated this revision to Diff 318632. tomrittervg added a comment. Try rebasing it... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94624/new/ https://reviews.llvm.org/D94624 Files: clang-tools-extra/clang-query/Query.cpp clang-too

[PATCH] D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior

tomrittervg added a comment. In D94624#2506831 , @aaron.ballman wrote: > In D94624#2501894 , @tomrittervg > wrote: > >> I started trying to work on a patch, but I'm still unpacking from a move and >> don't have a

[PATCH] D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior

tomrittervg added a comment. I started trying to work on a patch, but I'm still unpacking from a move and don't have all my machines set up - trying to enable and build tests filled up my hard drive (even after I removed the easy-to-remove stuff), so I don't think I'm going to be able to create

[PATCH] D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior

tomrittervg updated this revision to Diff 317027. tomrittervg added a comment. Remove braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94624/new/ https://reviews.llvm.org/D94624 Files: clang-tools-extra/clang-query/Query.cpp clang-tools-ex

[PATCH] D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior

tomrittervg updated this revision to Diff 316753. tomrittervg retitled this revision from "[PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior" to "PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior". tomrittervg e

[PATCH] D94624: [PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior

tomrittervg added a comment. In D94624#2498244 , @aaron.ballman wrote: > In D94624#2498201 , @tomrittervg > wrote: > >> Actually, I think I need to be smarter than changing the default. We want to >> let clang au

[PATCH] D94624: [PATCH] [clang-query] Add a --use-color option to clang-query

tomrittervg updated this revision to Diff 316652. tomrittervg added a comment. Actually, I think I need to be smarter than changing the default. We want to let clang auto-detect the tty and behave that way by default if the option isn't specified. Otherwise you'd get ASNI color codes when you pi

[PATCH] D94624: [PATCH] [clang-query] Add a --use-color option to clang-query

tomrittervg added inline comments. Comment at: clang-tools-extra/clang-query/tool/ClangQuery.cpp:58 +standard output supports colors.)"), + cl::init(false), cl::cat(ClangQueryCategory)); + steveire wrote: > tomrittervg wrote: > > steveire wrote: > > >

[PATCH] D94624: [PATCH] [clang-query] Add a --use-color option to clang-query

tomrittervg added inline comments. Comment at: clang-tools-extra/clang-query/tool/ClangQuery.cpp:58 +standard output supports colors.)"), + cl::init(false), cl::cat(ClangQueryCategory)); + steveire wrote: > aaron.ballman wrote: > > steveire wrote: > >

[PATCH] D94624: [PATCH] [clang-query] Add a --use-color option to clang-query

tomrittervg created this revision. tomrittervg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. My first attempt was to figure out how to plumb the --use-color command line argument to the DiagnosticEngine that gets referenced in AST->getDia