[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

topisani added a comment. In D73453#1857095 , @kadircet wrote: > let me know if you need me to commit this. Yes please, thanks for your time! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73453/new/ https://reviews.llvm.org/D73453 _

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

topisani updated this revision to Diff 242334. topisani added a comment. Woops yeah, still getting used to using git like this CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73453/new/ https://reviews.llvm.org/D73453 Files: clang-tools-extra/clangd/QueryDriverDatabase.cpp clang-tool

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

topisani updated this revision to Diff 241914. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73453/new/ https://reviews.llvm.org/D73453 Files: clang-tools-extra/clangd/QueryDriverDatabase.cpp clang-tools-extra/clangd/test/system-include-extractor.test Index: clang-tools-extra/clangd

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

topisani updated this revision to Diff 240815. topisani marked an inline comment as done. topisani added a comment. Address CR Comments I couldn't think of a good way to check for `--sysroot /my/sysroot` in the test in posix shell, so i hope the grep usage is OK. CHANGES SINCE LAST ACTION ht

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

topisani updated this revision to Diff 240643. topisani marked an inline comment as done. topisani added a comment. Addressed CR comments I'm sure about the tests, I basically just added to the one test that already exists that it passes one of each "type" of preservable argument. CHANGES SINC

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

topisani created this revision. topisani added reviewers: kadircet, klimek. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, ilya-biryukov. Herald added a project: clang. Solves this issue: https://github.com/clangd/clangd/issues/157 This is my first contribution to an llvm p