gysit added a comment.
Herald added subscribers: bviyer, Moerafaat.
@omri123 are you interested in rebasing and landing this?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136746/new/
https://reviews.llvm.org/D136746
___
cfe-commits mailing l
gysit added inline comments.
Comment at: mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td:179
+def LLVM_SAddSat : LLVM_BinarySameArgsIntrOpI<"sadd.sat">;
+def LLVM_SAddSat : LLVM_BinarySameArgsIntrOpI<"uadd.sat">;
+def LLVM_SAddSat : LLVM_BinarySameArgsIntrOpI<"ssub.sat">;
--
gysit added a comment.
Looks good from my side modulo the nit comment. Let's wait for @ftynse (the
code owner) for the final approval.
Comment at: mlir/test/Target/LLVMIR/Import/intrinsic.ll:778
+declare i32 @llvm.usub.sat.i32(i32, i32)
+declare <8 x i32> @llvm.usub.sat.v8i32(
gysit added inline comments.
Comment at: mlir/include/mlir/Dialect/LLVMIR/LLVMIntrinsicOps.td:150-153
}
+// Saturation Arithmetic Intrinsics.
+
+def LLVM_SAddSat
nit: There are quite a lot of changes in the diff for things that seemingly did
not change (e.g. t
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb7f2c108eb87: [mlir][linalg] Replace LinalgOps.h and
LinalgTypes.h by a single header. (authored by gysit).
Changed prior to commit:
https://revie
gysit added a comment.
After removing the last Linalg Type in https://reviews.llvm.org/D115727, I
think it would make sense to merge the LinalgTypes.h and LinalgOp.h headers.
However, this causes quite of header fixes in downstream projects. We can also
abandon this revision if preferred.
Rep
gysit created this revision.
Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan,
armkevincheng, jsmolens, eric-k256, dcaballe, cota, mravishankar, teijeong,
rdzhabarov, tatianashp, ThomasRaoux, AlexeySotkin, msifontes, jurahul, Kayjukh,
grosul1, Joonsoo, liufengdb, aartbik, luc
