This revision was automatically updated to reflect the committed changes.
Closed by commit rL335284: [LTO] Enable module summary emission by default for
regular LTO (authored by tobiasvk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/
tobiasvk added a comment.
@pcc, @tejohnson: Are you OK with this going in now that
https://reviews.llvm.org/D47898 has merged?
https://reviews.llvm.org/D34156
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
tobiasvk updated this revision to Diff 150965.
tobiasvk added a comment.
- Rebase for current tree
- Fix -flto -save-temps which the previous patch broke
https://reviews.llvm.org/D34156
Files:
clang/include/clang/Frontend/CodeGenOptions.def
clang/lib/CodeGen/BackendUtil.cpp
clang/lib/Code
tobiasvk added a comment.
In https://reviews.llvm.org/D34156#1125489, @vlad.tsyrklevich wrote:
> Hi Tobias, I tracked down the failure self-hosting LLVM with LTO with this
> revision to https://bugs.llvm.org/show_bug.cgi?id=37684#c2 and have a fix
> under review in https://reviews.llvm.org/D478
tobiasvk added a comment.
In https://reviews.llvm.org/D34156#781415, @pcc wrote:
> Please confirm that we can still self host with full LTO now that
> https://reviews.llvm.org/D33922 has landed.
Good point. And the answer seems to be no :/
ld.lld: .../llvm/lib/Linker/IRMover.cpp:242: llvm::
tobiasvk added a comment.
In https://reviews.llvm.org/D34156#780714, @mehdi_amini wrote:
> In https://reviews.llvm.org/D34156#780570, @tobiasvk wrote:
>
> > - Change patch to always emit a module summary for regular LTO
> >
> > I don't see any real downside of having a summary given the margina
tobiasvk updated this revision to Diff 102585.
tobiasvk added a comment.
- Change patch to always emit a module summary for regular LTO
I don't see any real downside of having a summary given the marginal time and
space overhead it takes to construct and save it.
https://reviews.llvm.org/D34156
tobiasvk added a comment.
In https://reviews.llvm.org/D34156#779270, @pcc wrote:
> Have you considered writing the regular LTO summaries unconditionally if
> `-flto` was specified? That was how I imagined that the interface would look.
Absolutely, if people are OK with that. I would have enabl
tobiasvk created this revision.
Herald added subscribers: eraman, inglorion.
With https://reviews.llvm.org/D33921, we gained the ability to have module
summaries in regular
LTO modules without triggering ThinLTO compilation. There is however,
currently, no way to trigger the emission of a module
