[clang] [clang][docs] Fix typos concerning wasm __funcref (PR #124365)

anematode wrote: Pardon? (Last time I made a PR my commit was merged directly, but I don't mind if you commit a trivial one like this) https://github.com/llvm/llvm-project/pull/124365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang] [llvm] [clang][docs] Fix typos concerning wasm __funcref (PR #124365)

@@ -1211,6 +1211,15 @@ WebAssemblyTargetLowering::LowerCall(CallLoweringInfo &CLI, } } } + +// If outgoing arguments are passed via the stack, we cannot tail call +for (const ISD::OutputArg &Out : CLI.Outs) { anematode wrote: Whoops!

[clang] [clang][docs] Fix typos concerning wasm __funcref (PR #124365)

https://github.com/anematode updated https://github.com/llvm/llvm-project/pull/124365 >From 2508da6fd7f38101011573460724f13df1c1616d Mon Sep 17 00:00:00 2001 From: Timothy Herchen Date: Fri, 24 Jan 2025 15:13:30 -0800 Subject: [PATCH] [clang][docs] Fix typos concerning wasm __funcref --- clan

[clang] [llvm] [clang][docs] Fix typos concerning wasm __funcref (PR #124365)

https://github.com/anematode updated https://github.com/llvm/llvm-project/pull/124365 >From 2508da6fd7f38101011573460724f13df1c1616d Mon Sep 17 00:00:00 2001 From: Timothy Herchen Date: Fri, 24 Jan 2025 15:13:30 -0800 Subject: [PATCH 1/2] [clang][docs] Fix typos concerning wasm __funcref ---

[clang] [clang][docs] Fix typos concerning wasm __funcref (PR #124365)

https://github.com/anematode created https://github.com/llvm/llvm-project/pull/124365 The docs conflate `__funcref` with an actual type in a couple places. >From 2508da6fd7f38101011573460724f13df1c1616d Mon Sep 17 00:00:00 2001 From: Timothy Herchen Date: Fri, 24 Jan 2025 15:13:30 -0800 Subjec

[clang] [clang][Sema] Add noinline check for __builtin_frame_address and __builtin_return_address (PR #82966)

anematode wrote: It's used 100+ more times through the macro `_RET_IP_`. https://elixir.bootlin.com/linux/latest/source/include/linux/instruction_pointer.h#L7 https://elixir.bootlin.com/linux/latest/source/include/linux/kasan.h#L164 has some example uses where `always_inline` is important for

[clang] [clang][Sema] Add noinline check for __builtin_frame_address and __builtin_return_address (PR #82966)

anematode wrote: > Although I seem to remember having seen code that uses `always_inline` in > order to force `__builtin_return_address` to actually apply to its caller. Right; that's why I thought just disabling inlining would be a suboptimal choice, although I guess you could have `always_in

[clang] [clang][Sema] Add noinline check for __builtin_frame_address and __builtin_return_address (PR #82966)

anematode wrote: > I'm seeing evidence that this might be a chatty diagnostic in practice: > > https://sourcegraph.com/github.com/torvalds/linux@90d35da658da8cff0d4ecbb5113f5fac9d00eb72/-/blob/kernel/fork.c?L311 > > https://sourcegraph.com/github.com/torvalds/linux@90d35da658da8cff0d4ecbb5113f

[clang] [clang][Sema] Add noinline check for __builtin_frame_address and __builtin_return_address (PR #82966)

https://github.com/anematode edited https://github.com/llvm/llvm-project/pull/82966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Add noinline check for __builtin_frame_address and __builtin_return_address (PR #82966)

https://github.com/anematode edited https://github.com/llvm/llvm-project/pull/82966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Add noinline check for __builtin_frame_address and __builtin_return_address (PR #82966)

https://github.com/anematode ready_for_review https://github.com/llvm/llvm-project/pull/82966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Add noinline check for __builtin_frame_address and __builtin_return_address (PR #82966)

https://github.com/anematode updated https://github.com/llvm/llvm-project/pull/82966 >From e5646f3f4967847ef68d428c84b30dbd4d2e8e49 Mon Sep 17 00:00:00 2001 From: Timothy Herchen Date: Mon, 26 Feb 2024 12:21:40 -0800 Subject: [PATCH] Add noinline check for __builtin_frame_address and __builtin

[clang] [clang][Sema] Add noinline check for __builtin_frame_address and __builtin_return_address (PR #82966)

https://github.com/anematode updated https://github.com/llvm/llvm-project/pull/82966 >From cd68484e851040fc84e66933454f6fd910566b81 Mon Sep 17 00:00:00 2001 From: Timothy Herchen Date: Mon, 26 Feb 2024 12:21:40 -0800 Subject: [PATCH] Add noinline check for __builtin_frame_address and __builtin

[clang] [clang][Sema] Add noinline check for __builtin_frame_address and __builtin_return_address (PR #82966)

https://github.com/anematode updated https://github.com/llvm/llvm-project/pull/82966 >From ef4c372a4d9364e6457c88a940c9af8666de0b74 Mon Sep 17 00:00:00 2001 From: Timothy Herchen Date: Mon, 26 Feb 2024 00:01:27 -0800 Subject: [PATCH] Add noinline check for __builtin_frame_address and __builtin

[clang] [clang][Sema] Add noinline check for __builtin_frame_address and __builtin_return_address (PR #82966)

https://github.com/anematode created https://github.com/llvm/llvm-project/pull/82966 Will resolve https://github.com/llvm/llvm-project/issues/66059 . GCC's behavior in the case of inlining (https://gcc.gnu.org/onlinedocs/gcc/Return-Address.html) is that a caller's return/frame address may be