[PATCH] D158265: [clang][AST] TextNodeDumper learned to output refers_to_enclosing_variable_or_capture flag for DeclRefExpr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd34e97c8a117: [clang][AST] TextNodeDumper learned to output… (authored by strimo378). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D158242: [Clang][Attribute] Introduce linkage attribute to specify the exact LLVM linkage type for functions or variables

strimo378 added a comment. > I'm wary of exposing internal LLVM implementation details through a > user-facing attribute like this. @aaron.ballman That means you would be more open to an attribute like `__attribute__((onedefinitionrule))` because it is part of the C++ standard? Repository:

[PATCH] D158265: [clang][AST] TextNodeDumper learned to output refers_to_enclosing_variable_or_capture flag for DeclRefExpr

strimo378 added a comment. It is not that easy. It is an important flag for lambdas and it took me quite a while analyzing codegen to find it. In general, it is very seldom useful. OpenMP seems to have to good test coverage of ast-dump test cases. I think it is also used for nested C function t

[PATCH] D158267: [clang][CodeGen] Avoid emitting unnecessary memcpy of records without content

strimo378 created this revision. Herald added a project: All. strimo378 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang codegen emits an unnecessary memcpy for C++ class without content. This patch fixes the issue. See https://githu

[PATCH] D158265: [clang][AST] TextNodeDumper learned to output refers_to_enclosing_variable_or_capture flag for DeclRefExpr

strimo378 created this revision. strimo378 added a reviewer: aaron.ballman. Herald added a project: All. strimo378 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158265 File

[PATCH] D158242: [Clang][Attribute] Introduce linkage attribute to specify the exact LLVM linkage type for functions or variables

strimo378 created this revision. Herald added a reviewer: aaron.ballman. Herald added a project: All. strimo378 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158242 Files:

[PATCH] D158188: [clang][AST] TextNodeDumper learned to output friend information for functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG110d141f12b7: [clang][AST] TextNodeDumper learned to output friend information for functions (authored by strimo378). Repository: rG LLVM Github M

[PATCH] D158055: [clang][AST] Added some missing setter methods

strimo378 abandoned this revision. strimo378 added a comment. Alright, thank you for the review... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158055/new/ https://reviews.llvm.org/D158055 ___ cfe-commi

[PATCH] D158188: [clang][AST] TextNodeDumper learned to output friend information for functions

strimo378 created this revision. strimo378 added a reviewer: aaron.ballman. Herald added a project: All. strimo378 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158188 File

[PATCH] D158165: [clang][AST] TextNodeDumper learned to output instantiated_from information

This revision was automatically updated to reflect the committed changes. Closed by commit rGd7f7fb6c1d97: [clang][AST] TextNodeDumper learned to output instantiated_from information (authored by strimo378). Changed prior to commit: https://reviews.llvm.org/D158165?vs=551068&id=551124#toc Repo

[PATCH] D158165: [clang][AST] TextNodeDumper learned to output instantiated_from information

strimo378 created this revision. strimo378 added a reviewer: aaron.ballman. Herald added a project: All. strimo378 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158165 File

[PATCH] D158055: [clang][AST] Added some missing setter methods

strimo378 added a comment. Yes, I have a need for these setters :) but I cannot decide if the LLVM project in general or other people could profit from it. I am working on a C++-to-C transpiler based on clang. Other clang-based tool typically modify the intput file based on FileLocation informa

[PATCH] D158055: [clang][AST] Added some missing setter methods

strimo378 added a comment. I added some missing (simple) setter methods to Decl and Expr classes. I did not comment them since typically simple setter methods are uncommented. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158055/new/ https://revie

[PATCH] D158055: [clang][AST] Added some missing setter methods

strimo378 created this revision. Herald added a project: All. strimo378 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158055 Files: clang/include/clang/AST/Decl.h clang

[PATCH] D158047: [clang][ASTImporter] Add import of 'BitIntType'

strimo378 added a comment. I think the ASTImporter class has in general a completion problem. What do you think about rewriting it that any missing Visit* function for Type, Decl and Stmt produces an compiler error? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D158047: [clang][ASTImporter] Add import of 'BitIntType'

strimo378 created this revision. strimo378 added a reviewer: aaron.ballman. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. strimo378 requested review of this revision. Herald added a project: clang. Herald added

[PATCH] D157681: [clang][AST] TextNodeDumper learned to dump qualifiers (NestedNameSpecifier)

This revision was automatically updated to reflect the committed changes. Closed by commit rGcad3130a23da: [clang][AST] TextNodeDumper learned to dump qualifiers (NestedNameSpecifier) (authored by strimo378). Changed prior to commit: https://reviews.llvm.org/D157681?vs=549273&id=550387#toc Rep

[PATCH] D157687: [clang][AST] TextNodeDumper learned to dump NRVO candidates of return stmts

This revision was automatically updated to reflect the committed changes. Closed by commit rGeda9d27a91e6: [clang][AST] TextNodeDumper learned to dump NRVO candidates of return stmts (authored by strimo378). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D157705: [clang][AST] TextNodeDumper learned to output template specialization kind

This revision was automatically updated to reflect the committed changes. Closed by commit rG3bfafc4f2287: [clang][AST] TextNodeDumper learned to output template specialization kind (authored by strimo378). Changed prior to commit: https://reviews.llvm.org/D157705?vs=549346&id=550354#toc Repos

[PATCH] D157687: [clang][AST] TextNodeDumper learned to dump NRVO candidates of return stmts

strimo378 added a comment. @aaron.ballman Alright ... I managed to extend an existing test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157687/new/ https://reviews.llvm.org/D157687 ___ cfe-commits

[PATCH] D157687: [clang][AST] TextNodeDumper learned to dump NRVO candidates of return stmts

strimo378 updated this revision to Diff 550319. strimo378 added a comment. Added test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157687/new/ https://reviews.llvm.org/D157687 Files: clang/include/clang/AST/TextNodeDumper.h clang/lib/AST

[PATCH] D141714: Fix ast print of variables with attributes

strimo378 added a comment. @aaron.ballman I had today a teams meeting with @giulianobelinassi and we discussed both patches as well as that we want to work together in improving AST print. Both patches are fine for us since they improve the attribute printing. The features of the respective oth

[PATCH] D157705: [clang][AST] TestNodeDumper learned to output template specialization kind

strimo378 created this revision. strimo378 added a reviewer: aaron.ballman. Herald added a project: All. strimo378 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D157705 File

[PATCH] D157687: [clang][AST] TextNodeDumper learned to dump NRVO candidates of return stmts

strimo378 created this revision. strimo378 added a reviewer: aaron.ballman. Herald added a project: All. strimo378 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D157687 File

[PATCH] D157681: [clang][AST] TextNodeDumper learned to dump qualifiers (NestedNameSpecifier)

strimo378 created this revision. Herald added a project: All. strimo378 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D157681 Files: clang/include/clang/AST/TextNodeDumper

[PATCH] D155383: [clang][AST] TextNodeDumper learned to output exception specifications

This revision was automatically updated to reflect the committed changes. Closed by commit rG7fc6fa97edb6: [clang][AST] TextNodeDumper learned to output exception specifications (authored by strimo378). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D155383: [clang][AST] TextNodeDumper learned to output exception specifications

strimo378 added a comment. I added a test case for demonstrating `NoexceptExpr` and `Exceptions` output. I don't know how to produce a FunctionProtoType output with ExceptionSourceDecl and ExceptionSourceTemplate. typedef/using is the only way I know to output types for the current AST dump and

[PATCH] D155383: [clang][AST] TextNodeDumper learned to output exception specifications

strimo378 updated this revision to Diff 548964. strimo378 added a comment. Added test cases and applied review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155383/new/ https://reviews.llvm.org/D155383 Files: clang/lib/AST/TextNodeDump

[PATCH] D157394: [clang][DeclPrinter] Improve AST print of function attributes

strimo378 added inline comments. Comment at: clang/lib/AST/DeclPrinter.cpp:267 +// C2x/C++11-style attributes must appear before the declarator. +if (S == Attr::AS_CXX11 || S == Attr::AS_C2x) + return AttrLocation::BeforeDecl; strimo378 wrote: > giul

[PATCH] D157394: [clang][DeclPrinter] Improve AST print of function attributes

strimo378 updated this revision to Diff 548916. strimo378 added a comment. Added more test cases and considering __declspec Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157394/new/ https://reviews.llvm.org/D157394 Files: clang/lib/AST/DeclPrint

[PATCH] D157394: [clang][DeclPrinter] Improve AST print of function attributes

strimo378 added a comment. In D157394#4572777 , @giulianobelinassi wrote: > This patch do not address attributes in variables nor the __declspec case, as > D141714 do. His patch looks cleaner and I > can surely coordi

[PATCH] D141714: Fix ast print of variables with attributes

strimo378 added a comment. @giulianobelinassi I provided a similar patch as you addressed here, see https://reviews.llvm.org/D157394 . It looks like we have the same requirement that we both need compilable ast-print code. Are you interested in a teams meeting to discuss the topic and align our

[PATCH] D157384: [clang] Added Attr::getVariety function

strimo378 abandoned this revision. strimo378 added a comment. Unnecessary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157384/new/ https://reviews.llvm.org/D157384 ___ cfe-commits mailing list cfe-commi

[PATCH] D157384: [clang] Added Attr::getVariety function

strimo378 updated this revision to Diff 548482. strimo378 added a comment. Using Attr::getSyntax (instead of unnecessary added Attr::getVariety) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157384/new/ https://reviews.llvm.org/D157384 Files: cl

[PATCH] D157394: [clang][DeclPrinter] Improve AST print of function attributes

strimo378 updated this revision to Diff 548487. strimo378 edited the summary of this revision. strimo378 added a comment. Using Attr::getSyntax function (instead of unnecessarly added Attr::getVariety function) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D157384: [clang] Added Attr::getVariety function

strimo378 abandoned this revision. strimo378 added a comment. @aaron.ballman Thank you for the information. Strange that I missed that ... I even used the function somewhere else o_O Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157384/new/ https:

[PATCH] D157394: [clang][DeclPrinter] Improved AST print of function attributes

strimo378 created this revision. Herald added a project: All. strimo378 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, wangpc, jplehr, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm

[PATCH] D157384: [clang] Added Attr::getVariety function

strimo378 created this revision. strimo378 added a reviewer: aaron.ballman. Herald added a project: All. strimo378 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The commit extends ClangAttrEmitter of tablegen to generate Attr*::getVariety

[PATCH] D156523: [clang][DeclPrinter] Fix AST print to suppress output of implicit (non-written) constructor initializers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG291eb2589fdc: [clang][DeclPrinter] Fix AST print to suppress output of implicit (non-written)… (authored by strimo378). Changed prior to commit: h

[PATCH] D156533: [clang][DeclPrinter] Fix missing semicolon in AST print for methods that are definitions without having a body

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa3da6284c23a: [clang][DeclPrinter] Fix missing semicolon in AST print for methods that are… (authored by strimo378). Repository: rG LLVM Github Mo

[PATCH] D156533: [clang][DeclPrinter] Fix missing semicolon in AST print for methods that are definitions without having a body

strimo378 added a comment. https://github.com/llvm/llvm-project/issues/62996 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156533/new/ https://reviews.llvm.org/D156533 ___ cfe-commits mailing list cfe-co

[PATCH] D156533: [clang][DeclPrinter] Fix missing semicolon in AST print for methods that are definitions without having a body

strimo378 created this revision. strimo378 added a reviewer: aaron.ballman. Herald added a project: All. strimo378 requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. DeclPrinter used FunctionDecl::isThisDeclarationADefinition to decide

[PATCH] D156523: [clang][DeclPrinter] Fix AST print to suppress output of implicit (non-written) constructor initializers

strimo378 added a comment. The current output of the test case can be shown here: https://godbolt.org/z/95ToPbqrP Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156523/new/ https://reviews.llvm.org/D156523 _

[PATCH] D156523: [clang][DeclPrinter] Fix AST print to suppress output of implicit (non-written) constructor initializers

strimo378 created this revision. strimo378 added a reviewer: aaron.ballman. Herald added a project: All. strimo378 requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. DeclPrinter::PrintConstructorInitializers did output non-written const

[PATCH] D156307: [clang][DeclPrinter] Fix AST print of curly constructor initializers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e4c5cc56c14: [clang][DeclPrinter] Fix AST print of curly constructor initializers (authored by strimo378). Repository: rG LLVM Github Monorepo C

[PATCH] D156307: [clang][DeclPrinter] Fix AST print of curly constructor initializers

strimo378 updated this revision to Diff 544566. strimo378 added a comment. Added additional ctor variants as suggested by the reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156307/new/ https://reviews.llvm.org/D156307 Files: clang/lib/

[PATCH] D156307: [clang][DeclPrinter] Fix AST print of curly constructor initializers

strimo378 created this revision. Herald added a project: All. strimo378 requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D156307 Files: clang/lib/AST/DeclPrinter.cpp

[PATCH] D154186: [clang][DeclPrinter] Fix AST print of delegating constructors

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2ca74162258b: [clang][DeclPrinter] Fix AST print of delegating constructors (authored by strimo378). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D154186: [clang][DeclPrinter] Fix AST print of delegating constructors

strimo378 added a comment. I plan around half a dozen patches only for ast-print functionality. I would love to land it myself and will asked for commit privileges. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154186/new/ https://reviews.llvm.org

[PATCH] D154186: [clang][DeclPrinter] Fix AST print of delegating constructors

strimo378 marked 3 inline comments as done. strimo378 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154186/new/ https://reviews.llvm.org/D154186 ___ cfe-commits mailing list cfe-com

[PATCH] D139267: Supporting tbaa.struct metadata generation for bitfields

strimo378 added a comment. Herald added a subscriber: wangpc. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139267/new/ https://reviews.llvm.org/D139267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D155383: [clang][AST] TextNodeDumper learned to output exception specifications

strimo378 added a comment. There are many ast-dump tests about decls but there are nearly no other type tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155383/new/ https://reviews.llvm.org/D155383

[PATCH] D155383: [clang][AST] TextNodeDumper learned to output exception specifications

strimo378 created this revision. strimo378 added reviewers: aaron.ballman, hazohelet, stephenkelly. strimo378 added a project: clang. Herald added a project: All. strimo378 requested review of this revision. Herald added a subscriber: cfe-commits. Extended TextNodeDumper::VisitFunctionProtoType to

[PATCH] D154186: [clang][DeclPrinter] Fix AST print of delegating constructors

strimo378 updated this revision to Diff 540627. strimo378 added a comment. Updated test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154186/new/ https://reviews.llvm.org/D154186 Files: clang/lib/AST/DeclPrinter.cpp clang/test/AST/ast-pri

[PATCH] D154186: [clang][DeclPrinter] Fix AST print of delegating constructors

strimo378 added inline comments. Comment at: clang/test/AST/ast-print-method-decl.cpp:15 + // CHECK-NEXT: }; +}; aaron.ballman wrote: > I'd also like to see test cases along the lines of: > ``` > struct B { > template > B(Ty); > B(int X) : B((float)X) {}

[PATCH] D154186: [clang][DeclPrinter] Fix AST print of delegating constructors

strimo378 created this revision. strimo378 added a reviewer: aaron.ballman. strimo378 added a project: clang. Herald added a project: All. strimo378 requested review of this revision. Herald added a subscriber: cfe-commits. DeclPrinter::PrintConstructorInitializers did not consider delegating ini

[PATCH] D139267: Supporting tbaa.struct metadata generation for bitfields

strimo378 added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139267/new/ https://reviews.llvm.org/D139267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D151528: [clang][DeclPrinter] Fix AST print of out-of-line record definitions

strimo378 added a comment. Please use "Timo Stripf" and timo.str...@emmtrix.com Thank you for your review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151528/new/ https://reviews.llvm.org/D151528 ___

[PATCH] D139267: Supporting tbaa.struct metadata generation for bitfields

strimo378 updated this revision to Diff 525387. strimo378 added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. - Updated a test case - Supporting correct output for -new-struct-path-tbaa - Added a paragraph to LangRef.rst (see https://discourse.llvm.org/t/rfc-cl

[PATCH] D139267: Supporting tbaa.struct metadata generation for bitfields

strimo378 created this revision. strimo378 added a project: clang. Herald added subscribers: jeroen.dobbelaere, kosarev. Herald added a project: All. strimo378 requested review of this revision. Herald added a subscriber: cfe-commits. Hi all, this is my first contribution to the LLVM project. Th