Author: timshen
Date: Fri Sep 13 14:06:47 2019
New Revision: 371897
URL: http://llvm.org/viewvc/llvm-project?rev=371897&view=rev
Log:
Fix test to use %t for newly created files.
This is both for consistency with other `mkdir`s in tests, and
fixing permission issues with the non-temporary cwd duri
Author: timshen
Date: Thu Sep 12 14:18:44 2019
New Revision: 371773
URL: http://llvm.org/viewvc/llvm-project?rev=371773&view=rev
Log:
[ClangTidy] Adjust the name getCheckName to getCheckerName due to API change.
Modified:
clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp
Modified: clang-tools
Author: timshen
Date: Tue Sep 4 15:20:11 2018
New Revision: 341418
URL: http://llvm.org/viewvc/llvm-project?rev=341418&view=rev
Log:
Revert r341373, since it fails on some targets.
Differential Revision: https://reviews.llvm.org/D51354
Removed:
cfe/trunk/test/Driver/print-multi-directory.c
Author: timshen
Date: Mon Jul 30 16:05:40 2018
New Revision: 338325
URL: http://llvm.org/viewvc/llvm-project?rev=338325&view=rev
Log:
[libcxx] fix `>> 42` UB in
Modified:
libcxx/trunk/test/std/experimental/simd/simd.access/default.pass.cpp
Modified: libcxx/trunk/test/std/experimental/simd/s
Author: timshen
Date: Mon Jul 30 15:27:38 2018
New Revision: 338318
URL: http://llvm.org/viewvc/llvm-project?rev=338318&view=rev
Log:
Re-apply "[libcxx] implement ABI for Clang/GCC vector extension,
constructors, copy_from and copy_to."
...with proper guarding #ifdefs for unsupported C++11.
Ad
Author: timshen
Date: Mon Jul 30 15:21:22 2018
New Revision: 338316
URL: http://llvm.org/viewvc/llvm-project?rev=338316&view=rev
Log:
Revert "[libcxx] implement ABI for Clang/GCC vector extension,
constructors, copy_from and copy_to."
This reverts commit r338309.
Removed:
libcxx/trunk/test
Author: timshen
Date: Mon Jul 30 14:23:13 2018
New Revision: 338309
URL: http://llvm.org/viewvc/llvm-project?rev=338309&view=rev
Log:
[libcxx] implement ABI for Clang/GCC vector extension, constructors,
copy_from and copy_to.
Summary:
This patch adds a new macro _LIBCPP_HAS_NO_VECTOR_EXTENSION
Author: timshen
Date: Wed May 30 18:51:07 2018
New Revision: 333617
URL: http://llvm.org/viewvc/llvm-project?rev=333617&view=rev
Log:
[X86] Fix wrong intrinsic semantic.
Modified:
cfe/trunk/lib/Headers/avxintrin.h
cfe/trunk/lib/Headers/emmintrin.h
Modified: cfe/trunk/lib/Headers/avxintri
Author: timshen
Date: Mon Apr 23 14:54:06 2018
New Revision: 330655
URL: http://llvm.org/viewvc/llvm-project?rev=330655&view=rev
Log:
Re-commit r330627 "[libcxx] implement declarations based on
P0214R7."
There are 3 changes:
* Renamed genertor.pass.cpp to generator.pass.cpp
* Removed nothing_to
Author: timshen
Date: Mon Apr 23 12:56:20 2018
New Revision: 330636
URL: http://llvm.org/viewvc/llvm-project?rev=330636&view=rev
Log:
Revert "[libcxx] implement declarations based on P0214R7."
This reverts commit r330627.
This causes several bots to freak out.
Removed:
libcxx/trunk/include
Author: timshen
Date: Mon Apr 23 11:47:07 2018
New Revision: 330627
URL: http://llvm.org/viewvc/llvm-project?rev=330627&view=rev
Log:
[libcxx] implement declarations based on P0214R7.
Summary:
The patch includes all declarations, and also implements the following features:
* ABI.
* narrowing-con
Author: timshen
Date: Tue Jan 2 14:04:03 2018
New Revision: 321678
URL: http://llvm.org/viewvc/llvm-project?rev=321678&view=rev
Log:
Revert `rL321667: [PPC64] Port to ppc64le - initial version`
Differential Revision: https://reviews.llvm.org/D41386
Modified:
libunwind/trunk/include/__libunw
Author: timshen
Date: Mon Oct 23 20:11:02 2017
New Revision: 316411
URL: http://llvm.org/viewvc/llvm-project?rev=316411&view=rev
Log:
[test] Fix clang-test for FreeBSD and NetBSD
Lit tries to inject the shared library paths, but no action is taken
when platform.system() is not recognized, results
Author: timshen
Date: Tue Oct 3 12:39:02 2017
New Revision: 314831
URL: http://llvm.org/viewvc/llvm-project?rev=314831&view=rev
Log:
Revert r314820 "[Analyzer] More granular special casing in RetainCountChecker"
The test retain-release.m fails with this patch.
Differential Revision: https://rev
Author: timshen
Date: Wed Aug 2 17:18:11 2017
New Revision: 309908
URL: http://llvm.org/viewvc/llvm-project?rev=309908&view=rev
Log:
[Sema] Add a comment on an identified bug on default arguments.
Summary:
The mis-compile is triggered by internal code, but I haven't reduced it to a
small piece
Author: timshen
Date: Thu Jun 29 16:10:13 2017
New Revision: 306757
URL: http://llvm.org/viewvc/llvm-project?rev=306757&view=rev
Log:
[NewPM] Add Clang cc1 flag -fdebug-pass-manager for printing debug information.
Differential Revision: https://reviews.llvm.org/D34790
Added:
cfe/trunk/test/C
Author: timshen
Date: Thu Jun 29 16:08:38 2017
New Revision: 306756
URL: http://llvm.org/viewvc/llvm-project?rev=306756&view=rev
Log:
[ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.
Previously it doesn't actually invoke the designated new PM builder
functions.
This patch moves NameAnonG
Author: timshen
Date: Thu Jun 1 19:08:58 2017
New Revision: 304501
URL: http://llvm.org/viewvc/llvm-project?rev=304501&view=rev
Log:
[ThinLTO] Add x86 requires to thin_link_bitcode. NFC.
It already specifies the triples, so the intention was to test x86 for
now (or then).
Differential Revision:
Author: timshen
Date: Thu Jun 1 18:27:51 2017
New Revision: 304496
URL: http://llvm.org/viewvc/llvm-project?rev=304496&view=rev
Log:
[ThinLTO] Wire up ThinLTO and new PM
Summary: This patch teaches clang to use and propagate new PM in ThinLTO.
Reviewers: davide, chandlerc, tejohnson
Subscriber
Author: timshen
Date: Tue Feb 21 16:30:00 2017
New Revision: 295778
URL: http://llvm.org/viewvc/llvm-project?rev=295778&view=rev
Log:
[XRay] Merge xray clang flag tests, and add powerpc64le.
Summary: I'm not sure why they were in different files, but it's kind of harder
to maintain. I create thi
On Wed, Feb 15, 2017, 00:01 Eric Christopher via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: echristo
> Date: Wed Feb 15 01:50:11 2017
> New Revision: 295156
>
> URL: http://llvm.org/viewvc/llvm-project?rev=295156&view=rev
> Log:
> Add a definition for __STRUCT_PARM_ALIGN__ for elfv
Author: timshen
Date: Tue Feb 14 18:01:12 2017
New Revision: 295127
URL: http://llvm.org/viewvc/llvm-project?rev=295127&view=rev
Log:
[VLA] Fix the test failure on msvc by specifying the triple.
Differential Revision: https://reviews.llvm.org/D24333
Modified:
cfe/trunk/test/Sema/pr30306.cpp
Author: timshen
Date: Tue Feb 14 17:46:37 2017
New Revision: 295123
URL: http://llvm.org/viewvc/llvm-project?rev=295123&view=rev
Log:
[VLA] Handle VLA size expression in a full-expression context.
Summary: Previously the cleanups (e.g. dtor calls) are inserted into the
outer scope (e.g. function
Author: timshen
Date: Fri Feb 10 15:03:24 2017
New Revision: 294781
URL: http://llvm.org/viewvc/llvm-project?rev=294781&view=rev
Log:
[XRay] Implement powerpc64le xray.
Summary:
powerpc64 big-endian is not supported, but I believe that most logic can
be shared, except for xray_powerpc64.cc.
Also
Author: timshen
Date: Mon Jan 23 16:39:35 2017
New Revision: 292839
URL: http://llvm.org/viewvc/llvm-project?rev=292839&view=rev
Log:
[APFloat] Switch from (PPCDoubleDoubleImpl, IEEEdouble) layout to (IEEEdouble,
IEEEdouble)
Summary:
This patch changes the layout of DoubleAPFloat, and adjust all
Author: timshen
Date: Fri Jan 20 16:05:33 2017
New Revision: 292659
URL: http://llvm.org/viewvc/llvm-project?rev=292659&view=rev
Log:
[Altivec] Change vec_sl to a << (b % (sizeof(a) * 8))
For a << b (as original vec_sl does), if b >= sizeof(a) * 8, the
behavior is undefined. However, Power instru
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285657: [ReachableCode] Skip over ExprWithCleanups in
isConfigurationValue (authored by timshen).
Changed prior to commit:
https://reviews.llvm.org/D24010?vs=75644&id=76508#toc
Repository:
rL LLVM
h
Author: timshen
Date: Mon Oct 31 19:19:04 2016
New Revision: 285657
URL: http://llvm.org/viewvc/llvm-project?rev=285657&view=rev
Log:
[ReachableCode] Skip over ExprWithCleanups in isConfigurationValue
Summary: Fixes pr29152.
Reviewers: rsmith, pirama, krememek
Subscribers: cfe-commits
Differen
Author: timshen
Date: Thu Oct 27 16:40:34 2016
New Revision: 285352
URL: http://llvm.org/viewvc/llvm-project?rev=285352&view=rev
Log:
[libcxx] Make regex_match backtrack when search fails
Summary:
Fixes PR19851.
alg.re.match/ecma.pass.cpp still XFAILS on linux, but after commenting out
locale-rel
This revision was automatically updated to reflect the committed changes.
timshen marked an inline comment as done.
Closed by commit rL285352: [libcxx] Make regex_match backtrack when search
fails (authored by timshen).
Changed prior to commit:
https://reviews.llvm.org/D26026?vs=76088&id=76109#
timshen updated this revision to Diff 76088.
timshen added a comment.
Added http://www.open-std.org/jtc1/sc22/wg21/docs/lwg-defects.html#2273 as
comments.
https://reviews.llvm.org/D26026
Files:
libcxx/include/regex
libcxx/test/std/re/re.alg/re.alg.match/ecma.pass.cpp
Index: libcxx/test/st
timshen marked an inline comment as done.
timshen added inline comments.
Comment at: libcxx/test/std/re/re.alg/re.alg.match/ecma.pass.cpp:374
std::cmatch m;
const char s[] = "tournament";
+assert(std::regex_match(s, m, std::regex("tour|to|tournament")));
timshen created this revision.
timshen added a reviewer: mclow.lists.
timshen added a subscriber: cfe-commits.
Herald added a subscriber: emaste.
Fixes PR19851.
alg.re.match/ecma.pass.cpp still XFAILS on linux, but after commenting out
locale-related tests, it passes. I don't have a freebsd machin
d Blaikie wrote:
>
> On Mon, Aug 29, 2016 at 3:45 PM Tim Shen via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> timshen created this revision.
> timshen added reviewers: rsmith, pirama.
> timshen added a subscriber: cfe-commits.
>
> https://reviews.l
On Mon, Oct 24, 2016 at 10:33 AM David Blaikie wrote:
> On Mon, Aug 29, 2016 at 3:45 PM Tim Shen via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> timshen created this revision.
> timshen added reviewers: rsmith, pirama.
> timshen added a subscriber
timshen updated this revision to Diff 75644.
timshen added a comment.
Simplified the test.
https://reviews.llvm.org/D24010
Files:
clang/include/clang/AST/Stmt.h
clang/lib/Analysis/ReachableCode.cpp
clang/test/SemaCXX/PR29152.cpp
Index: clang/test/SemaCXX/PR29152.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284881: [libcxx] Support
std::regex_constants::match_not_null (authored by timshen).
Changed prior to commit:
https://reviews.llvm.org/D25595?vs=75186&id=75480#toc
Repository:
rL LLVM
https://review
Author: timshen
Date: Fri Oct 21 15:41:47 2016
New Revision: 284881
URL: http://llvm.org/viewvc/llvm-project?rev=284881&view=rev
Log:
[libcxx] Support std::regex_constants::match_not_null
Summary: Fixes PR21597.
Reviewers: mclow.lists, EricWF
Subscribers: cfe-commits
Differential Revision: htt
timshen updated this revision to Diff 75186.
timshen added a comment.
Add tests for regex_match.
https://reviews.llvm.org/D25595
Files:
libcxx/include/regex
libcxx/test/std/re/re.const/re.matchflag/match_not_null.pass.cpp
Index: libcxx/test/std/re/re.const/re.matchflag/match_not_null.pass
timshen added a comment.
In https://reviews.llvm.org/D25595#574364, @mclow.lists wrote:
> Do we need to test calling `regex_match` with `match_not_null`?
> If not, then I think this is good to go.
Done.
> Do you have commit access, or would you rather I committed it?
Yes, I have the commit a
timshen added a comment.
In https://reviews.llvm.org/D25595#571171, @mclow.lists wrote:
> I like the fix. :-)
>
> However, I think that the test, rather than going in a bug specific file
> (pr21597.pass.cpp), should be added to the existing tests - where it should
> have been in the first place
timshen updated this revision to Diff 74894.
timshen marked an inline comment as done.
timshen added a comment.
Updated file location and documentation.
https://reviews.llvm.org/D25595
Files:
libcxx/include/regex
libcxx/test/std/re/re.const/re.matchflag/match_not_null.pass.cpp
Index: libc
timshen created this revision.
timshen added reviewers: mclow.lists, EricWF.
timshen added a subscriber: cfe-commits.
Fixes PR21597.
https://reviews.llvm.org/D25595
Files:
libcxx/include/regex
libcxx/test/std/re/re.alg/re.alg.search/pr21597.pass.cpp
Index: libcxx/test/std/re/re.alg/re.alg
timshen added inline comments.
Comment at: clang/include/clang/Analysis/CallGraph.h:204
+ static clang::CallGraphNode *
+ CGGetValue(decltype(*std::declval()) &P) {
+return P.second.get();
Does clang::CallGraph::const_iterator::value_type work?
https://re
timshen added inline comments.
Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.h:514
+ MutableArrayRef> Callbacks)
+ : Overloads(std::make_move_iterator(Callbacks.begin()),
+ std::make_move_iterator(Callbacks.end())) {}
Notice tha
timshen accepted this revision.
timshen added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/include/clang/Sema/Sema.h:879
/// do not have lambda expressions or block literals.
-IntrusiveRefCntPtr MangleNumbering;
+std::unique_ptr
timshen added inline comments.
Comment at: llvm/lib/IR/LLVMContextImpl.cpp:106
for (auto &CDSConstant : CDSConstants)
delete CDSConstant.second;
CDSConstants.clear();
Do you want to change this one as well?
https://reviews.llvm.org/D25419
timshen updated this revision to Diff 70667.
timshen added a comment.
Update the test file name and remove unused code.
https://reviews.llvm.org/D24333
Files:
clang/lib/Sema/SemaDecl.cpp
clang/lib/Sema/SemaExpr.cpp
clang/lib/Sema/SemaExprCXX.cpp
clang/test/SemaCXX/pr30306.cpp
Index: cl
timshen created this revision.
timshen added a reviewer: rsmith.
timshen added a subscriber: cfe-commits.
Before r272296, the assertion was !ExprNeedsCleanups, which means that there is
no cleanups (with dtor calls). It should still check so after r272296. This
fixes pr30306.
https://reviews.ll
Author: timshen
Date: Wed Aug 31 11:48:13 2016
New Revision: 280257
URL: http://llvm.org/viewvc/llvm-project?rev=280257&view=rev
Log:
s/static inline/static/ for headers I have changed in r279475. NFC.
Modified:
cfe/trunk/include/clang/AST/StmtGraphTraits.h
cfe/trunk/include/clang/Analysi
timshen created this revision.
timshen added reviewers: rsmith, pirama.
timshen added a subscriber: cfe-commits.
https://reviews.llvm.org/D24010
Files:
clang/include/clang/AST/Stmt.h
clang/lib/Analysis/ReachableCode.cpp
clang/test/SemaCXX/PR29152.cpp
Index: clang/test/SemaCXX/PR29152.cpp
=
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279475: [GraphTraits] Replace all NodeType usage with
NodeRef (authored by timshen).
Changed prior to commit:
https://reviews.llvm.org/D23730?vs=68748&id=68912#toc
Repository:
rL LLVM
https://review
Author: timshen
Date: Mon Aug 22 16:09:30 2016
New Revision: 279475
URL: http://llvm.org/viewvc/llvm-project?rev=279475&view=rev
Log:
[GraphTraits] Replace all NodeType usage with NodeRef
This should finish the GraphTraits migration.
Differential Revision: http://reviews.llvm.org/D23730
Modifie
timshen added a comment.
In https://reviews.llvm.org/D23730#522537, @dblaikie wrote:
> I'd sort of be inclined to remove them, then - but I leave that up to you.
It looks like people create some class, and add GraphTraits specialization for
it, in the hope that others can use it, but didn't wr
timshen added inline comments.
Comment at: llvm/trunk/include/llvm/CodeGen/ScheduleDAG.h:684-688
@@ -684,7 +683,7 @@
typedef SUnitIterator ChildIteratorType;
-static inline NodeType *getEntryNode(SUnit *N) { return N; }
-static inline ChildIteratorType child_begin(Nod
timshen added a comment.
In https://reviews.llvm.org/D23730#522396, @dblaikie wrote:
> Not all of these already had NodeRef implemented - that implies that some
> algorithms weren't using NodeRef before this change, or that these traits are
> unused? I thought the plan was to migrate each algor
timshen created this revision.
timshen added a reviewer: dblaikie.
timshen added subscribers: llvm-commits, cfe-commits.
Herald added subscribers: mzolotukhin, MatzeB.
This should finish the GraphTraits migration.
https://reviews.llvm.org/D23730
Files:
cfe/trunk/include/clang/AST/StmtGraphTrai
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279329: [CallGraph] Use decltype instead of
pointer_to_unary_function. NFC. (authored by timshen).
Changed prior to commit:
https://reviews.llvm.org/D23726?vs=68733&id=68736#toc
Repository:
rL LLVM
Author: timshen
Date: Fri Aug 19 16:52:42 2016
New Revision: 279329
URL: http://llvm.org/viewvc/llvm-project?rev=279329&view=rev
Log:
[CallGraph] Use decltype instead of pointer_to_unary_function. NFC.
Reviewers: dblaikie
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/
timshen created this revision.
timshen added a reviewer: dblaikie.
timshen added a subscriber: cfe-commits.
https://reviews.llvm.org/D23726
Files:
include/clang/Analysis/CallGraph.h
Index: include/clang/Analysis/CallGraph.h
===
--
timshen closed this revision.
timshen added a comment.
Landed as r279326.
https://reviews.llvm.org/D23705
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: timshen
Date: Fri Aug 19 16:20:13 2016
New Revision: 279326
URL: http://llvm.org/viewvc/llvm-project?rev=279326&view=rev
Log:
[GraphTraits] Make nodes_iterator dereference to NodeType*/NodeRef
Currently nodes_iterator may dereference to a NodeType* or a NodeType&. Make
them all dereferen
timshen added inline comments.
Comment at: include/clang/Analysis/CallGraph.h:219
@@ -217,5 +218,3 @@
}
- static clang::CallGraphNode &CGdereference(PairTy P) {
-return *(P.second);
- }
+ static clang::CallGraphNode *CGdereference(PairTy P) { return P.second; }
---
timshen created this revision.
timshen added a reviewer: dblaikie.
timshen added a subscriber: cfe-commits.
Currently nodes_iterator may dereference to a NodeType* or a NodeType&. Make
them all dereference to NodeType*, which is NodeRef later. Corresponding LLVM
change: D23704
https://reviews.l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278963: [GraphWriter] Change GraphWriter to use NodeRef in
GraphTraits (authored by timshen).
Changed prior to commit:
https://reviews.llvm.org/D23581?vs=68258&id=68406#toc
Repository:
rL LLVM
https
Author: timshen
Date: Wed Aug 17 15:02:38 2016
New Revision: 278963
URL: http://llvm.org/viewvc/llvm-project?rev=278963&view=rev
Log:
[GraphWriter] Change GraphWriter to use NodeRef in GraphTraits
Summary: Corresponding LLVM patch: D23580
Reviewers: dblaikie
Subscribers: cfe-commits
Differenti
timshen created this revision.
timshen added a reviewer: dblaikie.
timshen added a subscriber: cfe-commits.
Corresponding LLVM patch: D23580
https://reviews.llvm.org/D23581
Files:
lib/Serialization/ModuleManager.cpp
Index: lib/Serialization/ModuleManager.cpp
==
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278746: [ADT] Change PostOrderIterator to use NodeRef. NFC.
(authored by timshen).
Changed prior to commit:
https://reviews.llvm.org/D23523?vs=68070&id=68082#toc
Repository:
rL LLVM
https://reviews.
Author: timshen
Date: Mon Aug 15 16:27:56 2016
New Revision: 278746
URL: http://llvm.org/viewvc/llvm-project?rev=278746&view=rev
Log:
[ADT] Change PostOrderIterator to use NodeRef. NFC.
Summary: Corresponding LLVM change: D23522
Reviewers: dblaikie
Subscribers: cfe-commits
Differential Revisio
timshen created this revision.
timshen added a reviewer: dblaikie.
timshen added a subscriber: cfe-commits.
Corresponding LLVM change: D23522
https://reviews.llvm.org/D23523
Files:
include/clang/Analysis/CFG.h
include/clang/Analysis/CallGraph.h
Index: include/clang/Analysis/CallGraph.h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278156: [ADT] Change iterator_adaptor_base's default
template arguments to forward… (authored by timshen).
Changed prior to commit:
https://reviews.llvm.org/D23218?vs=66984&id=67408#toc
Repository:
r
Author: timshen
Date: Tue Aug 9 15:22:55 2016
New Revision: 278156
URL: http://llvm.org/viewvc/llvm-project?rev=278156&view=rev
Log:
[ADT] Change iterator_adaptor_base's default template arguments to forward more
underlying typedefs
Summary:
The corresponding LLVM change: D23217.
LazyVector::i
timshen created this revision.
timshen added reviewers: chandlerc, bkramer.
timshen added a subscriber: cfe-commits.
The corresponding LLVM change: D23217.
LazyVector::iterator breaks, because int isn't an iterator type.
Since iterator_adaptor_base shouldn't be blamed to break at the call to
iter
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277783: [ADT] Migrate DepthFirstIterator to use NodeRef
(authored by timshen).
Changed prior to commit:
https://reviews.llvm.org/D23147?vs=66745&id=66872#toc
Repository:
rL LLVM
https://reviews.llvm
Author: timshen
Date: Thu Aug 4 18:03:44 2016
New Revision: 277783
URL: http://llvm.org/viewvc/llvm-project?rev=277783&view=rev
Log:
[ADT] Migrate DepthFirstIterator to use NodeRef
Summary: The corresponding LLVM change is D23146.
Reviewers: dblaikie, chandlerc
Subscribers: cfe-commits
Differ
timshen created this revision.
timshen added reviewers: dblaikie, chandlerc.
timshen added a subscriber: cfe-commits.
The corresponding LLVM change is D23146.
https://reviews.llvm.org/D23147
Files:
include/clang/AST/StmtGraphTraits.h
include/clang/Analysis/Analyses/Dominators.h
include/cla
timshen added a comment.
...and r274396 to remove all of the checks for symbolic labels, which are not
generated by release builds, nor controlled by a runtime-flag.
Repository:
rL LLVM
http://reviews.llvm.org/D20499
___
cfe-commits mailing list
Author: timshen
Date: Fri Jul 1 17:50:00 2016
New Revision: 274396
URL: http://llvm.org/viewvc/llvm-project?rev=274396&view=rev
Log:
Removes CHECKs for symbolic label names (as Debug Clang will generate).
Differential Revision: http://reviews.llvm.org/D20499
Modified:
cfe/trunk/test/CodeGen
timshen added a comment.
Also committed r274387 to remove unnecessary CHECks. It seems to cause problems
in certain platforms.
Repository:
rL LLVM
http://reviews.llvm.org/D20499
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
Author: timshen
Date: Fri Jul 1 16:16:58 2016
New Revision: 274387
URL: http://llvm.org/viewvc/llvm-project?rev=274387&view=rev
Log:
Remove unncessary CHECKs from r274385
Modified:
cfe/trunk/test/CodeGen/temporary-lifetime.cpp
Modified: cfe/trunk/test/CodeGen/temporary-lifetime.cpp
URL:
ht
This revision was automatically updated to reflect the committed changes.
timshen marked an inline comment as done.
Closed by commit rL274385: [Temporary, Lifetime] Add lifetime marks for
temporaries (authored by timshen).
Changed prior to commit:
http://reviews.llvm.org/D20499?vs=62433&id=6254
Author: timshen
Date: Fri Jul 1 16:08:47 2016
New Revision: 274385
URL: http://llvm.org/viewvc/llvm-project?rev=274385&view=rev
Log:
[Temporary, Lifetime] Add lifetime marks for temporaries
With all MaterializeTemporaryExprs coming with a ExprWithCleanups, it's
easy to add correct lifetime.end m
timshen updated this revision to Diff 62433.
timshen added a comment.
Done. Added a new testcase to ensure the correct behavior with exceptions
turned on.
http://reviews.llvm.org/D20499
Files:
lib/CodeGen/CGCleanup.cpp
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFu
timshen added a comment.
Committed as r273312.
Repository:
rL LLVM
http://reviews.llvm.org/D20498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: timshen
Date: Tue Jun 21 15:29:17 2016
New Revision: 273312
URL: http://llvm.org/viewvc/llvm-project?rev=273312&view=rev
Log:
Re-commit "[Temporary] Add an ExprWithCleanups for each C++
MaterializeTemporaryExpr."
Since D21243 fixes relative clang-tidy tests.
This reverts commit a71d9fbd
timshen abandoned this revision.
timshen added a comment.
> I was wondering why we didn't created that Matcher: IgnoreImplicit
Actually you are right. There already exists a IgnoreImplict in clang-tidy and
I just switched to that.
Abandoning this patch.
Thanks!
http://reviews.llvm.org/D2124
timshen added a comment.
http://reviews.llvm.org/D21243 is committed. Let's do this again.
Repository:
rL LLVM
http://reviews.llvm.org/D20498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
Author: timshen
Date: Tue Jun 21 15:11:20 2016
New Revision: 273310
URL: http://llvm.org/viewvc/llvm-project?rev=273310&view=rev
Log:
Fix clang-tidy patterns to adapt to newly added ExprWithCleanups nodes.
Summary: This is a fix for the new ExprWithCleanups introduced by clang's
temporary variab
This revision was automatically updated to reflect the committed changes.
Closed by commit rL273310: Fix clang-tidy patterns to adapt to newly added
ExprWithCleanups nodes. (authored by timshen).
Changed prior to commit:
http://reviews.llvm.org/D21243?vs=60992&id=61434#toc
Repository:
rL LLV
timshen updated this revision to Diff 60992.
timshen added a comment.
Updated the patch to use ignorngImplicit/Expr::IgnoreImplicit matcher.
I think there is a systematic way to do this change:
Look at every ignoringImpCasts, ignoringParenCasts, ignoringParenImpCasts,
ignoringParens, and
Expr::
timshen updated this revision to Diff 60704.
timshen added a comment.
Done.
http://reviews.llvm.org/D21241
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/ASTMatchersTraversalTest.cpp
Index: uni
timshen added a comment.
In http://reviews.llvm.org/D21243#455999, @alexfh wrote:
> Does this just fix the tests broken with http://reviews.llvm.org/D20498 or
> have you looked at other checks that might be broken by
> http://reviews.llvm.org/D20498, but don't have relevant tests?
This just f
timshen reopened this revision.
timshen added a comment.
This revision is now accepted and ready to land.
Clang-tidy is broken by this change. Dependency is added to track the fix.
Repository:
rL LLVM
http://reviews.llvm.org/D20498
___
cfe-commit
timshen created this revision.
timshen added a reviewer: rsmith.
timshen added a subscriber: cfe-commits.
This is a fix for the new ExprWithCleanups introduced by clang's temporary
variable lifetime marks change.
http://reviews.llvm.org/D21243
Files:
clang-tidy/llvm/TwineLocalCheck.cpp
clan
timshen created this revision.
timshen added a reviewer: rsmith.
timshen added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
This is part of the fix of clang-tidy patterns to adapt to newly added
ExprWithCleanups node.
http://reviews.llvm.org/D21241
Files:
include/clang/ASTMat
Author: timshen
Date: Thu Jun 9 16:13:39 2016
New Revision: 272310
URL: http://llvm.org/viewvc/llvm-project?rev=272310&view=rev
Log:
Revert "[Temporary] Add an ExprWithCleanups for each C++
MaterializeTemporaryExpr."
This reverts r272296, since there are clang-tidy failures that appear to
be ca
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272296: [Temporary] Add an ExprWithCleanups for each C++
MaterializeTemporaryExpr. (authored by timshen).
Changed prior to commit:
http://reviews.llvm.org/D20498?vs=58694&id=60227#toc
Repository:
rL
Author: timshen
Date: Thu Jun 9 14:54:46 2016
New Revision: 272296
URL: http://llvm.org/viewvc/llvm-project?rev=272296&view=rev
Log:
[Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr.
These ExprWithCleanups are added for holding a RunCleanupsScope not
for destructor calls
timshen marked an inline comment as done.
timshen added a comment.
Ping? :)
http://reviews.llvm.org/D20498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
timshen added a comment.
I'm looking at some internal test failures caused by this patch.
http://reviews.llvm.org/D20499
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 115 matches
Mail list logo
