[PATCH] D158688: [Driver,ARM,AArch64] Ignore -mbranch-protection= diagnostics for assembler input

stuij added a comment. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158688/new/ https://reviews.llvm.org/D158688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. stuij marked an inline comment as done. Closed by commit rG479955a42a71: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections (authored by stuij). Changed prior t

[PATCH] D149443: [ARM] add Thumb-1 8-bit movs/adds relocations to LLVM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc49fbd2df7d: [ARM] add Thumb-1 8-bit movs/adds relocations to LLVM (authored by stuij). Changed prior to commit: https://reviews.llvm.org/D149443

[PATCH] D149443: [ARM] add Thumb-1 8-bit movs/adds relocations to LLVM

stuij updated this revision to Diff 533190. stuij added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149443/new/ https://reviews.llvm.org/D149443 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp llvm/include/

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

stuij marked an inline comment as done. stuij added a comment. Comment at: clang/test/Driver/arm-execute-only.c:1 -// RUN: not %clang -c -target thumbv6m-eabi -mexecute-only %s 2>&1 | \ +// RUN: %clang -c -### --target=thumbv6m-eabi -mexecute-only %s 2>&1 | \ +// RUN: FileCh

[PATCH] D149443: [ARM] add Thumb-1 8-bit movs/adds relocations to LLVM

stuij updated this revision to Diff 532685. stuij marked 3 inline comments as done. stuij added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149443/new/ https://reviews.llvm.org/D149443 Files: clang/lib/Driv

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

stuij updated this revision to Diff 532684. stuij added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149444/new/ https://reviews.llvm.org/D149444 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp clang/test/Dr

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

stuij added a comment. In D149444#4425134 , @stuij wrote: > - Moved the backend parts of this patch to D149443 > . Wrong Phab review -^ It should be D152795 . Repository: rG LLVM Gi

[PATCH] D149443: [ARM] add Thumb-1 8-bit movs/adds relocations to LLVM

stuij added a comment. In D149443#4403186 , @john.brawn wrote: > A few comments: > > - Please run clang-format on the patch (pre-merge is showing as failed due to > this) > - We should have a test to check that we're emitting the right relocation > (pr

[PATCH] D149443: [ARM] add Thumb-1 8-bit movs/adds relocations to LLVM

stuij updated this revision to Diff 531792. stuij marked 2 inline comments as done. stuij added a comment. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

stuij updated this revision to Diff 531787. stuij added a comment. - Moved the backend parts of this patch to D149443 . - Slightly tweaked the way we call the specific arch in the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

stuij added a comment. In D149444#4415306 , @MaskRay wrote: > Normally we implement the feature in llvm/ first, and the `clang/lib/Driver` > change should be the last patch. Yes good point. I won't commit it yet. For this feature we're using Phab as a

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

stuij updated this revision to Diff 530505. stuij marked 2 inline comments as done. stuij added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149444/new/ https://reviews.llvm.org/D149444 Files: clang/lib/Driv

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

stuij added a comment. This is going to be a very unhelpful comment. After looking through the changes, I don't have any comments to make, but I also don't feel comfortable to accept this revision as I don't feel to know enough about the front-end. CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

stuij added inline comments. Comment at: llvm/lib/Target/ARM/ARMSubtarget.cpp:194 + NoMovt = false; +assert(hasV6MOps() && "Cannot generate execute-only code for this target"); } tschuett wrote: > What happens in release mode? At the top you now claim

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

stuij updated this revision to Diff 525079. stuij added a comment. addressed review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149444/new/ https://reviews.llvm.org/D149444 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp clang/test/D

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

stuij updated this revision to Diff 524755. stuij added a comment. addressed review comments and updated tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149444/new/ https://reviews.llvm.org/D149444 Files: clang/lib/Driver/ToolChains/Arch/ARM

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

stuij added inline comments. Comment at: llvm/lib/Target/ARM/ARMSubtarget.cpp:434 // range otherwise. - return !NoMovt && hasV8MBaselineOps() && + return !NoMovt && hasV6MOps() && (isTargetWindows() || !OptMinSize || genExecuteOnly()); simonwallis2

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and adapt __bf16 to be arithmetic type

stuij added a comment. In D149573#4341323 , @codemzs wrote: > @stuij, as you initially introduced `__bf16` as a storage-type, your review > on this adjustment would be greatly appreciated. Sorry for the late reaction, was on holiday. Yes, I'll have a lo

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and introduce Bfloat16 arithmetic type.

stuij added a comment. I made a comment on the RFC to understand if we really need/want a new bfloat16 type. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149573/new/ https://reviews

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

stuij accepted this revision. stuij added a comment. Regarding this particular change, we at Arm are happy with the name change. I saw BFloat16 instead of BF16 as tech debt that we didn't get round to fixing. I do wonder if we need two bfloat implementations, but for that I'll leave a comment o

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

stuij created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. stuij requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. This patch moves the overall lower-bound arch res

[PATCH] D136919: [X86][RFC] Change mangle name of __bf16 from u6__bf16 to DF16b

stuij added a comment. FWIW, at Arm we decided to keep the old name mangling to minimise friction with existing code/libraries, but allow more operations with this same name-mangling. We also discussed with Red Hat and they were ok with this. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

stuij added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:52 + AArch64::AEK_RDM | AArch64::AEK_RCPC | AArch64::AEK_DOTPROD | + AArch64::AEK_SM4 | AArch64::AEK_SHA3 | AArch64::AEK_BF16| + AArch64::AEK_SH

[PATCH] D139608: [Clang][NFC] Add default `getBFloat16Mangling` impl

stuij added a comment. I went back and forth on this for a bit. There's a review outstanding to change the mangling name for X86: https://reviews.llvm.org/D136919 to align with the C++23 std::bfloat16_t issue from above. I settled on preferring to be conservative, and not risk at some point acc

[PATCH] D138488: [AArch64][clang] implement 2022 General Data-Processing instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. stuij marked an inline comment as done. Closed by commit rGcb261e30fbb1: [AArch64][clang] implement 2022 General Data-Processing instructions (authored by stuij). Repo

[PATCH] D138488: [AArch64][clang] implement 2022 General Data-Processing instructions

stuij marked an inline comment as done. stuij added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:11698 +//--- +// 2022 Architecture Extensions: General Data Processing (FEAT_V94_DP) +//--- tschuett wrote: > FEAT_CSSC or FEAT_V94_DP?

[PATCH] D138488: [AArch64][clang] implement 2022 General Data-Processing instructions

stuij updated this revision to Diff 477156. stuij marked an inline comment as done. stuij added a comment. renamed *v94-dp* to *cssc* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138488/new/ https://reviews.llvm.org/D138488 Files: clang/test/Dr

[PATCH] D138488: [AArch64][clang] implement 2022 General Data-Processing instructions

stuij marked an inline comment as done. stuij added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:11725 +: BaseTwoOperandRegReg, + Sched<[]> { + let Inst{11} = isMin; dmgreen wrote: > stuij wrote: > > dmgreen wrote: > > > C

[PATCH] D138488: [AArch64][clang] implement 2022 General Data-Processing instructions

stuij updated this revision to Diff 477146. stuij added a comment. addressed review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138488/new/ https://reviews.llvm.org/D138488 Files: clang/test/Driver/aarch64-cssc.c llvm/include/llvm/Su

[PATCH] D138488: [AArch64][clang] implement 2022 General Data-Processing instructions

stuij added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:11725 +: BaseTwoOperandRegReg, + Sched<[]> { + let Inst{11} = isMin; dmgreen wrote: > Can we make this WriteI, maybe. I think that would probably be the closest > s

[PATCH] D138488: [AArch64][clang] implement 2022 General Data-Processing instructions

stuij updated this revision to Diff 477143. stuij marked 6 inline comments as done. stuij added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138488/new/ https://reviews.llvm.org/D138488 Files: clang/test/Dri

[PATCH] D138488: [AArch64][clang] implement 2022 General Data-Processing instructions

stuij created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. stuij requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch implements the 2022 Architecture General Data-P

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG983f63f7f0d1: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

stuij marked an inline comment as done. stuij added inline comments. Comment at: llvm/include/llvm/Support/ARMTargetParser.def:127 + ARM::AEK_HWDIVTHUMB | ARM::AEK_DSP | ARM::AEK_CRC | ARM::AEK_RAS | + ARM::AEK_DOTPROD | ARM::AEK_BF16 | ARM::AEK_I8MM)) ARM_ARCH

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

stuij updated this revision to Diff 475489. stuij added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138010/new/ https://reviews.llvm.org/D138010 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Basic/

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

stuij marked an inline comment as done. stuij added inline comments. Comment at: llvm/include/llvm/Support/ARMTargetParser.def:127 + ARM::AEK_HWDIVTHUMB | ARM::AEK_DSP | ARM::AEK_CRC | ARM::AEK_RAS | + ARM::AEK_DOTPROD | ARM::AEK_BF16 | ARM::AEK_I8MM)) ARM_ARCH

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

stuij updated this revision to Diff 475454. stuij added a comment. make work with recent TargetParser changes (D137924 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138010/new/ https://reviews.llvm.org/D138010

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

stuij created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. stuij requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. For both ARM and AArch64 add support for specifyi

[PATCH] D136919: [X86][RFC] Change mangle name of __bf16 from u6__bf16 to DF16b

stuij added a comment. As for Arm/AAch64, we're still assessing the amount of pain we'd cause with the name change, but we don't have an issue with letting go of storage-only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136919/new/ https://revie

[PATCH] D135680: [clang][ARM] follow GCC behavior for defining __SOFTFP__

This revision was automatically updated to reflect the committed changes. stuij marked an inline comment as done. Closed by commit rG95bbe9a19308: [clang][ARM] follow GCC behavior for defining __SOFTFP__ (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D135680: [clang][ARM] follow GCC behavior for defining __SOFTFP__

stuij marked an inline comment as done. stuij added inline comments. Comment at: clang/test/Preprocessor/init-arm.c:404 +// is specified +// RUN: %clang_cc1 -E -dM -ffreestanding -triple=arm-none-linux-gnueabi -target-feature +soft-float -target-feature +soft-float-abi < /dev/

[PATCH] D135680: [clang][ARM] follow GCC behavior for defining __SOFTFP__

stuij updated this revision to Diff 468495. stuij added a comment. addressed review comment by adding test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135680/new/ https://reviews.llvm.org/D135680 Files: clang/lib/Basic/Targets/ARM.cpp clang/

[PATCH] D135680: [clang][ARM] follow GCC behavior for defining __SOFTFP__

stuij created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. stuij requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC behavior regarding defining __SOFTFP__ when (implicitly) specifying -mfloat-abi=so

[PATCH] D131555: [Clang] Propagate const context info when emitting compound literal

This revision was automatically updated to reflect the committed changes. stuij marked an inline comment as done. Closed by commit rG27cbfa7cc8cd: [Clang] Propagate const context info when emitting compound literal (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D131555: [Clang] Propagate const context info when emitting compound literal

stuij marked an inline comment as done. stuij added inline comments. Comment at: clang/test/CodeGen/const-init.c:2 +// setting strict FP behaviour in the run line below tests that the compiler +// does the right thing for global compound literals (compoundliteral test) +// RUN: %

[PATCH] D131555: [Clang] Propagate const context info when emitting compound literal

stuij updated this revision to Diff 453579. stuij added a comment. addressed review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131555/new/ https://reviews.llvm.org/D131555 Files: clang/lib/CodeGen/CGExprConstant.cpp clang/lib/CodeGe

[PATCH] D131555: [Clang] Propagate const context info when emitting compound literal

stuij marked 2 inline comments as done. stuij added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:2217 assert(E->isFileScope() && "not a file-scope compound literal expr"); - return tryEmitGlobalCompoundLiteral(*this, nullptr, E); + ConstantEmitter emitte

[PATCH] D131555: [Clang] Propagate const context info when emitting compound literal

stuij updated this revision to Diff 451794. stuij added a comment. addressed review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131555/new/ https://reviews.llvm.org/D131555 Files: clang/lib/CodeGen/CGExprConstant.cpp clang/lib/CodeGe

[PATCH] D131555: [Clang] Propagate const context info when emitting compound literal

stuij updated this revision to Diff 451783. stuij marked an inline comment as done. stuij added a comment. also added a comment above the runline. Initially thought it wouldn't be necessary as we're now doing a check, but I do agree that it's more clear to be specific about the cmdline arg. Re

[PATCH] D131555: [Clang] Propagate const context info when emitting compound literal

stuij updated this revision to Diff 451781. stuij added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131555/new/ https://reviews.llvm.org/D131555 Files: clang/lib/CodeGen/CGExprConstant.cpp clang/lib/CodeG

[PATCH] D131555: [Clang] Propagate const context info when emitting compound literal

stuij created this revision. Herald added a project: All. stuij requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes a crash when trying to emit a constant compound literal. For C++ Clang evaluates either casts or binary operat

[PATCH] D123763: [randstruct] Enforce using a designated init for a randomized struct

stuij added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:2171 if (Field == FieldEnd) { // We've run out of fields. We're done. @void Unfortunately this end of fields check will break the non-designated initializer check below. I GDB'ed

[PATCH] D121206: [AARCH64] ssbs should be enabled by default for cortex-x1, cortex-x1c, cortex-a77

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG352453569b2b: [AARCH64] ssbs should be enabled by default for cortex-x1, cortex-x1c, cortex… (authored by stuij). Repository: rG LLVM Github Monor

[PATCH] D121206: [AARCH64] ssbs should be enabled by default for cortex-x1, cortex-x1c, cortex-a77

stuij marked 2 inline comments as done. stuij added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:978 FeatureNEON, FeatureRCPC, FeaturePerfMon, FeatureSPE, FeatureFullFP16, FeatureDotProd]; l

[PATCH] D121206: [AARCH64] ssbs should be enabled by default for cortex-x1, cortex-x1c, cortex-a77

stuij marked 2 inline comments as done. stuij added inline comments. Comment at: clang/test/Preprocessor/aarch64-target-features.c:288 // CHECK-MCPU-CORTEX-A73: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-feature" "+v8a" "-target-feature" "+fp-armv8" "-target-feature" "+ne

[PATCH] D121206: [AARCH64] ssbs should be enabled by default for cortex-x1c

stuij updated this revision to Diff 414635. stuij added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121206/new/ https://reviews.llvm.org/D121206 Files: clang/test/Driver/aarch64-ssbs.c clang/test/Preproce

[PATCH] D121206: [AARCH64] ssbs should be enabled by default for cortex-x1c

stuij created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. stuij requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D119008: Add Cortex-X1C to Clang LLVM 14 release notes

stuij created this revision. stuij requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D119008 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst ==

[PATCH] D118380: Add info on PACBTI-M to the Clang release notes

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1adfbfcf39f9: Add info on PACBTI-M to the Clang release notes (aut

[PATCH] D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b1e844b69f1: [ARM] Add Cortex-X1C Support for Clang and LLVM (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117202/new/ https://reviews

[PATCH] D118380: Add info on PACBTI-M to the Clang release notes

stuij created this revision. stuij requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D118380 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst ==

[PATCH] D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM

stuij updated this revision to Diff 401936. stuij marked an inline comment as done. stuij added a comment. Herald added a subscriber: dexonsmith. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117202/new/ https://reviews.ll

[PATCH] D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM

stuij marked 2 inline comments as done. stuij added a comment. > Thanks for the update. Same(ish) questions for the Arm side. Otherwise this > LGTM Ai, thanks. Should have checked Arm as well. > Oh, also is there an ID for this CPU that is worth adding to > getHostCPUNameForARM in Host.cpp? Y

[PATCH] D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM

stuij updated this revision to Diff 401569. stuij marked an inline comment as done. stuij added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117202/new/ https://reviews.llvm.org/D117202 Files: clang/test/Dri

[PATCH] D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM

stuij marked 2 inline comments as done. stuij added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:205 +AARCH64_CPU_NAME("cortex-x1c", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false, + (AArch64::AEK_RAS)) AARCH64_CPU_NAME("cortex-x2", AR

[PATCH] D117202: [ARM] Add Cortex-X1C Support for Clang and LLVM

stuij created this revision. Herald added subscribers: hiraditya, kristof.beyls. stuij requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch upstreams support for the Arm-v8 Cortex-X1C processor for AArch64 and ARM.

[PATCH] D116509: [Builtins] Add missing the macro 'y' description in comments

stuij accepted this revision. stuij added a comment. This revision is now accepted and ready to land. LGTM, thanks! Nit: perhaps make the commit message a little bit clearer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116509/new/ https://review

[PATCH] D115507: Add PACBTI-M support to LLVM release notes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfbf489cd1b4b: Add PACBTI-M support to LLVM release notes. (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D115507: Add PACBTI-M support to LLVM release notes.

stuij updated this revision to Diff 393434. stuij added a comment. removed accidentally included Clang release notes draft Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115507/new/ https://reviews.llvm.org/D115507 Files: llvm/docs/ReleaseNotes.r

[PATCH] D115507: Add PACBTI-M support to LLVM release notes.

stuij created this revision. stuij requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Clang release note changes will be added once the last PACBTI-M command line patch lands. Repository: rG LLVM Github Monorepo https://

[PATCH] D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT

This revision was automatically updated to reflect the committed changes. Closed by commit rGbfe07195bb1f: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115140/n

[PATCH] D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT

stuij updated this revision to Diff 393096. stuij added a comment. rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115140/new/ https://reviews.llvm.org/D115140 Files: clang/lib/Basic/Targets/ARM.cpp clang/test/Preprocessor/arm-target-fe

[PATCH] D112431: [ARM][clang] Define feature test macro for the PACBTI-M extension

This revision was automatically updated to reflect the committed changes. Closed by commit rGe32b818db187: [ARM][clang] Define feature test macro for the PACBTI-M extension (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112431/new

[PATCH] D112430: [ARM][libunwind] add PACBTI-M support for libunwind

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6d0b851f854: [ARM][libunwind] add PACBTI-M support for libunwind (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT

stuij added a comment. @danielkiss Yes that needs to be addressed, but we are doing that in another patch that will (hopefully) cover all permutations of architecture and branch protection values on both the cmdline and as function attributes. So this patch is just about not having logic in the

[PATCH] D115141: [ARM][clang] Add back branch protection tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG53154a83aee0: [ARM][clang] Add back branch protection tests (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115141/new/ https://reviews.l

[PATCH] D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT

stuij updated this revision to Diff 392021. stuij added a comment. another tickle Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115140/new/ https://reviews.llvm.org/D115140 Files: clang/lib/Basic/Targets/ARM.cpp clang/test/Preprocessor/arm-tar

[PATCH] D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT

stuij updated this revision to Diff 392013. stuij added a comment. tickling the commit so the buildbot picks up the dependency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115140/new/ https://reviews.llvm.org/D115140 Files: clang/lib/Basic/Targ

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

stuij added a comment. @erichkeane : thanks so much for going through the trouble to see what the problem is! I've put up a fix with your suggested change at https://reviews.llvm.org/D115141 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112421/new/

[PATCH] D112427: [ARM] Implement setjmp BTI placement for PACBTI-M

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0fbb17458a01: [ARM] Implement setjmp BTI placement for PACBTI-M (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D115141: [ARM][clang] Add back branch protection tests

stuij created this revision. Herald added a subscriber: kristof.beyls. stuij requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When committing the PACBTI-M frontend support patch (https://reviews.llvm.org/D112421), the tests in arm-invalid-br

[PATCH] D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT

stuij created this revision. Herald added a subscriber: kristof.beyls. stuij requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When using -mbranch-protection=pac-ret+b-key, macro __ARM_FEATURE_PAC_DEFAULT should still have the value correspon

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

stuij added a comment. Yes, pushed a temporary fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112421/new/ https://reviews.llvm.org/D112421 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D112422: [clang][ARM] emit PACBTI-M feature defines

This revision was automatically updated to reflect the committed changes. Closed by commit rGab2611d0998c: [clang][ARM] emit PACBTI-M feature defines (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112422/new/ https://reviews.llvm

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe3b2f0226bc0: [clang][ARM] PACBTI-M frontend support (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

stuij updated this revision to Diff 390958. stuij added a comment. rebased and resolved merge conflict Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112421/new/ https://reviews.llvm.org/D112421 Files: clang/include/clang/Basic/DiagnosticDriverKi

[PATCH] D112427: [ARM] Implement setjmp BTI placement for PACBTI-M

stuij updated this revision to Diff 390633. stuij added a comment. slight rewording Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112427/new/ https://reviews.llvm.org/D112427 Files: clang/docs/ClangCommandLineReference.rst clang/include/clang/

[PATCH] D112431: [ARM][clang] Define feature test macro for the PACBTI-M extension

stuij updated this revision to Diff 390340. stuij added a comment. reuploading after rebase to resolve patch apply failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112431/new/ https://reviews.llvm.org/D112431 Files: clang/lib/Basic/Targets/

[PATCH] D112430: [ARM][libunwind] add PACBTI-M support for libunwind

stuij updated this revision to Diff 390333. stuij added a comment. uploading after rebase as per reviewer request (no changes in the patch itself) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112430/new/ https://reviews.llvm.org/D112430 Files:

[PATCH] D112422: [clang][ARM] emit PACBTI-M feature defines

stuij updated this revision to Diff 390320. stuij added a comment. obeying clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112422/new/ https://reviews.llvm.org/D112422 Files: clang/lib/Basic/Targets/ARM.cpp clang/test/Preprocessor/a

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

stuij updated this revision to Diff 390316. stuij added a comment. minor clang-format conformance changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112421/new/ https://reviews.llvm.org/D112421 Files: clang/include/clang/Basic/DiagnosticDrive

[PATCH] D112420: [clang][ARM] PACBTI-M assembly support

stuij updated this revision to Diff 390314. stuij marked 2 inline comments as done. stuij added a comment. addressed review comment and clang-format suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112420/new/ https://reviews.llvm.org/D112

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

stuij updated this revision to Diff 390021. stuij added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112421/new/ https://reviews.llvm.org/D112421 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td c

[PATCH] D112430: [ARM][libunwind] add PACBTI-M support for libunwind

stuij updated this revision to Diff 389481. stuij added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112430/new/ https://reviews.llvm.org/D112430 Files: clang/lib/Headers/unwind.h libunwind/include/libunwind

[PATCH] D112427: [ARM] Implement setjmp BTI placement for PACBTI-M

stuij updated this revision to Diff 388891. stuij added a comment. Herald added subscribers: cfe-commits, dang. Herald added a project: clang. addressed review comments, namely adding a commandline argument, `-mno-bti-at-return-twice`, to not place a bti instruction after a setjmp call. Reposit

[PATCH] D112430: [ARM][libunwind] add PACBTI-M support for libunwind

stuij updated this revision to Diff 387237. stuij added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112430/new/ https://reviews.llvm.org/D112430 Files: clang/lib/Headers/unwind.h libunwind/include/libunwi

[PATCH] D112431: [ARM][clang] Define feature test macro for the PACBTI-M extension

stuij updated this revision to Diff 386195. stuij added a comment. addressing review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112431/new/ https://reviews.llvm.org/D112431 Files: clang/lib/Basic/Targets/ARM.cpp clang/lib/Basic/Targ

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

stuij updated this revision to Diff 384724. stuij added a comment. removed stray block duplicating the behaviour of CollectARMPACBTIOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112421/new/ https://reviews.llvm.org/D112421 Files: clang/i

[PATCH] D112420: [clang][ARM] PACBTI-M assembly support

stuij marked 6 inline comments as done. stuij added a comment. A slight amendment to the description of the just uploaded patch amendment: PACG has also been made conditional. Comment at: llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp:6441 + Mnemonic == "csetm" || +

  1   2   3   >