[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

2023-08-18 Thread Thurston Dang via Phabricator via cfe-commits
thurston added a comment. In D156821#4600086 , @MaskRay wrote: > Failed Tests (4): > LLVM :: CodeGen/RISCV/rvv/fixed-vectors-int.ll > LLVM :: CodeGen/SystemZ/ctpop-01.ll > LLVM :: MC/ARM/basic-thumb2-instructions.s > LLVM :: tools/llvm-r

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

2023-08-18 Thread Thurston Dang via Phabricator via cfe-commits
thurston added a comment. This patch might have broke the buildbots, starting with when it was first built in https://lab.llvm.org/buildbot/#/builders/85/builds/18390 /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/libcxx_build_ubsan/include/c++/v1/stdlib.h:114:25: runtime error: negation of

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

2023-04-21 Thread Thurston Dang via Phabricator via cfe-commits
thurston added a comment. Thanks Aaron and Jorge for the quick revert and replies! :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148276/new/ https://reviews.llvm.org/D148276 ___ cfe-commits mailing l

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

2023-04-21 Thread Thurston Dang via Phabricator via cfe-commits
thurston added a comment. I think this change is triggering an error on a buildbot (https://lab.llvm.org/buildbot/#/builders/37/builds/21631/steps/20/logs/stdio): /b/sanitizer-x86_64-linux/build/llvm-project/clang/lib/Analysis/UnsafeBufferUsage.cpp:1348:45: error: cast from 'const clang::AST

[PATCH] D147016: [PowerPC] Add function pointer alignment to DataLayout

2023-04-18 Thread Thurston Dang via Phabricator via cfe-commits
thurston added a comment. Ah, I just noticed you had a follow-up commit (https://reviews.llvm.org/rG0236564771b432ebf050144eda4ef4b7424db8c3). I'm re-running the tests/build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147016/new/ https://revie

[PATCH] D147016: [PowerPC] Add function pointer alignment to DataLayout

2023-04-18 Thread Thurston Dang via Phabricator via cfe-commits
thurston added a comment. This is causing buildbot failures e.g., https://lab.llvm.org/buildbot/#/builders/5/builds/33084: TEST 'lld :: ELF/lto/ppc.ll' FAILED ... ld.lld: /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/CodeGen/MachineFu