[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

2019-06-18 Thread Thomas Manceau via Phabricator via cfe-commits
Blackhart updated this revision to Diff 205354. Blackhart marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63324 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt clang-tools-extra/clang-tidy/modernize/Mod

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

2019-06-18 Thread Thomas Manceau via Phabricator via cfe-commits
Blackhart updated this revision to Diff 205341. Blackhart marked 3 inline comments as done. Blackhart added a comment. Remove "//this check//" from documentation and release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63324 Files: clang-too

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

2019-06-18 Thread Thomas Manceau via Phabricator via cfe-commits
Blackhart added a comment. Hello, I've updated the documentation with more informations about the transformations the check do. I'm not very confident in writing documentation in english. Please review it and submit me your change requests. CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

2019-06-18 Thread Thomas Manceau via Phabricator via cfe-commits
Blackhart updated this revision to Diff 205331. Blackhart added a comment. - Reorder release note changes - Update documentation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63324 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt c

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

2019-06-15 Thread Thomas Manceau via Phabricator via cfe-commits
Blackhart updated this revision to Diff 204932. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63324 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt clang-tools-extra/clang-tidy/modernize/ModernizeTidyModule.cpp clang-tools-extra/cla

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

2019-06-15 Thread Thomas Manceau via Phabricator via cfe-commits
Blackhart updated this revision to Diff 204930. Blackhart marked 2 inline comments as done. Blackhart added a comment. - Update releasenotes - Add documentation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63324 Files: clang-tools-extra/clang-tid

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

2019-06-15 Thread Thomas Manceau via Phabricator via cfe-commits
Blackhart updated this revision to Diff 204926. Blackhart marked an inline comment as done. Blackhart added a comment. - Remove unnessecary empty line - Use "array.size()" instead of numerical constant CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

2019-06-15 Thread Thomas Manceau via Phabricator via cfe-commits
Blackhart updated this revision to Diff 204925. Blackhart marked an inline comment as done. Blackhart added a comment. Use "std::array" instead of the raw array CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63324 Files: clang-tools-extra/clang-tid

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

2019-06-15 Thread Thomas Manceau via Phabricator via cfe-commits
Blackhart updated this revision to Diff 204924. Blackhart marked an inline comment as done. Blackhart added a comment. Remove "auto" keyword when type is created from same statement CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63324 Files: clang-

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

2019-06-15 Thread Thomas Manceau via Phabricator via cfe-commits
Blackhart updated this revision to Diff 204922. Blackhart added a comment. Add override keyword to the destructor and set it as "= default" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63324 Files: clang-tools-extra/clang-tidy/modernize/CMakeList

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

2019-06-15 Thread Thomas Manceau via Phabricator via cfe-commits
Blackhart updated this revision to Diff 204920. Blackhart added a comment. Revert "Modernize memcpy only if C++20 is enabled" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63324 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt clang-

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

2019-06-15 Thread Thomas Manceau via Phabricator via cfe-commits
Blackhart added a comment. In D63324#1543782 , @xbolva00 wrote: > This might not be currently ideal recommendation since std::copy produces > memmove with -O3. What do you recommend ? There is a way to disable this modernization if the user compile with

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

2019-06-15 Thread Thomas Manceau via Phabricator via cfe-commits
Blackhart added a comment. In D63324#1543706 , @lebedev.ri wrote: > In D63324#1543626 , @Blackhart wrote: > > > In D63324#1543609 , @lebedev.ri > > wrote: > > > > > In D6332

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

2019-06-14 Thread Thomas Manceau via Phabricator via cfe-commits
Blackhart added a comment. In D63324#1543609 , @lebedev.ri wrote: > In D63324#1543607 , @Blackhart wrote: > > > Modernize memcpy only if C++20 is enabled > > > ... why? > This is also missing documentation,releasen

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

2019-06-14 Thread Thomas Manceau via Phabricator via cfe-commits
Blackhart updated this revision to Diff 204770. Blackhart added a comment. Modernize memcpy only if C++20 is enabled CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63324 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt clang-tools-ext

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

2019-06-14 Thread Thomas Manceau via Phabricator via cfe-commits
Blackhart updated this revision to Diff 204768. Blackhart marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63324 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt clang-tools-extra/clang-tidy/modernize/Mod

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

2019-06-14 Thread Thomas Manceau via Phabricator via cfe-commits
Blackhart updated this revision to Diff 204759. Blackhart added a comment. Fix file comments typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63324 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt clang-tools-extra/clang-tidy/moder

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

2019-06-14 Thread Thomas Manceau via Phabricator via cfe-commits
Blackhart updated this revision to Diff 204758. Blackhart added a comment. Herald added a subscriber: jsji. Add missing "override" keywords CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63324 Files: clang-tools-extra/clang-tidy/modernize/CMakeList

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

2019-06-14 Thread Thomas Manceau via Phabricator via cfe-commits
Blackhart updated this revision to Diff 204757. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63324/new/ https://reviews.llvm.org/D63324 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt clang-tools-extra/clang-tidy/modernize/ModernizeTidyModule.cpp clang-tools-extra/cla

[PATCH] D63324: [clang-tidy] Replace memcpy by std::copy

2019-06-14 Thread Thomas Manceau via Phabricator via cfe-commits
Blackhart created this revision. Blackhart created this object with edit policy "Only User: Blackhart (Thomas Manceau)". Blackhart added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. This patch will: - replace all occurrenc