[clang] [docs] Minor fix to outdated example in LibTooling tutorial (PR #67262)

2025-11-20 Thread Thibault Monnier via cfe-commits
Thibault-Monnier wrote: Hey @hhkit, this PR seems to be outdated. I believe it should be closed. https://github.com/llvm/llvm-project/pull/67262 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang] [CIR] Upstream CIR codegen for undef x86 builtins (PR #167945)

2025-11-19 Thread Thibault Monnier via cfe-commits
https://github.com/Thibault-Monnier updated https://github.com/llvm/llvm-project/pull/167945 >From e2cc7e2adc9ef9c433c5f69fe51d6cb03ed024a7 Mon Sep 17 00:00:00 2001 From: Thibault-Monnier Date: Thu, 13 Nov 2025 21:15:11 +0100 Subject: [PATCH 1/6] Upstream CIR codegen for undef x86 builtins ---

[clang] [CIR] Upstream CIR codegen for mxcsr x86 builtins (PR #167948)

2025-11-19 Thread Thibault Monnier via cfe-commits
Thibault-Monnier wrote: Thanks for the patch! I was working on that issue. https://github.com/llvm/llvm-project/pull/167948 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix build breakage from: #167948 (PR #168781)

2025-11-19 Thread Thibault Monnier via cfe-commits
https://github.com/Thibault-Monnier unassigned https://github.com/llvm/llvm-project/pull/168781 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix build breakage from: #167948 (PR #168781)

2025-11-19 Thread Thibault Monnier via cfe-commits
Thibault-Monnier wrote: Please proceed, I haven't actually reverted it, more of a misclick. https://github.com/llvm/llvm-project/pull/168781 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [CIR] Upstream CIR codegen for mxcsr x86 builtins (PR #167948)

2025-11-19 Thread Thibault Monnier via cfe-commits
https://github.com/Thibault-Monnier closed https://github.com/llvm/llvm-project/pull/167948 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream CIR codegen for undef x86 builtins (PR #167945)

2025-11-19 Thread Thibault Monnier via cfe-commits
Thibault-Monnier wrote: @andykaylor @bcardosolopes I am done. https://github.com/llvm/llvm-project/pull/167945 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream CIR codegen for undef x86 builtins (PR #167945)

2025-11-19 Thread Thibault Monnier via cfe-commits
https://github.com/Thibault-Monnier updated https://github.com/llvm/llvm-project/pull/167945 >From e2cc7e2adc9ef9c433c5f69fe51d6cb03ed024a7 Mon Sep 17 00:00:00 2001 From: Thibault-Monnier Date: Thu, 13 Nov 2025 21:15:11 +0100 Subject: [PATCH 1/5] Upstream CIR codegen for undef x86 builtins ---

[clang] [CIR] Upstream CIR codegen for undef x86 builtins (PR #167945)

2025-11-19 Thread Thibault Monnier via cfe-commits
https://github.com/Thibault-Monnier updated https://github.com/llvm/llvm-project/pull/167945 >From e2cc7e2adc9ef9c433c5f69fe51d6cb03ed024a7 Mon Sep 17 00:00:00 2001 From: Thibault-Monnier Date: Thu, 13 Nov 2025 21:15:11 +0100 Subject: [PATCH 1/6] Upstream CIR codegen for undef x86 builtins ---

[clang] [CIR] Upstream CIR codegen for undef x86 builtins (PR #167945)

2025-11-19 Thread Thibault Monnier via cfe-commits
https://github.com/Thibault-Monnier updated https://github.com/llvm/llvm-project/pull/167945 >From e2cc7e2adc9ef9c433c5f69fe51d6cb03ed024a7 Mon Sep 17 00:00:00 2001 From: Thibault-Monnier Date: Thu, 13 Nov 2025 21:15:11 +0100 Subject: [PATCH 1/4] Upstream CIR codegen for undef x86 builtins ---

[clang] [CIR] Upstream CIR codegen for undef x86 builtins (PR #167945)

2025-11-19 Thread Thibault Monnier via cfe-commits
https://github.com/Thibault-Monnier updated https://github.com/llvm/llvm-project/pull/167945 >From e2cc7e2adc9ef9c433c5f69fe51d6cb03ed024a7 Mon Sep 17 00:00:00 2001 From: Thibault-Monnier Date: Thu, 13 Nov 2025 21:15:11 +0100 Subject: [PATCH 1/4] Upstream CIR codegen for undef x86 builtins ---

[clang] [CIR] Upstream CIR codegen for undef x86 builtins (PR #167945)

2025-11-19 Thread Thibault Monnier via cfe-commits
Thibault-Monnier wrote: I am in the process of adding the tests I forgot to upstream. This is also the case for the mxcsr builtins PR. https://github.com/llvm/llvm-project/pull/167945 ___ cfe-commits mailing list [email protected] https://lis

[clang] [CIR] Upstream CIR codegen for mxcsr x86 builtins (PR #167948)

2025-11-19 Thread Thibault Monnier via cfe-commits
Thibault-Monnier wrote: Sorry, I realised I forgot to include some tests from the incubator. I'll take care of that when I can. https://github.com/llvm/llvm-project/pull/167948 ___ cfe-commits mailing list [email protected] https://lists.llvm

[clang] [CIR] Upstream CIR codegen for undef x86 builtins (PR #167945)

2025-11-19 Thread Thibault Monnier via cfe-commits
Thibault-Monnier wrote: Sorry, I realised I forgot to include some tests from ghe incubator. I'll take care of that when I can. https://github.com/llvm/llvm-project/pull/167945 ___ cfe-commits mailing list [email protected] https://lists.llvm

[clang] [CIR] X86 vector fcmp-sse vector builtins (PR #167125)

2025-11-08 Thread Thibault Monnier via cfe-commits
Thibault-Monnier wrote: @woruyu, I believe LLVM code style imposes camelCase for variables and parameters, hence the "As part of the migration process, you may need to update the code to conform to the coding standards used in the LLVM project" that Andy Kaylor wrote. https://github.com/llvm/

[clang] [clang][HLSL] Fix include guard typo in hlsl_compat_overloads.h (PR #164540)

2025-11-01 Thread Thibault Monnier via cfe-commits
Thibault-Monnier wrote: @llvm-beanz @cor3ntin https://github.com/llvm/llvm-project/pull/164540 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Remove GtestMatchers and GtestMatchersTest (PR #162524)

2025-10-18 Thread Thibault Monnier via cfe-commits
https://github.com/Thibault-Monnier edited https://github.com/llvm/llvm-project/pull/162524 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Remove GtestMatchers and GtestMatchersTest (PR #162524)

2025-10-18 Thread Thibault Monnier via cfe-commits
Thibault-Monnier wrote: @localspook https://github.com/llvm/llvm-project/pull/162524 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Remove GtestMatchers and GtestMatchersTest (PR #162524)

2025-10-17 Thread Thibault Monnier via cfe-commits
Thibault-Monnier wrote: Do these messages mean this PR is the source of the issue? https://github.com/llvm/llvm-project/pull/162524 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Remove GtestMatchers and GtestMatchersTest (PR #162524)

2025-10-17 Thread Thibault Monnier via cfe-commits
Thibault-Monnier wrote: Thanks @AaronBallman for the review! Please merge this PR on my behalf. https://github.com/llvm/llvm-project/pull/162524 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang] [llvm] Remove GtestMatchers and GtestMatchersTest (PR #162524)

2025-10-08 Thread Thibault Monnier via cfe-commits
https://github.com/Thibault-Monnier created https://github.com/llvm/llvm-project/pull/162524 This PR removes the unused GtestMatchers and GtestMatchersTest, fixing issue #161939. >From f5fd20eead09a4c19040f9ec88eafa63261b9ceb Mon Sep 17 00:00:00 2001 From: Thibault-Monnier Date: Wed, 8 Oct 20

[clang] [clang] Inline static helper function in `Compilation.cpp` (PR #152875)

2025-08-09 Thread Thibault Monnier via cfe-commits
Thibault-Monnier wrote: @Sirraide, I do not really know who I should ping to review. Could you please help? Thanks! https://github.com/llvm/llvm-project/pull/152875 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin

[clang] [clang] Inline static helper function in `Compilation.cpp` (PR #152875)

2025-08-09 Thread Thibault Monnier via cfe-commits
https://github.com/Thibault-Monnier updated https://github.com/llvm/llvm-project/pull/152875 >From 2df0db4032883750a75d5615bed4c011561c1c2c Mon Sep 17 00:00:00 2001 From: Thibault-Monnier Date: Sat, 9 Aug 2025 20:27:06 +0200 Subject: [PATCH] Inline `InputsOk` function in `clang/lib/Driver/Comp

[clang] [clang] Inline static helper function in `Compilation.cpp` (PR #152875)

2025-08-09 Thread Thibault Monnier via cfe-commits
https://github.com/Thibault-Monnier edited https://github.com/llvm/llvm-project/pull/152875 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Inline static helper function in `Compilation.cpp` (PR #152875)

2025-08-09 Thread Thibault Monnier via cfe-commits
Thibault-Monnier wrote: Hey, this is my first PR on the llvm-project. I hope it respects the llvm contribution guidelines. Feedback is welcome. https://github.com/llvm/llvm-project/pull/152875 ___ cfe-commits mailing list [email protected] ht

[clang] [clang] Inline static helper function in `Compilation.cpp` (PR #152875)

2025-08-09 Thread Thibault Monnier via cfe-commits
https://github.com/Thibault-Monnier edited https://github.com/llvm/llvm-project/pull/152875 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Inline helper function in `Compilation.cpp` (PR #152875)

2025-08-09 Thread Thibault Monnier via cfe-commits
https://github.com/Thibault-Monnier edited https://github.com/llvm/llvm-project/pull/152875 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Inline helper function in `Compilation.cpp` (PR #152875)

2025-08-09 Thread Thibault Monnier via cfe-commits
https://github.com/Thibault-Monnier edited https://github.com/llvm/llvm-project/pull/152875 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Inline helper function in `clang/lib/Driver/Compilation.cpp` (PR #152875)

2025-08-09 Thread Thibault Monnier via cfe-commits
https://github.com/Thibault-Monnier edited https://github.com/llvm/llvm-project/pull/152875 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Inline `InputsOk` function in `clang/lib/Driver/Compilation.cpp` (PR #152875)

2025-08-09 Thread Thibault Monnier via cfe-commits
https://github.com/Thibault-Monnier edited https://github.com/llvm/llvm-project/pull/152875 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Inline `InputsOk` function in `clang/lib/Driver/Compilation.cpp` (PR #152875)

2025-08-09 Thread Thibault Monnier via cfe-commits
https://github.com/Thibault-Monnier created https://github.com/llvm/llvm-project/pull/152875 This PR inlines the InputsOk function in clang Compilation.cpp driver, because it was just a simple function call and was called only once. In addition, inlining it allows removing the double negation.