[PATCH] D53125: Detect Clear Linux and apply Clear's default linker options

2018-10-15 Thread Thiago Macieira via Phabricator via cfe-commits
thiagomacieira updated this revision to Diff 169779. thiagomacieira added a comment. Update detection: as of Clear Linux 25620, /usr/lib/os-relaese contains ID_LIKE=clear-linux-os, which allows detecting not only Clear itself, but also Linux distributions derived from it (Clear Linux mixes). h

[PATCH] D53125: Detect Clear Linux and apply Clear's default linker options

2018-10-15 Thread Thiago Macieira via Phabricator via cfe-commits
thiagomacieira marked an inline comment as done. thiagomacieira added inline comments. Comment at: lib/Driver/Distro.cpp:148 +for (StringRef Line : Lines) + if (Version == Distro::UnknownDistro && Line.startswith("ID=")) +Version = llvm::StringSwitch(Line.substr(

[PATCH] D53125: Detect Clear Linux and apply Clear's default linker options

2018-10-11 Thread Thiago Macieira via Phabricator via cfe-commits
thiagomacieira updated this revision to Diff 169236. thiagomacieira added a comment. Updated to check for /etc/os-release first and /usr/lib/os-release if that fails https://reviews.llvm.org/D53125 Files: include/clang/Driver/Distro.h lib/Driver/Distro.cpp lib/Driver/ToolChains/Linux.cpp

[PATCH] D53125: Detect Clear Linux and apply Clear's default linker options

2018-10-11 Thread Thiago Macieira via Phabricator via cfe-commits
thiagomacieira added inline comments. Comment at: lib/Driver/Distro.cpp:139 + File = VFS.getBufferForFile("/usr/lib/os-release"); + if (File) { mgorny wrote: > Technically speaking, the spec says you are supposed to read > `/etc/os-release` first and fall ba

[PATCH] D53125: Detect Clear Linux and apply Clear's default linker options

2018-10-10 Thread Thiago Macieira via Phabricator via cfe-commits
thiagomacieira updated this revision to Diff 169152. https://reviews.llvm.org/D53125 Files: include/clang/Driver/Distro.h lib/Driver/Distro.cpp lib/Driver/ToolChains/Linux.cpp unittests/Driver/DistroTest.cpp Index: unittests/Driver/DistroTest.cpp =

[PATCH] D53125: Detect Clear Linux and apply Clear's default linker options

2018-10-10 Thread Thiago Macieira via Phabricator via cfe-commits
thiagomacieira updated this revision to Diff 169151. thiagomacieira added a comment. Oops, add the missing portion of the unit test (the part that actually tests). https://reviews.llvm.org/D53125 Files: include/clang/Driver/Distro.h lib/Driver/Distro.cpp lib/Driver/ToolChains/Linux.cpp

[PATCH] D53125: Detect Clear Linux and apply Clear's default linker options

2018-10-10 Thread Thiago Macieira via Phabricator via cfe-commits
thiagomacieira created this revision. thiagomacieira added reviewers: mgorny, erichkeane. Herald added subscribers: cfe-commits, srhines. /usr/lib/os-release is the official path of /etc/os-release (the latter is usually a symlink to the former) Repository: rC Clang https://reviews.llvm.org/

[PATCH] D53042: [X86] Remove FeatureRTM from Skylake processor list

2018-10-09 Thread Thiago Macieira via Phabricator via cfe-commits
thiagomacieira updated this revision to Diff 168936. thiagomacieira added a comment. Added test update https://reviews.llvm.org/D53042 Files: lib/Basic/Targets/X86.cpp test/Preprocessor/predefined-arch-macros.c Index: test/Preprocessor/predefined-arch-macros.c =

[PATCH] D53042: [X86] Remove FeatureRTM from Skylake processor list

2018-10-09 Thread Thiago Macieira via Phabricator via cfe-commits
thiagomacieira added inline comments. Comment at: lib/Basic/Targets/X86.cpp:169 setFeatureEnabledImpl(Features, "mpx", true); if (Kind != CK_SkylakeServer) // SKX inherits all SKL features, except SGX setFeatureEnabledImpl(Features, "sgx", true);

[PATCH] D53042: [X86] Remove FeatureRTM from Skylake processor list

2018-10-09 Thread Thiago Macieira via Phabricator via cfe-commits
thiagomacieira created this revision. thiagomacieira added reviewers: erichkeane, craig.topper. Herald added a subscriber: cfe-commits. craig.topper retitled this revision from "Remove FeatureRTM from Skylake processor list" to "[X86] Remove FeatureRTM from Skylake processor list". There are a LO

[PATCH] D51510: Move AESNI generation to Skylake and Goldmont

2018-08-31 Thread Thiago Macieira via Phabricator via cfe-commits
thiagomacieira added a comment. See https://reviews.llvm.org/D51565 Repository: rC Clang https://reviews.llvm.org/D51510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51510: Move AESNI generation to Skylake and Goldmont

2018-08-31 Thread Thiago Macieira via Phabricator via cfe-commits
thiagomacieira added a comment. Sure. Hadn't seen that file. Repository: rC Clang https://reviews.llvm.org/D51510 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51510: Move AESNI generation to Skylake and Goldmont

2018-08-30 Thread Thiago Macieira via Phabricator via cfe-commits
thiagomacieira created this revision. thiagomacieira added reviewers: erichkeane, GBuella. Herald added a subscriber: cfe-commits. The instruction set first appeared with Westmere, but not all processors in that and the next few generations have the instructions. According to Wikipedia[1], the fir