[PATCH] D141177: [Clang] Don't tell people to place _Alignas on a struct in diagnostics

2023-08-21 Thread Theodore Luo Wang via Phabricator via cfe-commits
theo-lw updated this revision to Diff 552181. theo-lw added a comment. Ran clang-format on this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141177/new/ https://reviews.llvm.org/D141177 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/AttributeCommonInfo.h clang/lib

[PATCH] D141177: [Clang] Don't tell people to place _Alignas on a struct in diagnostics

2023-08-21 Thread Theodore Luo Wang via Phabricator via cfe-commits
theo-lw updated this revision to Diff 552061. theo-lw added a comment. Herald added a subscriber: jdoerfert. Rebased on the main branch & addressed comments. Added additional test case for C++ alignas. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141177/new/ https://reviews.llvm.org/D

[PATCH] D141177: [Clang] Don't tell people to place _Alignas on a struct in diagnostics

2023-08-16 Thread Theodore Luo Wang via Phabricator via cfe-commits
theo-lw added a comment. In D141177#4592158 , @aaron.ballman wrote: > @theo-lw -- are you planning to continue working on this review? (It's okay > if you're not, I'm more wondering if I should remove you as the assignee on > https://github.com/llvm/ll

[PATCH] D141177: [Clang] Don't tell people to place _Alignas on a struct in diagnostics

2023-01-07 Thread Theodore Luo Wang via Phabricator via cfe-commits
theo-lw updated this revision to Diff 487119. theo-lw added a comment. Didn't realize this test was failing so I've updated it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141177/new/ https://reviews.llvm.org/D141177 Files: clang/lib/Sema/SemaDecl.cpp clang/test/C/drs/dr4xx.c c

[PATCH] D141177: [Clang] Don't tell people to place _Alignas on a struct in diagnostics

2023-01-07 Thread Theodore Luo Wang via Phabricator via cfe-commits
theo-lw updated this revision to Diff 487103. theo-lw added a comment. Accidentally deleted a line causing this to not compile :( CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141177/new/ https://reviews.llvm.org/D141177 Files: clang/lib/Sema/SemaDecl.cpp clang/test/Parser/c1x-alig

[PATCH] D141177: [Clang] Don't tell people to place _Alignas on a struct in diagnostics

2023-01-06 Thread Theodore Luo Wang via Phabricator via cfe-commits
theo-lw created this revision. theo-lw added a reviewer: aaron.ballman. Herald added a project: All. theo-lw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This changes the diagnostic for _Alignas so it no longer tells people to place _Al