https://github.com/tarunprabhu approved this pull request.
LGTM. Thanks!
https://github.com/llvm/llvm-project/pull/140182
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tarunprabhu wrote:
Is this doing a lot that is similar to #140533?
https://github.com/llvm/llvm-project/pull/140544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tarunprabhu wrote:
> The `FCC_OVERRIDE_OPTIONS` seemed like the most obvious name to me but I am
> open to other ideas.
Thanks Abid. Perhaps `FFC_OVERRIDE_OPTIONS`? It has a similar correspondence to
`CCC_OVERRIDE_OPTIONS` as `FCFLAGS` does to `CCFLAGS`. But I don't have a
strong opinion on
https://github.com/tarunprabhu approved this pull request.
LGTM. Thanks.
https://github.com/llvm/llvm-project/pull/140533
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tarunprabhu edited
https://github.com/llvm/llvm-project/pull/140182
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tarunprabhu commented:
Could you add a test that ensures that the loop-interchange pass is added to
the pipeline. Perhaps something like
[flang/test/Driver/slp-vectorize.f90](https://github.com/llvm/llvm-project/blob/04fde85057cb4da2e560da629df7a52702eac489/flang/test/Driver/
@@ -421,7 +421,8 @@ static void CheckSubscripts(
static void CheckSubscripts(
semantics::SemanticsContext &context, CoarrayRef &ref) {
- const Symbol &coarraySymbol{ref.GetBase().GetLastSymbol()};
+ const auto &base = ref.GetBase();
+ const Symbol &coarraySymbol{base.Ge
https://github.com/tarunprabhu requested changes to this pull request.
Thanks. We should try to share code between `clang` and `flang` where
appropriate.
https://github.com/llvm/llvm-project/pull/137759
___
cfe-commits mailing list
cfe-commits@lists.l
@@ -11,17 +11,46 @@
//===--===//
#include "flang/Frontend/CodeGenOptions.h"
+#include "llvm/TargetParser/Triple.h"
#include
#include
namespace Fortran::frontend {
+using namespace llvm;
+
CodeGenOpt
https://github.com/tarunprabhu edited
https://github.com/llvm/llvm-project/pull/137759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -11,17 +11,46 @@
//===--===//
#include "flang/Frontend/CodeGenOptions.h"
+#include "llvm/TargetParser/Triple.h"
#include
#include
namespace Fortran::frontend {
+using namespace llvm;
-
@@ -787,6 +792,11 @@ void CodeGenAction::generateLLVMIR() {
return;
}
+ for (llvm::Function &F : llvmModule->getFunctionList()) {
tarunprabhu wrote:
We use slightly different coding conventions in flang. In particular, we use
camel-casing in most plac
tarunprabhu wrote:
> I think the appropriate core MLIR dialects are those that most closely
> reflect the original FIR representation. Do you have any suggestions on how
> to approach this?
I am not exactly clear on what sort of suggestions you are looking for. I
haven't thought a lot about t
tarunprabhu wrote:
> A new parent class for code-gen frontend actions is
> introduced:`CodeGenAction`.
Should this instead be a "A new code-gen action class is introduced:
`EmitMLIRAction`?" That seems to be the only new class that has been introduced
and it is not (yet, at least) a parent fo
@@ -635,6 +635,49 @@ void CodeGenAction::lowerHLFIRToFIR() {
}
}
+void CodeGenAction::lowerFIRToMLIR() {
+ assert(mlirModule && "The MLIR module has not been generated yet.");
+
+ CompilerInstance &ci = this->getInstance();
+ CompilerInvocation &invoc = ci.getInvocation()
https://github.com/tarunprabhu commented:
I tend to prefer @jeanPerier's suggestion of having the option name reflect
that only the LLVM dialect is being used.
In the future, do you intend to provide a way to choose the set of dialects to
use? In that case, we could consider something a bit m
https://github.com/tarunprabhu edited
https://github.com/llvm/llvm-project/pull/139857
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tarunprabhu edited
https://github.com/llvm/llvm-project/pull/136098
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -8,8 +8,14 @@
#include "llvm/Frontend/Driver/CodeGenOptions.h"
#include "llvm/Analysis/TargetLibraryInfo.h"
+#include "llvm/ProfileData/InstrProfCorrelator.h"
#include "llvm/TargetParser/Triple.h"
+namespace llvm {
+extern llvm::cl::opt DebugInfoCorrelate;
+extern llvm::
https://github.com/tarunprabhu commented:
Thank you for seeing this through and making all the little changes. I have
requested reviews from @MaskRay and @aeubanks for the clang side of things.
https://github.com/llvm/llvm-project/pull/136098
___
cfe
@@ -33,9 +35,18 @@ enum class VectorLibrary {
AMDLIBM // AMD vector math library.
};
+enum ProfileInstrKind {
+ ProfileNone, // Profile instrumentation is turned off.
+ ProfileClangInstr, // Clang instrumentation to generate execution counts
+
https://github.com/tarunprabhu commented:
Thanks for making all the changes. Just a few minor comments.
https://github.com/llvm/llvm-project/pull/136098
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
@@ -0,0 +1,39 @@
+! Tests for -fprofile-generate and -fprofile-use flag compatibility. These two
+! flags behave similarly to their GCC counterparts:
+!
+! -fprofile-generate Generates the profile file ./default.profraw
+! -fprofile-use=/file Uses the profile file /file
@@ -36,6 +37,15 @@ enum class VectorLibrary {
TargetLibraryInfoImpl *createTLII(const llvm::Triple &TargetTriple,
VectorLibrary Veclib);
+enum ProfileInstrKind {
tarunprabhu wrote:
Nit: It may be better to move this above the
@@ -13,6 +13,7 @@
#ifndef LLVM_FRONTEND_DRIVER_CODEGENOPTIONS_H
#define LLVM_FRONTEND_DRIVER_CODEGENOPTIONS_H
+#include
tarunprabhu wrote:
An empty line should separate the last include and the namespace below
https://github.com/llvm/llvm-project/pull/13609
@@ -8,8 +8,14 @@
#include "llvm/Frontend/Driver/CodeGenOptions.h"
#include "llvm/Analysis/TargetLibraryInfo.h"
+#include "llvm/ProfileData/InstrProfCorrelator.h"
#include "llvm/TargetParser/Triple.h"
+namespace llvm {
+extern llvm::cl::opt DebugInfoCorrelate;
+extern llvm::
https://github.com/tarunprabhu edited
https://github.com/llvm/llvm-project/pull/136098
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tarunprabhu approved this pull request.
Other than the nit about the documentation text, LGTM. Thanks for the changes.
https://github.com/llvm/llvm-project/pull/137996
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://l
@@ -81,6 +81,9 @@ class CodeGenOptions : public CodeGenOptionsBase {
/// Options to add to the linker for the object file
std::vector DependentLibs;
+ /// Indicates whether -finstrument-functions option is passed
tarunprabhu wrote:
nit
```suggestion
/
https://github.com/tarunprabhu edited
https://github.com/llvm/llvm-project/pull/137996
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tarunprabhu edited
https://github.com/llvm/llvm-project/pull/137996
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -81,6 +81,8 @@ class CodeGenOptions : public CodeGenOptionsBase {
/// Options to add to the linker for the object file
std::vector DependentLibs;
+ bool InstrumentFunctions{false};
tarunprabhu wrote:
I missed this in the first round. A documentation c
https://github.com/tarunprabhu commented:
Thanks for the changes. Other than the documentation comment this looks good.
https://github.com/llvm/llvm-project/pull/137996
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
@@ -310,6 +310,10 @@ static void
parseCodeGenArgs(Fortran::frontend::CodeGenOptions &opts,
args.filtered(clang::driver::options::OPT_fembed_offload_object_EQ))
opts.OffloadObjects.push_back(a->getValue());
+ if (args.hasFlag(clang::driver::options::OPT_finstrument
@@ -124,6 +128,8 @@ struct MLIRToLLVMPassPipelineConfig : public
FlangEPCallBacks {
bool UnsafeFPMath = false; ///< Set unsafe-fp-math attribute for functions.
bool NSWOnLoopVarInc = true; ///< Add nsw flag to loop variable increments.
bool EnableOpenMP = false; ///< Ena
@@ -20,8 +20,13 @@
#include "mlir/IR/OwningOpRef.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/IR/Module.h"
+#include "llvm/Support/CommandLine.h"
+#include "llvm/Support/PGOOptions.h"
#include
+namespace llvm {
+extern cl::opt ClPGOColdFuncAttr;
tarunp
@@ -13,9 +13,14 @@
#ifndef LLVM_FRONTEND_DRIVER_CODEGENOPTIONS_H
#define LLVM_FRONTEND_DRIVER_CODEGENOPTIONS_H
+#include "llvm/ProfileData/InstrProfCorrelator.h"
+#include
namespace llvm {
class Triple;
class TargetLibraryInfoImpl;
+extern llvm::cl::opt DebugInfoCorrelate;
@@ -19,6 +21,7 @@ template class Expected;
template class IntrusiveRefCntPtr;
class Module;
class MemoryBufferRef;
+extern cl::opt ClPGOColdFuncAttr;
tarunprabhu wrote:
Since this is an experimental option that will likely be removed and is only to
be used
@@ -28,6 +28,7 @@
#include "flang/Semantics/unparse-with-symbols.h"
#include "flang/Support/default-kinds.h"
#include "flang/Tools/CrossToolHelpers.h"
+#include "clang/CodeGen/BackendUtil.h"
tarunprabhu wrote:
We should not include clang headers unless necessa
https://github.com/tarunprabhu requested changes to this pull request.
Thanks for the updating the PR.
There seems to be a [buildkite
failure](https://buildkite.com/llvm-project/github-pull-requests/builds/173137#01967cab-3f69-4ec6-8175-49795d1a2819).
These failures are often worth checking b
https://github.com/tarunprabhu edited
https://github.com/llvm/llvm-project/pull/136098
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tarunprabhu wrote:
If I understand what you are saying correctly, this would involve, for example,
duplicating the definition of `enum ProfileInstrKind` in `flang` in this PR,
then a second PR that moves it from both `flang` and `clang` to
`llvm/Frontend`. This is churn that can be distracting
tarunprabhu wrote:
There is precedent for changing the clang source in order to share code or to
augment it for use with flang. For what needs to be done here, I think it
should be fine. We will have to request reviews from the clang developers as
well.
https://github.com/llvm/llvm-project/pu
https://github.com/tarunprabhu edited
https://github.com/llvm/llvm-project/pull/136098
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -130,6 +133,20 @@ static bool saveMLIRTempFile(const CompilerInvocation &ci,
// Custom BeginSourceFileAction
//===--===//
+
+static llvm::cl::opt ClPGOColdFuncAttr(
tarunprabhu wrote:
Thi
https://github.com/tarunprabhu commented:
Thanks for working on this.
https://github.com/llvm/llvm-project/pull/136098
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,14 @@
+# IR level Instrumentation Flag
+:ir
+:entry_first
+_QQmain
+# Func Hash:
+146835646621254984
+# Num Counters:
+2
+# Counter Values:
+100
+1
+
tarunprabhu wrote:
Are the trailing newlines here necessary?
https://github.com/llvm/llvm-project/pul
@@ -892,6 +909,20 @@ static void
generateMachineCodeOrAssemblyImpl(clang::DiagnosticsEngine &diags,
delete tlii;
}
+
+// Default filename used for profile generation.
+namespace llvm {
+ extern llvm::cl::opt DebugInfoCorrelate;
+ extern llvm::cl::opt
ProfileCorrelate;
+
@@ -148,6 +148,55 @@ class CodeGenOptions : public CodeGenOptionsBase {
/// OpenMP is enabled.
using DoConcurrentMappingKind = flangomp::DoConcurrentMappingKind;
+ enum ProfileInstrKind {
tarunprabhu wrote:
Can this enum be shared between `clang` and `fl
https://github.com/tarunprabhu edited
https://github.com/llvm/llvm-project/pull/136202
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tarunprabhu approved this pull request.
Other than the missing braces around the `if`, LGTM. Thanks.
https://github.com/llvm/llvm-project/pull/136202
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
@@ -733,11 +733,16 @@ static llvm::Triple computeTargetTriple(const Driver &D,
Target.setEnvironment(llvm::Triple::GNUX32);
} else if (A->getOption().matches(options::OPT_m32) ||
A->getOption().matches(options::OPT_maix32)) {
- AT = Target.get32B
@@ -6880,6 +6880,13 @@ let Flags = [TargetSpecific] in {
defm android_pad_segment : BooleanFFlag<"android-pad-segment">, Group;
} // let Flags = [TargetSpecific]
+def shared_libflangrt : Flag<["-"], "shared-libflangrt">,
+ HelpText<"Dynamically link the shared flang-rt">, Gro
https://github.com/tarunprabhu approved this pull request.
Thanks Daniel. I don't think a separate PR is necessary for the changes, but
perhaps wait to see if @MaskRay has a different opinion
https://github.com/llvm/llvm-project/pull/134362
___
cfe-co
@@ -6880,6 +6880,13 @@ let Flags = [TargetSpecific] in {
defm android_pad_segment : BooleanFFlag<"android-pad-segment">, Group;
} // let Flags = [TargetSpecific]
+def shared_libflangrt : Flag<["-"], "shared-libflangrt">,
+ HelpText<"Dynamically link the shared flang-rt">, Gro
@@ -746,7 +746,8 @@ std::string ToolChain::buildCompilerRTBasename(const
llvm::opt::ArgList &Args,
case ToolChain::FT_Shared:
Suffix = TT.isOSWindows()
? (TT.isWindowsGNUEnvironment() ? ".dll.a" : ".lib")
- : ".so";
+ : TT.isO
@@ -0,0 +1,27 @@
+! Test forwarding just the forwarding of -frepack-arrays-contiguity options:
+! RUN: %flang -frepack-arrays-contiguity=whole %s -### -fsyntax-only 2>&1 |
FileCheck --check-prefix=WHOLECMD %s
+! RUN: %flang -frepack-arrays-contiguity=innermost %s -### -fsyntax-on
https://github.com/tarunprabhu approved this pull request.
LGTM. Thanks!
https://github.com/llvm/llvm-project/pull/134362
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tarunprabhu approved this pull request.
LGTM. Thanks.
https://github.com/llvm/llvm-project/pull/134230
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,27 @@
+! Test forwarding just the forwarding of -frepack-arrays-contiguity options:
tarunprabhu wrote:
```suggestion
! Test forwarding of -frepack-arrays-contiguity options:
```
https://github.com/llvm/llvm-project/pull/134002
@@ -0,0 +1,24 @@
+! Test forwarding just the forwarding of -f[no-]repack-arrays options:
tarunprabhu wrote:
```suggestion
! Test forwarding of -f[no-]repack-arrays options:
```
https://github.com/llvm/llvm-project/pull/134002
https://github.com/tarunprabhu approved this pull request.
Thanks for the changes, David. :-)
https://github.com/llvm/llvm-project/pull/133775
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
@@ -0,0 +1,24 @@
+! Test forwarding just the forwarding of -f[no-]stack-repack-arrays options:
tarunprabhu wrote:
```suggestion
! Test forwarding of -f[no-]stack-repack-arrays options:
```
https://github.com/llvm/llvm-project/pull/134002
@@ -6974,6 +7019,22 @@ defm loop_versioning : BoolOptionWithoutMarshalling<"f",
"version-loops-for-stri
PosFlag,
NegFlag>;
+defm stack_repack_arrays
+: BoolOptionWithoutMarshalling<
+ "f", "stack-repack-arrays",
+ PosFlag,
+ NegFlag<
+
https://github.com/tarunprabhu edited
https://github.com/llvm/llvm-project/pull/133775
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -88,8 +88,8 @@ TYPE("assembler-with-cpp", Asm, PP_Asm,
"S", phases
// modules when Flang needs to emit pre-processed files. Therefore, the
// `PP_TYPE` is set to `PP_Fortran` so that the driver is fine with
// "pre-processing a pre-processed fil
https://github.com/tarunprabhu commented:
Other than the nit, this looks ok. However, I must admit that I don't fully
understand the nuances of the various modes, and I got a bit lost with the
previous PR as well, so I'll leave it to someone else to approve as they see
fit.
https://github.com
https://github.com/tarunprabhu approved this pull request.
Thanks Tom. This looks fine to me, but please wait for those more familiar with
OpenMP before merging.
https://github.com/llvm/llvm-project/pull/133745
___
cfe-commits mailing list
cfe-commits
@@ -0,0 +1,4 @@
+! Check support of -m64.
+! RUN: %flang -target i386-pc-win32 -m64 -### - %s 2>&1 | FileCheck
-check-prefix=M64 %s
+
+! M64: "-triple" "{{[^-]+}}64-{{.*}}"
tarunprabhu wrote:
If the `-target` is given as `i386-*`, this should always return `x86_
https://github.com/tarunprabhu approved this pull request.
https://github.com/llvm/llvm-project/pull/132409
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tarunprabhu wrote:
Is this buildbot failure related:
[https://lab.llvm.org/buildbot/#/builders/89/builds/19482](https://lab.llvm.org/buildbot/#/builders/89/builds/19482)?
https://github.com/llvm/llvm-project/pull/132801
___
cfe-commits mailing list
cf
@@ -3177,3 +3177,25 @@ bool tools::shouldEnableVectorizerAtOLevel(const ArgList
&Args, bool isSlpVec) {
return false;
}
+
+/// Enable -fvectorize based on the optimization level selected.
tarunprabhu wrote:
It might be better to move the docstrings to `Com
@@ -3177,3 +3177,25 @@ bool tools::shouldEnableVectorizerAtOLevel(const ArgList
&Args, bool isSlpVec) {
return false;
}
+
+/// Enable -fvectorize based on the optimization level selected.
+void tools::handleVectorizeLoopsArgs(const ArgList &Args,
+
https://github.com/tarunprabhu edited
https://github.com/llvm/llvm-project/pull/132801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tarunprabhu approved this pull request.
Apart from the docstrings, this looks good. Thanks for the changes :-)
https://github.com/llvm/llvm-project/pull/132801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
@@ -3177,3 +3177,25 @@ bool tools::shouldEnableVectorizerAtOLevel(const ArgList
&Args, bool isSlpVec) {
return false;
}
+
+/// Enable -fvectorize based on the optimization level selected.
+void tools::handleVectorizeLoopsArgs(const ArgList &Args,
+
tarunprabhu wrote:
> cc @tblah @DavidTruby
If you are soliciting reviews, you could also use the "Reviewers" box on the
top right of this page
https://github.com/llvm/llvm-project/pull/132801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
tarunprabhu wrote:
> > If you are soliciting reviews, you could also use the "Reviewers" box on
> > the top right of this page
>
> I would, but I do not currently have the right permissions to use the box.
> Hence the ccs - I need someone else to do it.
Huh. I didn't realize that one needed s
https://github.com/tarunprabhu requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/132801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4032,11 +4032,14 @@ def : Flag<["-"], "ftree-vectorize">, Alias;
def : Flag<["-"], "fno-tree-vectorize">, Alias;
}
+let Visibility = [ClangOption, FlangOption] in {
tarunprabhu wrote:
I think we should merge this with the visibility block for `fvectorize`
@@ -161,6 +161,14 @@ void Flang::addCodegenOptions(const ArgList &Args,
options::OPT_fno_vectorize, enableVec))
CmdArgs.push_back("-vectorize-loops");
+ // -fslp-vectorize is enabled based on the optimization level selected.
+ bool EnableSLPVec = shoul
@@ -0,0 +1,10 @@
+! RUN: %flang -### -S -fslp-vectorize %s 2>&1 | FileCheck
-check-prefix=CHECK-SLP-VECTORIZE %s
+! RUN: %flang -### -S -fno-slp-vectorize %s 2>&1 | FileCheck
-check-prefix=CHECK-NO-SLP-VECTORIZE %s
+! RUN: %flang -### -S -O1 %s 2>&1 | FileCheck
-check-prefix=CH
https://github.com/tarunprabhu approved this pull request.
Thanks for all the changes, Tom! LGTM.
https://github.com/llvm/llvm-project/pull/130788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/c
@@ -172,7 +172,8 @@ void Flang::addCodegenOptions(const ArgList &Args,
options::OPT_finit_global_zero,
options::OPT_fno_init_global_zero,
options::OPT_ftime_report,
options::OPT_ftime_report_EQ, options::OPT_funroll_loop
https://github.com/tarunprabhu commented:
Do we really want to maintain an equivalence with clang by keeping this in
`CodeGenOptions` when it really ought to be a `TargetOption`? It looks like
almost all of the handling of this option takes place in `flang`, so we
probably shouldn't be bound t
=?utf-8?q?I=C3=B1aki?= Amatria Barral
Message-ID:
In-Reply-To:
https://github.com/tarunprabhu approved this pull request.
Thanks for all the changes :-)
https://github.com/llvm/llvm-project/pull/130268
___
cfe-commits mailing list
cfe-commits@lists.
tarunprabhu wrote:
For compiler options, we have various "categories" in `Options.td`,
`ClangOptions`, `FlangOptions` etc. which only apply to specific frontends. I
haven't looked very closely at this, but I believe that there is only one
"category" for warnings. Is this correct? If that the c
=?utf-8?q?Iñaki?= Amatria Barral
Message-ID:
In-Reply-To:
@@ -0,0 +1,35 @@
+program main
+ print *, __FILE__, __LINE__
+end
+
+! This test verifies that `flang`'s `-x` options behave like `gfortran`'s.
+! Specifically:
+! - `-x f95` should process the file based on its extensi
=?utf-8?q?Iñaki?= Amatria Barral
Message-ID:
In-Reply-To:
https://github.com/tarunprabhu edited
https://github.com/llvm/llvm-project/pull/130268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/c
tarunprabhu wrote:
Thanks for working on this @JDPailleux.
This looks like a substantial change including to parts of clang. Is it
possible to split this into two. One PR for just the "infrastructure" and
another for the flang-specifc warnings. This would make it easier to focus the
discussi
=?utf-8?q?Iñaki?= Amatria Barral
Message-ID:
In-Reply-To:
@@ -0,0 +1,12 @@
+! This test verifies that using `-x f95` does not cause the driver to assume
+! this file is in fixed-form.
+
+program main
+ print *, "Hello, World!"
+end
+
+! RUN: %flang -### -x f95 %s 2>&1 | FileCh
=?utf-8?q?I=C3=B1aki?= Amatria Barral
Message-ID:
In-Reply-To:
https://github.com/tarunprabhu commented:
Thanks for continuing to see this through
https://github.com/llvm/llvm-project/pull/130268
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
=?utf-8?q?Iñaki?= Amatria Barral
Message-ID:
In-Reply-To:
@@ -0,0 +1,35 @@
+program main
+ print *, __FILE__, __LINE__
+end
+
+! This test verifies that `flang`'s `-x` options behave like `gfortran`'s.
+! Specifically:
+! - `-x f95` should process the file based on its extensi
https://github.com/tarunprabhu approved this pull request.
Thanks for seeing this through.
https://github.com/llvm/llvm-project/pull/127605
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
=?utf-8?q?I=C3=B1aki?= Amatria Barral
Message-ID:
In-Reply-To:
tarunprabhu wrote:
This looks ok to me, but please wait for others to approve.
https://github.com/llvm/llvm-project/pull/127986
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
@@ -6747,8 +6747,16 @@ defm backtrace : BooleanFFlag<"backtrace">,
Group;
defm bounds_check : BooleanFFlag<"bounds-check">, Group;
defm check_array_temporaries : BooleanFFlag<"check-array-temporaries">,
Group;
defm cray_pointer : BooleanFFlag<"cray-pointer">, Group;
-defm d_l
https://github.com/tarunprabhu approved this pull request.
Thanks, Jean-Didier
https://github.com/llvm/llvm-project/pull/127605
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3986,11 +3986,15 @@ defm assumptions : BoolFOption<"assumptions",
"Disable codegen and compile-time checks for C++23's [[assume]]
attribute">,
PosFlag>;
+
+let Visibility = [ClangOption, FlangOption] in {
tarunprabhu wrote:
> You'd hope that
tarunprabhu wrote:
LGTM. Thanks.
https://github.com/llvm/llvm-project/pull/126026
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tarunprabhu approved this pull request.
LGTM. Thanks.
https://github.com/llvm/llvm-project/pull/119718
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 293 matches
Mail list logo
