[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu marked 2 inline comments as done. tarunprabhu added a comment. Yes, I am aware of the other patch which also adds `test/Driver/pass-plugin.f90`. I will keep an eye out for it. Comment at: flang/test/CMakeLists.txt:65 ) +if (NOT WIN32) + list(APPEND FLANG_TEST_DEP

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu updated this revision to Diff 474382. tarunprabhu added a comment. Previous revision was missing the tests. Only add a dependence to the Bye plugin when plugins are enabled. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129156/new/ https://reviews.llvm.org/D129156 Files:

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu updated this revision to Diff 474381. tarunprabhu added a comment. Only add a dependence to the Bye plugin when plugins are enabled. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129156/new/ https://reviews.llvm.org/D129156 Files: clang/include/clang/Driver/Options.td c

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu updated this revision to Diff 472161. tarunprabhu added a comment. Added a dependence for the flang tests on LLVM's Bye plugin. This results in the Bye plugin being built when check-flang is run, even if building examples has been explicitly disabled. Removed the dependency on 'exam

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu added a comment. In D129156#3851843 , @awarzynski wrote: > @tarunprabhu Could you confirm that with the build command above > "pass-plugin.f90" is failing for you? It is for me. The tests still passed. Some relevant output from the test is

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu added a comment. In D129156#3851843 , @awarzynski wrote: > @tarunprabhu Could you confirm that with the build command above > "pass-plugin.f90" is failing for you? It is for me. What compiler do you use to build this? gcc doesn't seem to li

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu added a comment. In D129156#3848728 , @awarzynski wrote: > Thanks Valentin! Switching between generators will definitely change the > order in which libraries will built (and, AFAIK, the order is > non-deterministic to begin with). I will t

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu added a comment. I tried an out-of-tree flang build. check-flang passes in that case too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129156/new/ https://reviews.llvm.org/D129156 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu updated this revision to Diff 466561. tarunprabhu added a comment. Added `examples` to `REQUIRES` in `test/Driver/pass-plugin.f90. I still cannot reproduce the build failure on my end. @MatsPetersson tested this patch and the tests passed. Could someone else test this on their build

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu added a comment. In D129156#3836838 , @clementval wrote: > I probably didn't copy the error correctly .. this is the correct libs that > is not found `llvm-project/build/lib/Bye.so` I need some help with this. The failing build is building

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu added a comment. I think there is a typo somehow. It should be "Bye.so". Not sure how that happened. I'm looking into this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129156/new/ https://reviews.llvm.org/D129156 ___

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu added a comment. Thanks for the review and the comments. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129156/new/ https://reviews.llvm.org/D129156 ___ cfe-commits mailing list cfe-commit

[PATCH] D129156: Add -fpass-plugin option to Flang

This revision was automatically updated to reflect the committed changes. Closed by commit rG43fe6f7cc35d: [flang] Add -fpass-plugin option to Flang frontend (authored by tarunprabhu). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CH

[PATCH] D130078: [flang][nfc] Rename `AddOtherOptions` as `ForwardOptions`

tarunprabhu accepted this revision. tarunprabhu added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130078/new/ https://reviews.llvm.org/D130078