[PATCH] D128257: invalidateCache in addModule and removeModules

2022-06-25 Thread Tapasweni Pathak via Phabricator via cfe-commits
tapaswenipathak added a comment. https://github.com/llvm/llvm-project/commit/ca39214f4e9fddf247e880ef9562865be850fce6#diff-a59fa24a712b79c57b4d922d0d407b8f63a9a88fa79ba0d85b0063e1a2a6fda3L157 closing, now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D128319: Survive #pragma once from virtual file.

2022-06-21 Thread Tapasweni Pathak via Phabricator via cfe-commits
tapaswenipathak created this revision. tapaswenipathak added a reviewer: v.g.vassilev. tapaswenipathak added a project: clang. Herald added a project: All. tapaswenipathak requested review of this revision. Herald added a subscriber: cfe-commits. Add check before marking file as a once-only file.

[PATCH] D128257: invalidateCache in addModule and removeModules

2022-06-21 Thread Tapasweni Pathak via Phabricator via cfe-commits
tapaswenipathak created this revision. tapaswenipathak added a reviewer: v.g.vassilev. tapaswenipathak added a project: clang. Herald added a project: All. tapaswenipathak requested review of this revision. Herald added a subscriber: cfe-commits. Ref: https://github.com/vgvassilev/clang/commit/758

[PATCH] D126266: Mark the file entry invalid, until reread. Invalidate SLocEntry cache, readd it on reread. Do not use translateFile, because it pulls in parts of the pch.

2022-06-21 Thread Tapasweni Pathak via Phabricator via cfe-commits
tapaswenipathak updated this revision to Diff 438597. tapaswenipathak added a comment. git clang-format HEAD~1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126266/new/ https://reviews.llvm.org/D126266 Files: clang/include/clang/Basic/FileEntry.

[PATCH] D126266: Mark the file entry invalid, until reread. Invalidate SLocEntry cache, readd it on reread. Do not use translateFile, because it pulls in parts of the pch.

2022-06-20 Thread Tapasweni Pathak via Phabricator via cfe-commits
tapaswenipathak updated this revision to Diff 438550. tapaswenipathak added a comment. omit an unrelated change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126266/new/ https://reviews.llvm.org/D126266 Files: clang/include/clang/Basic/FileEntr

[PATCH] D126266: Mark the file entry invalid, until reread. Invalidate SLocEntry cache, readd it on reread. Do not use translateFile, because it pulls in parts of the pch.

2022-06-20 Thread Tapasweni Pathak via Phabricator via cfe-commits
tapaswenipathak updated this revision to Diff 438541. tapaswenipathak added a comment. fix for build failure: cmdline: git reset --hard stderr: 'fatal: Unable to create '/var/lib/buildkite-agent/builds/llvm-project-fork/.git/index.lock': File exists. https://buildkite.com/llvm-project/diff

[PATCH] D126266: Mark the file entry invalid, until reread. Invalidate SLocEntry cache, readd it on reread. Do not use translateFile, because it pulls in parts of the pch.

2022-06-20 Thread Tapasweni Pathak via Phabricator via cfe-commits
tapaswenipathak updated this revision to Diff 438535. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126266/new/ https://reviews.llvm.org/D126266 Files: clang/include/clang/Basic/FileEntry.h clang/include/clang/Basic/FileManager.h clang/include

[PATCH] D126183: Implement soft reset of the diagnostics engine.

2022-06-14 Thread Tapasweni Pathak via Phabricator via cfe-commits
tapaswenipathak updated this revision to Diff 436750. tapaswenipathak edited the summary of this revision. tapaswenipathak added a comment. Addresses review comment by @v.g.vassilev. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126183/new/ https:/

[PATCH] D126183: Implement soft reset of the diagnostics engine.

2022-06-01 Thread Tapasweni Pathak via Phabricator via cfe-commits
tapaswenipathak updated this revision to Diff 433362. tapaswenipathak added a comment. this should be green. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126183/new/ https://reviews.llvm.org/D126183 Files: clang/include/clang/Basic/Diagnosti

[PATCH] D126183: Implement soft reset of the diagnostics engine.

2022-05-28 Thread Tapasweni Pathak via Phabricator via cfe-commits
tapaswenipathak updated this revision to Diff 432747. tapaswenipathak added a comment. runs `make check-clang`, `check-clang-tools`, `check-all`. prev ran: `make check-clang-unit`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126183/new/ https://

[PATCH] D126600: Allow interfaces to operate on in-memory buffers with no source location info.

2022-05-28 Thread Tapasweni Pathak via Phabricator via cfe-commits
tapaswenipathak abandoned this revision. tapaswenipathak added a comment. Ref: dup: https://reviews.llvm.org/D88780. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126600/new/ https://reviews.llvm.org/D126600 ___

[PATCH] D88780: Allow interfaces to operate on in-memory buffers with no source location info.

2022-05-28 Thread Tapasweni Pathak via Phabricator via cfe-commits
tapaswenipathak updated this revision to Diff 432746. tapaswenipathak added a comment. Allow interfaces to operate on in-memory buffers with no source location info. This patch avoids an assert PresumedLoc::getFilename if it is invalid. Add unit tests for allowing the interface t

[PATCH] D88780: Allow interfaces to operate on in-memory buffers with no source location info.

2022-05-28 Thread Tapasweni Pathak via Phabricator via cfe-commits
tapaswenipathak commandeered this revision. tapaswenipathak added a reviewer: reikdas. tapaswenipathak added a comment. Herald added a project: All. Ref: https://reviews.llvm.org/D126600. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88780/new/ htt

[PATCH] D126600: Allow interfaces to operate on in-memory buffers with no source location info.

2022-05-28 Thread Tapasweni Pathak via Phabricator via cfe-commits
tapaswenipathak created this revision. tapaswenipathak added a reviewer: v.g.vassilev. tapaswenipathak added a project: clang. Herald added a project: All. tapaswenipathak requested review of this revision. Herald added a subscriber: cfe-commits. Allow interfaces to operate on in-memory buffers wi

[PATCH] D126183: Implement soft reset of the diagnostics engine.

2022-05-28 Thread Tapasweni Pathak via Phabricator via cfe-commits
tapaswenipathak updated this revision to Diff 432730. tapaswenipathak added a comment. Fixes: https://buildkite.com/llvm-project/premerge-checks/builds/95001#01810b0b-6313-400f-aaf0-35855916ec93 I pasted the wrong diff. sorry! (have multiple build repository in local) F23230857: Screenshot 202

[PATCH] D126183: Implement soft reset of the diagnostics engine.

2022-05-28 Thread Tapasweni Pathak via Phabricator via cfe-commits
tapaswenipathak updated this revision to Diff 432723. tapaswenipathak added a comment. Fixes F23230194: Screenshot 2022-05-28 at 7.18.51 PM.png . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126183/new/ https:/

[PATCH] D126183: Implement soft reset of the diagnostics engine.

2022-05-28 Thread Tapasweni Pathak via Phabricator via cfe-commits
tapaswenipathak updated this revision to Diff 432712. tapaswenipathak added a comment. runs clang-format on the diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126183/new/ https://reviews.llvm.org/D126183 Files: include/clang/Basic/Diagnosti

[PATCH] D126183: Implement soft reset of the diagnostics engine.

2022-05-28 Thread Tapasweni Pathak via Phabricator via cfe-commits
tapaswenipathak updated this revision to Diff 432711. tapaswenipathak added a comment. Addresses review comment by @rsmith: https://reviews.llvm.org/D126183#3534846. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126183/new/ https://reviews.llvm.org