[PATCH] D51741: [coro]Pass rvalue reference for named local variable to return_value

tks2103 added a comment. @modocache I do need someone to land this for me! Take it away! Repository: rC Clang https://reviews.llvm.org/D51741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D51741: [coro]Pass rvalue reference for named local variable to return_value

tks2103 updated this revision to Diff 168380. tks2103 added a comment. comply with clang-format Repository: rC Clang https://reviews.llvm.org/D51741 Files: lib/Sema/SemaCoroutine.cpp test/SemaCXX/coroutine-rvo.cpp Index: test/SemaCXX/coroutine-rvo.cpp ==

[PATCH] D51741: [coro]Pass rvalue reference for named local variable to return_value

tks2103 added a comment. ping @GorNishanov SAVE ME GOR! YOU'RE MY ONLY HOPE! Repository: rC Clang https://reviews.llvm.org/D51741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51741: [coro]Pass rvalue reference for named local variable to return_value

tks2103 added a comment. ping @GorNishanov Repository: rC Clang https://reviews.llvm.org/D51741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51741: [coro]Pass rvalue reference for named local variable to return_value

tks2103 added a comment. ping @GorNishanov Repository: rC Clang https://reviews.llvm.org/D51741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51741: [coro]Pass rvalue reference for named local variable to return_value

tks2103 updated this revision to Diff 164265. tks2103 added a comment. get NRVOCandidate to determine if we should try to move return var Repository: rC Clang https://reviews.llvm.org/D51741 Files: lib/Sema/SemaCoroutine.cpp test/SemaCXX/coroutine-rvo.cpp Index: test/SemaCXX/coroutine-

[PATCH] D51741: [coro]Pass rvalue reference for named local variable to return_value

tks2103 added a comment. also fails https://github.com/llvm-mirror/clang/blob/master/test/SemaCXX/coroutines.cpp#L494 with `address of overloaded function 'g' does not match required type ''` also fails https://github.com/llvm-mirror/clang/blob/master/test/SemaCXX/coroutines.cpp#L505 with `ad

[PATCH] D51741: [coro]Pass rvalue reference for named local variable to return_value

tks2103 added a comment. currently changes the behavior for a few cases: something like void coro() { co_return {4}; } throws `illegal initializer type 'void'` Repository: rC Clang https://reviews.llvm.org/D51741 ___ cfe-commits mailin

[PATCH] D51741: [coro]Pass rvalue reference for named local variable to return_value

tks2103 created this revision. tks2103 added reviewers: modocache, GorNishanov. Herald added a subscriber: cfe-commits. tks2103 edited the summary of this revision. Addressing https://bugs.llvm.org/show_bug.cgi?id=37265. Implements [class.copy]/33 of coroutines TS When the criteria for elision o

[PATCH] D48981: Add caching when looking up coroutine_traits

tks2103 added a comment. ping @modocache @GorNishanov Repository: rC Clang https://reviews.llvm.org/D48981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49099: Remove qualtype qualifier in coroutine error to prevent assert in debug

tks2103 added a comment. @modocache please commit on my behalf please =) Repository: rC Clang https://reviews.llvm.org/D49099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49099: Remove qualtype qualifier in coroutine error to prevent assert in debug

tks2103 created this revision. tks2103 added reviewers: modocache, GorNishanov. A forward-declared coroutine_traits should trip an error; we need a complete type. Unfortunately, in debug mode only, we trip an assert when attempting to provide the fully qualified type for the error message. If you

[PATCH] D48981: Add caching when looking up coroutine_traits

tks2103 added a comment. ping @modocache @GorNishanov Repository: rC Clang https://reviews.llvm.org/D48981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48981: Add caching when looking up coroutine_traits

tks2103 created this revision. tks2103 added reviewers: GorNishanov, modocache. Currently clang looks up the coroutine_traits ClassTemplateDecl everytime it looks up the promise type. This is unnecessary as coroutine_traits doesn't change between promise type lookups. This diff caches the corouti