[PATCH] D98548: [clang][Sema] Don't try to initialize implicit variable of invalid anonymous union/struct

This revision was automatically updated to reflect the committed changes. Closed by commit rG99fd06622784: [clang][Sema] Don't try to initialize implicit variable of invalid anonymous… (authored by TaWeiTu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D98548: [clang][Sema] Don't try to initialize implicit variable of invalid anonymous union/struct

TaWeiTu added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98548/new/ https://reviews.llvm.org/D98548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D98548: [clang][Sema] Don't try to initialize implicit variable of invalid anonymous union/struct

TaWeiTu added a comment. In D98548#2625593 , @tmatheson wrote: > This seems quite an early point to bail out, so it will prevent some > errors/warnings associated with initialization from being emitted. For > example, this warning is currently emitted bu

[PATCH] D98548: [clang][Sema] Don't try to initialize implicit variable of invalid anonymous union/struct

TaWeiTu added a comment. I'm not familiar with this code and clang/sema in general, so not sure if the fix makes sense. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98548/new/ https://reviews.llvm.org/D98548 _

[PATCH] D98548: [clang][Sema] Don't try to initialize implicit variable of invalid anonymous union/struct

TaWeiTu created this revision. TaWeiTu added reviewers: tmatheson, rsmith, dnsampaio. TaWeiTu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes https://bugs.llvm.org/show_bug.cgi?id=49534, where the call to the constructor of the

[PATCH] D84886: Create LoopNestPass

TaWeiTu added a comment. Hi, thanks for your comments and suggestions! I've thought about the suggestion by @ychen to extend the existing `LoopPassManager` to handle loop-nest passes instead of having a separate `LoopNestPassManager`, and I've uploaded a new patch D87045

[PATCH] D84886: Create LoopNestPass

TaWeiTu added a comment. Hi @Whitney, @fhahn, @ychen, thank you all for your comments and suggestions! Sorry about the late reply. I was trying to convert the `LoopInterchange` pass into a loop-nest pass. However, there seems to be no corresponding loop pass for the NPM. Any particular reason fo

[PATCH] D84886: Create LoopNestPass

TaWeiTu added a comment. @ychen Again, thanks for your comment! 1. Currently, `LoopInterchange` returns immediately if the loop is not a top-level one. The main purpose of the loop nest pass is to prevent situations like this and possibly save compiling time of uninteresting calls to `run`. 2.

[PATCH] D84886: Create LoopNestPass

TaWeiTu added a comment. Ping. @ychen Thank you for your comment! I've added some unittests. Please let me know if there's anything unclear about the intended usage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84886/new/ https://reviews.llvm.o

[PATCH] D84886: Create LoopNestPass

TaWeiTu updated this revision to Diff 282145. TaWeiTu added a comment. Fix LoopRotate/pr35210.ll (sync with commit b36c39260edcded47436f344e48f78cfbedac494 ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84886: Create LoopNestPass

TaWeiTu updated this revision to Diff 281985. TaWeiTu removed reviewers: jdoerfert, sstefan1, DavidTruby, aartbik, ftynse, baziotis, libc++. TaWeiTu removed projects: MLIR, libc-project, OpenMP, libc++, LLDB, Sanitizers. TaWeiTu added a comment. Propagate the requirement of MemorySSA from loop pa

[PATCH] D84886: Create LoopNestPass

TaWeiTu updated this revision to Diff 281954. TaWeiTu added a comment. Fix loop deletion and rotation tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84886/new/ https://reviews.llvm.org/D84886 Files: clang/lib/CodeGen/BackendUtil.cpp llvm

[PATCH] D84886: Create LoopNestPass

TaWeiTu updated this revision to Diff 281907. TaWeiTu added a comment. Fix LOOP_NEST_ANALYSIS macro, clang-tidy warnings. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84886/new/ https://reviews.llvm.org/D84886 Files: clang/lib/CodeGen/B

[PATCH] D84886: Create LoopNestPass

TaWeiTu updated this revision to Diff 281881. TaWeiTu added a comment. Herald added a reviewer: bollu. Fix several pre-merge checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84886/new/ https://reviews.llvm.org/D84886 Files: clang/lib/CodeGe

[PATCH] D84886: Create LoopNestPass

TaWeiTu created this revision. TaWeiTu added reviewers: Whitney, etiotto, fedor.sergeev, chandlerc. Herald added subscribers: llvm-commits, cfe-commits, asbirlea, dexonsmith, steven_wu, hiraditya, mgorny. Herald added projects: clang, LLVM. TaWeiTu requested review of this revision. Per http://ll