[clang] [OpenCL] No need to check array of struct for kernel arguments (PR #138894)

2025-05-23 Thread Sven van Haastregt via cfe-commits
svenvh wrote: Merged now, thanks for your contribution! https://github.com/llvm/llvm-project/pull/138894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenCL] No need to check array of struct for kernel arguments (PR #138894)

2025-05-23 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh closed https://github.com/llvm/llvm-project/pull/138894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NVPTX] Support the OpenCL generic addrspace feature by default (PR #137940)

2025-05-21 Thread Sven van Haastregt via cfe-commits
@@ -170,6 +170,8 @@ class LLVM_LIBRARY_VISIBILITY NVPTXTargetInfo : public TargetInfo { Opts["cl_khr_global_int32_extended_atomics"] = true; Opts["cl_khr_local_int32_base_atomics"] = true; Opts["cl_khr_local_int32_extended_atomics"] = true; + +Opts["__opencl_c_

[clang] [OpenCL] No need to check array of struct for kernel arguments (PR #138894)

2025-05-13 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/138894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenCL] Add test for __kernel_exec macro (PR #138287)

2025-05-05 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh closed https://github.com/llvm/llvm-project/pull/138287 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenCL] Add test for __kernel_exec macro (PR #138287)

2025-05-02 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh created https://github.com/llvm/llvm-project/pull/138287 The `__kernel_exec` macro is mandated by the OpenCL C specification and supplied by `opencl-c-base.h`, but it was not covered in any tests. Rate limit · GitHub body {

[clang] [Clang][OpenCL] Fix wait_for_event argument address space with -fdeclare-opencl-builtins (PR #134598)

2025-04-07 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh approved this pull request. LGTM, thanks for the fix! https://github.com/llvm/llvm-project/pull/134598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenCL] Add cl_ext_image_unsigned_10x6_12x4_14x2 extension (PR #134216)

2025-04-03 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh created https://github.com/llvm/llvm-project/pull/134216 Add the defines for the `cl_ext_image_unsigned_10x6_12x4_14x2` extension. >From f55b84bcd1f324f1b7a316cee049d21ea65dd41e Mon Sep 17 00:00:00 2001 From: Sven van Haastregt Date: Thu, 3 Apr 2025 09:15:22 +0100 Sub

[clang] [OpenCL] Add cl_ext_image_unsigned_10x6_12x4_14x2 extension (PR #134216)

2025-04-03 Thread Sven van Haastregt via cfe-commits
svenvh wrote: Extension specification: https://github.com/KhronosGroup/OpenCL-Docs/pull/1352 https://github.com/llvm/llvm-project/pull/134216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] [clang][SPIR-V] Use the SPIR-V backend by default (PR #129545)

2025-03-07 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh approved this pull request. https://github.com/llvm/llvm-project/pull/129545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add support for missing OpenCL extensions (PR #129777)

2025-03-06 Thread Sven van Haastregt via cfe-commits
svenvh wrote: > When someone passes the `-Xclang -cl-ext=+all`, the compiler should add > defines for all the supported extensions. Indeed; we already have such a list in `opencl-c-base.h` to enable all header-only extensions for the `spir`/`spirv` targets, so it should be easy to make `-cl-e

[clang] [Clang] Add support for missing OpenCL extensions (PR #129777)

2025-03-05 Thread Sven van Haastregt via cfe-commits
svenvh wrote: > @svenvh, I'm trying to unify the extensions enablement in the user interface. > We can enable or disable some of the extensions with the `-Xclang > -cl-ext=+extension` command line options. For example, a user can pass > `-Xclang -cl-ext=+cl_khr_subgroups` successfully, but the

[clang] [HLSL] error on out of bounds vector accesses (PR #128952)

2025-03-05 Thread Sven van Haastregt via cfe-commits
@@ -14017,6 +14017,24 @@ void Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) { << TRange << Op->getSourceRange(); } +void Sema::CheckVectorAccess(const Expr *BaseExpr, const Expr *IndexExpr) { + const VectorType *VTy = BaseExpr->getType()->getAs(); + if

[clang] clang: Do not implicitly addrspacecast in EmitAggExprToLValue (PR #129837)

2025-03-05 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh approved this pull request. https://github.com/llvm/llvm-project/pull/129837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add support for missing OpenCL extensions (PR #129777)

2025-03-05 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh requested changes to this pull request. What is the motivation for this change? We are trying to move away from adding extensions to this file for extensions that only add builtin functions, see e.g. https://reviews.llvm.org/D92231 . What functionality are you gainin

[clang] [HLSL] error on out of bounds vector accesses (PR #128952)

2025-02-27 Thread Sven van Haastregt via cfe-commits
@@ -14017,6 +14017,24 @@ void Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) { << TRange << Op->getSourceRange(); } +void Sema::CheckVectorAccess(const Expr *BaseExpr, const Expr *IndexExpr) { + const VectorType *VTy = BaseExpr->getType()->getAs(); + if

[clang] [OpenCL] Diagnose block references in selection operator (PR #114824)

2025-01-22 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh closed https://github.com/llvm/llvm-project/pull/114824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenCL] Diagnose block references in selection operator (PR #114824)

2025-01-21 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh updated https://github.com/llvm/llvm-project/pull/114824 >From 20c2eacae61d245384db226d3dfe53628b4b2ba8 Mon Sep 17 00:00:00 2001 From: Sven van Haastregt Date: Mon, 4 Nov 2024 13:36:04 + Subject: [PATCH] [OpenCL] Diagnose block references in selection operator In

[clang] [clang][Driver][SPIR-V] Make tool names consistent (PR #122343)

2025-01-10 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh approved this pull request. LGTM, thanks; good to see consistent naming! https://github.com/llvm/llvm-project/pull/122343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [Driver][SPIR-V] Use consistent tools to convert between text and binary form (PR #120266)

2025-01-09 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh approved this pull request. https://github.com/llvm/llvm-project/pull/120266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][SPIR-V] Use consistent tools to convert between text and binary form (PR #120266)

2025-01-08 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh requested changes to this pull request. Thanks for drawing this to my attention! The output produced by llvm-spirv's `-to-text` is an internal textual format, intended for testing llvm-spirv only (@MrSidims please correct me if I'm wrong). I don't think we should be

[clang] 9cdb7d2 - [NFC] Maintainers.rst: align email address formatting

2024-12-11 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2024-12-11T08:51:44Z New Revision: 9cdb7d2b6c333874ec969ef6ac64e0354bb3aa91 URL: https://github.com/llvm/llvm-project/commit/9cdb7d2b6c333874ec969ef6ac64e0354bb3aa91 DIFF: https://github.com/llvm/llvm-project/commit/9cdb7d2b6c333874ec969ef6ac64e0354bb3aa91.diff

[clang] Nominating Sven van Haastregt as OpenCL maintainer in Clang (PR #119383)

2024-12-10 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh approved this pull request. Sorry to see you stepping down, thank you for all your contributions over the years! Thanks for the nomination, I gladly accept. https://github.com/llvm/llvm-project/pull/119383 ___ cfe-commits ma

[clang] [clang][bytecode] Not all null pointers are 0 (PR #118601)

2024-12-04 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh commented: LGTM, but I'm not an expert in this area so I'll leave the formal approval to someone else. https://github.com/llvm/llvm-project/pull/118601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] [clang][bytecode] Not all null pointers are 0 (PR #118601)

2024-12-04 Thread Sven van Haastregt via cfe-commits
@@ -0,0 +1,12 @@ +// RUN: %clang_cc1 -no-enable-noundef-analysis %s -cl-std=CL2.0 -include opencl-c.h -triple amdgcn -emit-llvm -o - | FileCheck %s svenvh wrote: I don't think you need the `-include opencl-c.h` for this test? (it's rather big, so slows down tes

[clang] [OpenCL] Diagnose block references in selection operator (PR #114824)

2024-11-04 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh edited https://github.com/llvm/llvm-project/pull/114824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenCL] Diagnose block references in selection operator (PR #114824)

2024-11-04 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh created https://github.com/llvm/llvm-project/pull/114824 In addition to the invocation case that is already diagnosed, also diagnose when a block reference appears on either side of a ternary selection operator. >From 386b891dce07f37d3b886008f42160e7224f6e4c Mon Sep 1

[clang] [OpenCL] Add cl_ext_image_unorm_int_2_101010_EXT extension (PR #113145)

2024-10-21 Thread Sven van Haastregt via cfe-commits
svenvh wrote: Extension specification: https://github.com/KhronosGroup/OpenCL-Docs/pull/1223 https://github.com/llvm/llvm-project/pull/113145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] [OpenCL] Add cl_ext_image_unorm_int_2_101010_EXT extension (PR #113145)

2024-10-21 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh created https://github.com/llvm/llvm-project/pull/113145 Add the defines for the `cl_ext_image_unorm_int_2_101010_EXT` extension. >From 168a54775bb876094fe90ef89cab66b8cc08e4f3 Mon Sep 17 00:00:00 2001 From: Sven van Haastregt Date: Mon, 21 Oct 2024 11:19:13 +0100 Sub

[clang] [OpenCL] Replace a CreatePointerCast call; NFC (PR #112676)

2024-10-18 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh closed https://github.com/llvm/llvm-project/pull/112676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenCL] Replace a CreatePointerCast call; NFC (PR #112676)

2024-10-17 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh created https://github.com/llvm/llvm-project/pull/112676 With opaque pointers, the only purpose of the cast here is to cast between address spaces, similar to the 4-argument case below. >From 7dff616c6cd8ffb2c58e26132370f9329a0bf4cd Mon Sep 17 00:00:00 2001 From: Sven

[clang] [OpenCL] Restore addrspacecast for pipe builtins and update test (PR #112514)

2024-10-16 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh closed https://github.com/llvm/llvm-project/pull/112514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenCL] Restore addrspacecast for pipe builtins and update test (PR #112514)

2024-10-16 Thread Sven van Haastregt via cfe-commits
@@ -1,69 +1,67 @@ -// RUN: %clang_cc1 -triple %itanium_abi_triple -emit-llvm -cl-ext=+cl_khr_subgroups -O0 -cl-std=clc++ -o - %s | FileCheck %s -// FIXME: Add MS ABI manglings of OpenCL things and remove %itanium_abi_triple svenvh wrote: Surely I can add the old

[clang] [OpenCL] Restore addrspacecast for pipe builtins and update test (PR #112514)

2024-10-16 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh created https://github.com/llvm/llvm-project/pull/112514 Commit 84ee629bc515 ("clang: Remove some pointer bitcasts (#112324)", 2024-10-15) triggered some "Call parameter type does not match function signature!" errors when using the OpenCL pipe builtin functions under

[clang] [TableGen] Avoid repeated hash lookups (NFC) (PR #109372)

2024-09-20 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh approved this pull request. https://github.com/llvm/llvm-project/pull/109372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TableGen] Change OpenCL emitter to use const RecordKeeper (PR #108213)

2024-09-11 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh approved this pull request. https://github.com/llvm/llvm-project/pull/108213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Tablegen] Avoid repeated hash lookps (NFC) (PR #107961)

2024-09-10 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh approved this pull request. https://github.com/llvm/llvm-project/pull/107961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

2024-07-25 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh approved this pull request. https://github.com/llvm/llvm-project/pull/97342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

2024-07-24 Thread Sven van Haastregt via cfe-commits
@@ -1,6 +1,6 @@ // RUN: %clang_cc1 %s -emit-llvm -o - | FileCheck %s -check-prefix=NORMAL // RUN: %clang_cc1 %s -emit-llvm -cl-fast-relaxed-math -o - | FileCheck %s -check-prefix=FAST -// RUN: %clang_cc1 %s -emit-llvm -cl-finite-math-only -o - | FileCheck %s -check-prefix=FINI

[clang] [OpenCL] Emit opencl.cxx.version metadata for C++ (PR #92140)

2024-07-03 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh closed https://github.com/llvm/llvm-project/pull/92140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reject half vector types without cl_khr_fp16 (PR #96640)

2024-06-25 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh created https://github.com/llvm/llvm-project/pull/96640 Reject `half` vector types (`halfn`) if the `cl_khr_fp16` extension is disabled, in line with the already existing rejection of `half` scalar types and `half` array types. >From e26114f1aa6809e7b5f93f4e866e7ff25

[clang] [SPIR-V] Prefer llvm-spirv- tool (PR #77897)

2024-05-31 Thread Sven van Haastregt via cfe-commits
Henry =?utf-8?q?Linjamäki?= Message-ID: In-Reply-To: https://github.com/svenvh closed https://github.com/llvm/llvm-project/pull/77897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SPIR-V] Prefer llvm-spirv- tool (PR #77897)

2024-05-31 Thread Sven van Haastregt via cfe-commits
Henry =?utf-8?q?Linjamäki?= Message-ID: In-Reply-To: svenvh wrote: > Ping, @svenvh. The patch has been rebased, good for landing? Thanks for the ping, it seems github didn't send me a notification when you rebased. Just waiting for the final checks to complete, then I'll merge it. https://

[clang] [SPIR-V] Prefer llvm-spirv- tool (PR #77897)

2024-05-24 Thread Sven van Haastregt via cfe-commits
Henry =?utf-8?q?Linjamäki?= Message-ID: In-Reply-To: svenvh wrote: > Thanks for the review. Could you merge this PR on my behalf (I don't have > write access)? Yes I am happy to do so, but would you mind rebasing this PR onto latest `main` first? Just so that the checks can run again to av

[clang] [OpenCL] Add cl_khr_kernel_clock builtins (PR #91950)

2024-05-20 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh closed https://github.com/llvm/llvm-project/pull/91950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenCL] Put constant initializer globals into constant addrspace (PR #90048)

2024-05-17 Thread Sven van Haastregt via cfe-commits
@@ -535,20 +535,23 @@ void AggExprEmitter::EmitArrayInit(Address DestPtr, llvm::ArrayType *AType, elementType.isTriviallyCopyableType(CGF.getContext())) { CodeGen::CodeGenModule &CGM = CGF.CGM; ConstantEmitter Emitter(CGF); -LangAS AS = ArrayQTy.getAddressSpa

[clang] [SPIR-V] Prefer llvm-spirv- tool (PR #77897)

2024-05-16 Thread Sven van Haastregt via cfe-commits
Henry =?utf-8?q?Linjam=C3=A4ki?= Message-ID: In-Reply-To: https://github.com/svenvh approved this pull request. https://github.com/llvm/llvm-project/pull/77897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [OpenCL] Emit opencl.cxx.version metadata for C++ (PR #92140)

2024-05-14 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh created https://github.com/llvm/llvm-project/pull/92140 Currently there is no way to tell whether an IR module was generated using `-cl-std=cl3.0` or `-cl-std=clc++2021`, i.e., whether the origin was a OpenCL C or C++ for OpenCL source. Add new `opencl.cxx.version` n

[clang] [libclc] [llvm] [openmp] [Clang] `__attribute__((assume))` refactor (PR #84934)

2024-05-14 Thread Sven van Haastregt via cfe-commits
svenvh wrote: > It allows the source to be parsed, but then I don't see the attribute in the > LLVM IR generated for libclc. You will need to also convert the attribute into an LLVM IR construct (e.g. metadata) in Clang CodeGen. See `CodeGenFunction::EmitKernelMetadata` for inspiration for e

[clang] [OpenCL] Add cl_khr_kernel_clock builtins (PR #91950)

2024-05-13 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh created https://github.com/llvm/llvm-project/pull/91950 Provisional extension description: https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_API.html#cl_khr_kernel_clock and https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_C.html#kerne

[clang] [libclc] [llvm] [openmp] [Clang] `__attribute__((assume))` refactor (PR #84934)

2024-05-08 Thread Sven van Haastregt via cfe-commits
svenvh wrote: The libclc usage seems to have been added by @rjodinchr in https://reviews.llvm.org/D147773 (and approved by @alan-baker). Perhaps they have an opinion? https://github.com/llvm/llvm-project/pull/84934 ___ cfe-commits mailing list cfe-c

[clang] [OpenCL] Put constant initializer globals into constant addrspace (PR #90048)

2024-05-02 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh closed https://github.com/llvm/llvm-project/pull/90048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenCL] Put constant initializer globals into constant addrspace (PR #90048)

2024-04-30 Thread Sven van Haastregt via cfe-commits
@@ -535,20 +535,24 @@ void AggExprEmitter::EmitArrayInit(Address DestPtr, llvm::ArrayType *AType, elementType.isTriviallyCopyableType(CGF.getContext())) { CodeGen::CodeGenModule &CGM = CGF.CGM; ConstantEmitter Emitter(CGF); -LangAS AS = ArrayQTy.getAddressSpa

[clang] [OpenCL] Put constant initializer globals into constant addrspace (PR #90048)

2024-04-30 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh updated https://github.com/llvm/llvm-project/pull/90048 >From c5e7b2d5936a7317ebc33159b4cb72bf2aa66cf9 Mon Sep 17 00:00:00 2001 From: Sven van Haastregt Date: Thu, 25 Apr 2024 14:10:19 +0100 Subject: [PATCH 1/4] [OpenCL] Put constant initializer globals into constant

[clang] [OpenCL] Put constant initializer globals into constant addrspace (PR #90048)

2024-04-29 Thread Sven van Haastregt via cfe-commits
@@ -536,6 +536,8 @@ void AggExprEmitter::EmitArrayInit(Address DestPtr, llvm::ArrayType *AType, CodeGen::CodeGenModule &CGM = CGF.CGM; ConstantEmitter Emitter(CGF); LangAS AS = ArrayQTy.getAddressSpace(); +if (CGF.getLangOpts().OpenCL) + AS = LangAS::openc

[clang] [OpenCL] Put constant initializer globals into constant addrspace (PR #90048)

2024-04-29 Thread Sven van Haastregt via cfe-commits
@@ -536,6 +536,8 @@ void AggExprEmitter::EmitArrayInit(Address DestPtr, llvm::ArrayType *AType, CodeGen::CodeGenModule &CGM = CGF.CGM; ConstantEmitter Emitter(CGF); LangAS AS = ArrayQTy.getAddressSpace(); +if (CGF.getLangOpts().OpenCL) + AS = LangAS::openc

[clang] [OpenCL] Put constant initializer globals into constant addrspace (PR #90048)

2024-04-29 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh updated https://github.com/llvm/llvm-project/pull/90048 >From c5e7b2d5936a7317ebc33159b4cb72bf2aa66cf9 Mon Sep 17 00:00:00 2001 From: Sven van Haastregt Date: Thu, 25 Apr 2024 14:10:19 +0100 Subject: [PATCH 1/3] [OpenCL] Put constant initializer globals into constant

[clang] [OpenCL] Put constant initializer globals into constant addrspace (PR #90048)

2024-04-26 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh updated https://github.com/llvm/llvm-project/pull/90048 >From c5e7b2d5936a7317ebc33159b4cb72bf2aa66cf9 Mon Sep 17 00:00:00 2001 From: Sven van Haastregt Date: Thu, 25 Apr 2024 14:10:19 +0100 Subject: [PATCH 1/2] [OpenCL] Put constant initializer globals into constant

[clang] [OpenCL] Put constant initializer globals into constant addrspace (PR #90048)

2024-04-26 Thread Sven van Haastregt via cfe-commits
@@ -536,6 +536,8 @@ void AggExprEmitter::EmitArrayInit(Address DestPtr, llvm::ArrayType *AType, CodeGen::CodeGenModule &CGM = CGF.CGM; ConstantEmitter Emitter(CGF); LangAS AS = ArrayQTy.getAddressSpace(); +if (CGF.getLangOpts().OpenCL) + AS = LangAS::openc

[clang] [OpenCL] Put constant initializer globals into constant addrspace (PR #90048)

2024-04-26 Thread Sven van Haastregt via cfe-commits
@@ -536,6 +536,8 @@ void AggExprEmitter::EmitArrayInit(Address DestPtr, llvm::ArrayType *AType, CodeGen::CodeGenModule &CGM = CGF.CGM; ConstantEmitter Emitter(CGF); LangAS AS = ArrayQTy.getAddressSpace(); +if (CGF.getLangOpts().OpenCL) + AS = LangAS::openc

[clang] [OpenCL] Put constant initializer globals into constant addrspace (PR #90048)

2024-04-25 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh created https://github.com/llvm/llvm-project/pull/90048 Place constant initializer globals into the constant address space. Clang generates such globals for e.g. larger array member initializers of classes and then emits copy operations from the global to the object(s

[clang] [OpenCL] Fix BIenqueue_kernel fallthrough (PR #83238)

2024-04-02 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh closed https://github.com/llvm/llvm-project/pull/83238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c7f1a98 - [OpenCL] Elaborate about BIenqueue_kernel expansion; NFC

2024-03-12 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2024-03-12T12:53:22Z New Revision: c7f1a987a66a1ba0865ecc18adbe4dc8dbc0c788 URL: https://github.com/llvm/llvm-project/commit/c7f1a987a66a1ba0865ecc18adbe4dc8dbc0c788 DIFF: https://github.com/llvm/llvm-project/commit/c7f1a987a66a1ba0865ecc18adbe4dc8dbc0c788.diff

[clang] [OpenCL] Fix BIenqueue_kernel fallthrough (PR #83238)

2024-02-28 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh created https://github.com/llvm/llvm-project/pull/83238 Handling of the `BIenqueue_kernel` builtin must not fallthrough to the `BIget_kernel_work_group_size` builtin, as these builtins have no common functionality. >From a7375b651a2ec392e0edf4cbe3658981f56ea67a Mon S

[clang] [clang] Use CPlusPlus language option instead of Bool (PR #80975)

2024-02-08 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh approved this pull request. The side-effect on OpenCL looks good to me; thanks! https://github.com/llvm/llvm-project/pull/80975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] 7f00389 - [OpenCL] Fix grammar in test error messages; NFC

2023-08-07 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2023-08-07T13:45:23+01:00 New Revision: 7f00389e7792d585cdda615324ebc094fa3c4247 URL: https://github.com/llvm/llvm-project/commit/7f00389e7792d585cdda615324ebc094fa3c4247 DIFF: https://github.com/llvm/llvm-project/commit/7f00389e7792d585cdda615324ebc094fa3c4247.

[clang] 5e8b44c - [OpenCL] Add cl_ext_image_raw10_raw12 extension

2023-07-26 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2023-07-26T11:59:12+01:00 New Revision: 5e8b44cc447e9b901c8168825f0c77491d9111e8 URL: https://github.com/llvm/llvm-project/commit/5e8b44cc447e9b901c8168825f0c77491d9111e8 DIFF: https://github.com/llvm/llvm-project/commit/5e8b44cc447e9b901c8168825f0c77491d9111e8.

[clang] 5952664 - [OpenCL] Add CLK_UNORM_INT_101010_2 channel type

2023-06-01 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2023-06-01T16:21:54+01:00 New Revision: 595266456a3067f522081d6d8069df2a98adfa16 URL: https://github.com/llvm/llvm-project/commit/595266456a3067f522081d6d8069df2a98adfa16 DIFF: https://github.com/llvm/llvm-project/commit/595266456a3067f522081d6d8069df2a98adfa16.

[clang] f454a7c - [OpenCL] Emit EOL at end of generated header

2023-03-24 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2023-03-24T11:03:10Z New Revision: f454a7c6853def66c4f3a68bd2a0520489f6833c URL: https://github.com/llvm/llvm-project/commit/f454a7c6853def66c4f3a68bd2a0520489f6833c DIFF: https://github.com/llvm/llvm-project/commit/f454a7c6853def66c4f3a68bd2a0520489f6833c.diff

[clang] 4cb843d - [OpenCL] Add builtin header TableGen emitter

2023-03-09 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2023-03-09T10:20:04Z New Revision: 4cb843d099422e5d77d0f7e16cbb18ee64d457a5 URL: https://github.com/llvm/llvm-project/commit/4cb843d099422e5d77d0f7e16cbb18ee64d457a5 DIFF: https://github.com/llvm/llvm-project/commit/4cb843d099422e5d77d0f7e16cbb18ee64d457a5.diff

[clang] 1495210 - [OpenCL] Always add nounwind attribute for OpenCL

2023-01-20 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2023-01-20T12:01:22Z New Revision: 1495210914997bcd0ca6937be0ae3cd6809b5ef5 URL: https://github.com/llvm/llvm-project/commit/1495210914997bcd0ca6937be0ae3cd6809b5ef5 DIFF: https://github.com/llvm/llvm-project/commit/1495210914997bcd0ca6937be0ae3cd6809b5ef5.diff

[clang] a60b8f4 - [OpenCL] Allow undefining header-only features

2023-01-16 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2023-01-16T11:32:12Z New Revision: a60b8f468119065f8a6cb4a16598263cb00de0b5 URL: https://github.com/llvm/llvm-project/commit/a60b8f468119065f8a6cb4a16598263cb00de0b5 DIFF: https://github.com/llvm/llvm-project/commit/a60b8f468119065f8a6cb4a16598263cb00de0b5.diff

[clang] b0e4897 - [OpenCL] Remove arm-integer-dot-product extension pragmas

2022-11-29 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-11-29T13:26:50Z New Revision: b0e4897a1bd2ea5eeeb8c104e32df1402a397ac1 URL: https://github.com/llvm/llvm-project/commit/b0e4897a1bd2ea5eeeb8c104e32df1402a397ac1 DIFF: https://github.com/llvm/llvm-project/commit/b0e4897a1bd2ea5eeeb8c104e32df1402a397ac1.diff

[clang] 0f4f246 - [OpenCL] Guard read_write image3d with cl_khr_3d_image_writes

2022-11-09 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-11-09T13:17:59Z New Revision: 0f4f246783fa5866f6fa5db4043e898060cdf98d URL: https://github.com/llvm/llvm-project/commit/0f4f246783fa5866f6fa5db4043e898060cdf98d DIFF: https://github.com/llvm/llvm-project/commit/0f4f246783fa5866f6fa5db4043e898060cdf98d.diff

[clang] 5a7764c - [OpenCL] Guard depth image builtins

2022-09-13 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-09-13T10:10:48+01:00 New Revision: 5a7764c9ff5db8c460b52bc2dec95d19df44d4c8 URL: https://github.com/llvm/llvm-project/commit/5a7764c9ff5db8c460b52bc2dec95d19df44d4c8 DIFF: https://github.com/llvm/llvm-project/commit/5a7764c9ff5db8c460b52bc2dec95d19df44d4c8.

[clang] f2c17a1 - [OpenCL] Remove argument names from atomic/fence builtins

2022-09-06 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-09-06T10:50:57+01:00 New Revision: f2c17a130a27cadd9d204bef09fd4ad64518c9da URL: https://github.com/llvm/llvm-project/commit/f2c17a130a27cadd9d204bef09fd4ad64518c9da DIFF: https://github.com/llvm/llvm-project/commit/f2c17a130a27cadd9d204bef09fd4ad64518c9da.

[clang] f8e658e - [OpenCL] Remove fast_ half geometric builtins

2022-07-05 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-07-05T10:22:34+01:00 New Revision: f8e658ec9ff5b82d0c1f9d54d78c137b539319ca URL: https://github.com/llvm/llvm-project/commit/f8e658ec9ff5b82d0c1f9d54d78c137b539319ca DIFF: https://github.com/llvm/llvm-project/commit/f8e658ec9ff5b82d0c1f9d54d78c137b539319ca.

[clang] 1d421e6 - [OpenCL] Remove half scalar vload/vstore builtins

2022-06-30 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-06-30T11:01:19+01:00 New Revision: 1d421e6e3b789ede2f61756a72e2b27456f868e3 URL: https://github.com/llvm/llvm-project/commit/1d421e6e3b789ede2f61756a72e2b27456f868e3 DIFF: https://github.com/llvm/llvm-project/commit/1d421e6e3b789ede2f61756a72e2b27456f868e3.

[clang] 663e47a - [OpenCL] Reduce emitting candidate notes for builtins

2022-06-27 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-06-27T09:55:44+01:00 New Revision: 663e47a50f50c9ff0da9ba805f804c06645638ed URL: https://github.com/llvm/llvm-project/commit/663e47a50f50c9ff0da9ba805f804c06645638ed DIFF: https://github.com/llvm/llvm-project/commit/663e47a50f50c9ff0da9ba805f804c06645638ed.

[clang] 8c3fa31 - [OpenCL][TableGen] Fix type extension guard emission

2022-06-20 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-06-20T10:07:34+01:00 New Revision: 8c3fa31701c4b874138c52266e7ab96818092f47 URL: https://github.com/llvm/llvm-project/commit/8c3fa31701c4b874138c52266e7ab96818092f47 DIFF: https://github.com/llvm/llvm-project/commit/8c3fa31701c4b874138c52266e7ab96818092f47.

[clang] 2d9c891 - [OpenCL] Fix atomic_fetch_add/sub half overloads

2022-06-17 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-06-17T09:53:45+01:00 New Revision: 2d9c891cd949a4e6f15c35bd565b3d3588819e85 URL: https://github.com/llvm/llvm-project/commit/2d9c891cd949a4e6f15c35bd565b3d3588819e85 DIFF: https://github.com/llvm/llvm-project/commit/2d9c891cd949a4e6f15c35bd565b3d3588819e85.

[clang] 7acc88b - [OpenCL] Reword unknown extension pragma diagnostic

2022-06-15 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-06-15T10:54:46+01:00 New Revision: 7acc88be0312c721bc082ed9934e381d297f4707 URL: https://github.com/llvm/llvm-project/commit/7acc88be0312c721bc082ed9934e381d297f4707 DIFF: https://github.com/llvm/llvm-project/commit/7acc88be0312c721bc082ed9934e381d297f4707.

[clang] a5cf17f - [OpenCL] Expose wg collective functions for CL3 SPIR targets

2022-05-30 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-05-30T10:48:49+01:00 New Revision: a5cf17f8ae752f1b62b40b907bfee4faa3600b21 URL: https://github.com/llvm/llvm-project/commit/a5cf17f8ae752f1b62b40b907bfee4faa3600b21 DIFF: https://github.com/llvm/llvm-project/commit/a5cf17f8ae752f1b62b40b907bfee4faa3600b21.

[clang] 0d7f8d4 - [OpenCL] Remove argument names from async copy builtins

2022-05-25 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-05-25T10:05:25+01:00 New Revision: 0d7f8d42fd170a434006a928a7106b894bdbdd16 URL: https://github.com/llvm/llvm-project/commit/0d7f8d42fd170a434006a928a7106b894bdbdd16 DIFF: https://github.com/llvm/llvm-project/commit/0d7f8d42fd170a434006a928a7106b894bdbdd16.

[clang] 21c29a8 - [OpenCL] Add cl_khr_subgroup_rotate builtins

2022-05-18 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-05-18T13:02:17+01:00 New Revision: 21c29a8ae053cb436141ee636333c4f816cc20c4 URL: https://github.com/llvm/llvm-project/commit/21c29a8ae053cb436141ee636333c4f816cc20c4 DIFF: https://github.com/llvm/llvm-project/commit/21c29a8ae053cb436141ee636333c4f816cc20c4.

[clang] b250cca - [OpenCL] Do not guard vload/store_half builtins

2022-05-17 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-05-17T10:57:23+01:00 New Revision: b250cca11d5996ed01d72cb1f933867da0e8d5e0 URL: https://github.com/llvm/llvm-project/commit/b250cca11d5996ed01d72cb1f933867da0e8d5e0 DIFF: https://github.com/llvm/llvm-project/commit/b250cca11d5996ed01d72cb1f933867da0e8d5e0.

[clang] 87a2583 - [OpenCL] Guard read_write images with TypeExtension

2022-04-21 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-04-21T10:52:41+01:00 New Revision: 87a258366e5d4f3786c6c2b9fe5dbeb736def909 URL: https://github.com/llvm/llvm-project/commit/87a258366e5d4f3786c6c2b9fe5dbeb736def909 DIFF: https://github.com/llvm/llvm-project/commit/87a258366e5d4f3786c6c2b9fe5dbeb736def909.

[clang] e67b1b0 - [OpenCL] Add missing __opencl_c_atomic_scope_device guards

2022-04-20 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-04-20T11:02:50+01:00 New Revision: e67b1b0ccf520a0168758d116e88f63160812e99 URL: https://github.com/llvm/llvm-project/commit/e67b1b0ccf520a0168758d116e88f63160812e99 DIFF: https://github.com/llvm/llvm-project/commit/e67b1b0ccf520a0168758d116e88f63160812e99.

[clang] f3ee0af - [OpenCL] opencl-c.h: Add const to get_image_num_samples

2022-04-19 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-04-19T10:16:44+01:00 New Revision: f3ee0afc6739bf2990f9d302ff6b28dbb0429e8d URL: https://github.com/llvm/llvm-project/commit/f3ee0afc6739bf2990f9d302ff6b28dbb0429e8d DIFF: https://github.com/llvm/llvm-project/commit/f3ee0afc6739bf2990f9d302ff6b28dbb0429e8d.

[clang] bb6f8d9 - [OpenCL] Add device enqueue guards for DSE builtins

2022-04-11 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-04-11T11:27:51+01:00 New Revision: bb6f8d9a93ef0172f227b04c92e7bbb703641a79 URL: https://github.com/llvm/llvm-project/commit/bb6f8d9a93ef0172f227b04c92e7bbb703641a79 DIFF: https://github.com/llvm/llvm-project/commit/bb6f8d9a93ef0172f227b04c92e7bbb703641a79.

[clang] 1331ad2 - [OpenCL] Add generic addrspace guards for get_fence

2022-04-08 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-04-08T12:08:10+01:00 New Revision: 1331ad22c31fc2ed6890fa046c1e2333e369251b URL: https://github.com/llvm/llvm-project/commit/1331ad22c31fc2ed6890fa046c1e2333e369251b DIFF: https://github.com/llvm/llvm-project/commit/1331ad22c31fc2ed6890fa046c1e2333e369251b.

[clang] 77c74fd - [OpenCL] Remove argument names from math builtins

2022-04-06 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-04-06T11:43:59+01:00 New Revision: 77c74fd877b27418171693f187b8db865567b8dc URL: https://github.com/llvm/llvm-project/commit/77c74fd877b27418171693f187b8db865567b8dc DIFF: https://github.com/llvm/llvm-project/commit/77c74fd877b27418171693f187b8db865567b8dc.

[clang] 4dfec37 - [OpenCL] Set MinVersion for sub_group_barrier with memory_scope

2022-03-31 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-03-31T16:41:40+01:00 New Revision: 4dfec37037f5f96db8898b79601c7a1d19177027 URL: https://github.com/llvm/llvm-project/commit/4dfec37037f5f96db8898b79601c7a1d19177027 DIFF: https://github.com/llvm/llvm-project/commit/4dfec37037f5f96db8898b79601c7a1d19177027.

[clang] de30408 - [OpenCL] opencl-c.h: remove a/b/c/i/p/n/v arg names

2022-03-29 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-03-29T10:16:27+01:00 New Revision: de30408b3b0a012f902b8565fa0b7625c1d5fec6 URL: https://github.com/llvm/llvm-project/commit/de30408b3b0a012f902b8565fa0b7625c1d5fec6 DIFF: https://github.com/llvm/llvm-project/commit/de30408b3b0a012f902b8565fa0b7625c1d5fec6.

[clang] 73e1888 - [OpenCL] Guard write_only image3d_t with TypeExtension

2022-03-21 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-03-21T12:45:58Z New Revision: 73e1888e530afefd4a9a774ef9c29bf24baca3d4 URL: https://github.com/llvm/llvm-project/commit/73e1888e530afefd4a9a774ef9c29bf24baca3d4 DIFF: https://github.com/llvm/llvm-project/commit/73e1888e530afefd4a9a774ef9c29bf24baca3d4.diff

[clang] b48e3c8 - [OpenCL] opencl-c.h: Fix incorrect get_image_width guard

2022-02-25 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-02-25T11:05:56Z New Revision: b48e3c805c253d0a1194bede81b3f8e225f40824 URL: https://github.com/llvm/llvm-project/commit/b48e3c805c253d0a1194bede81b3f8e225f40824 DIFF: https://github.com/llvm/llvm-project/commit/b48e3c805c253d0a1194bede81b3f8e225f40824.diff

[clang-tools-extra] ba18c36 - [clang-tidy] Remove opencl-c.h inclusion from tests

2022-02-24 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-02-24T16:28:52Z New Revision: ba18c360b2f3c25fe9091c7a7931eded374b3cf6 URL: https://github.com/llvm/llvm-project/commit/ba18c360b2f3c25fe9091c7a7931eded374b3cf6 DIFF: https://github.com/llvm/llvm-project/commit/ba18c360b2f3c25fe9091c7a7931eded374b3cf6.diff

[clang] 28cdcf8 - [OpenCL] Handle TypeExtensions in OpenCLBuiltinFileEmitter

2022-02-24 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-02-24T15:17:24Z New Revision: 28cdcf8e3c8e6c51d42051b54f67c6920b5d8cf3 URL: https://github.com/llvm/llvm-project/commit/28cdcf8e3c8e6c51d42051b54f67c6920b5d8cf3 DIFF: https://github.com/llvm/llvm-project/commit/28cdcf8e3c8e6c51d42051b54f67c6920b5d8cf3.diff

[clang] 88182e2 - [OpenCL] opencl-c.h: remove arg names for image builtins

2022-02-24 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-02-24T11:52:32Z New Revision: 88182e2dfde295a8f6adc9e6148410e86c71680d URL: https://github.com/llvm/llvm-project/commit/88182e2dfde295a8f6adc9e6148410e86c71680d DIFF: https://github.com/llvm/llvm-project/commit/88182e2dfde295a8f6adc9e6148410e86c71680d.diff

[clang] aa9c2d1 - [OpenCL] Align subgroup builtin guards

2022-02-23 Thread Sven van Haastregt via cfe-commits
Author: Sven van Haastregt Date: 2022-02-23T12:22:09Z New Revision: aa9c2d19d9b73589d72114d6e0a4fb4ce42b922b URL: https://github.com/llvm/llvm-project/commit/aa9c2d19d9b73589d72114d6e0a4fb4ce42b922b DIFF: https://github.com/llvm/llvm-project/commit/aa9c2d19d9b73589d72114d6e0a4fb4ce42b922b.diff

  1   2   3   >