sukraat91 added inline comments.
Comment at:
clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp:66
+bool isPassedToStdMove(const ParmVarDecl &Param, ASTContext &Context) {
+ // Check if the parameter has a name, in case of functions like -
---
sukraat91 updated this revision to Diff 292669.
sukraat91 added a comment.
Address comments to remove top level `const auto` in the helper function to
check if the argument is being moved, and replace it with its type spelled out.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87540/new/
sukraat91 updated this revision to Diff 291334.
sukraat91 added a comment.
Updated patch to contain changes to variable case from `paramName` to
`ParamName`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87540/new/
https://reviews.llvm.org/D87540
Files:
clang-tools-extra/clang-tidy/
sukraat91 updated this revision to Diff 291326.
sukraat91 added a comment.
Revert to older commit.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87540/new/
https://reviews.llvm.org/D87540
Files:
clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp
clang-tools-ex
sukraat91 updated this revision to Diff 291322.
sukraat91 added a comment.
Changed the case for the first character in variable `paramName` from lowercase
to uppercase, to pass pre-merge checks.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87540/new/
https://reviews.llvm.org/D87540
F
sukraat91 created this revision.
sukraat91 added a reviewer: clang-tools-extra.
Herald added subscribers: cfe-commits, xazax.hun.
Herald added a project: clang.
sukraat91 requested review of this revision.
This patch solves a bug (https://bugs.llvm.org/show_bug.cgi?id=44598) that was
filed for a
