https://github.com/cachemeifyoucan approved this pull request.
LGTM. Thanks for looking into the question I have. I slightly prefer if it is
an option, making your platform either be darwin, or be entirely not darwin.
But since you only need test update, I am ok with it since it doesn't make th
cachemeifyoucan wrote:
Do you have a bot or build to point to for test failures?
There is no way to disable Darwin target from clang driver. I think the test
might be related to the host platform is not Darwin so the driver didn't infer
the target correctly without a default target triple?
I
@@ -18,7 +18,7 @@
// RUN: c-index-test -test-load-source local %s -include %t.clang.h -fmodules
-fmodules-cache-path=%t.mcp -Xclang -triple -Xclang x86_64-apple-darwin |
FileCheck %s
// FIXME: Still fails on at least some linux boxen.
-// REQUIRES: system-darwin
+// REQUIRES
https://github.com/cachemeifyoucan commented:
I think the fix makes sense for a linux toolchain running on Darwin. I am still
surprised that you have a "system-darwin" platform where you don't want the
default target triple to be darwin.
I am ok with the fix but it will be good to update the R
https://github.com/cachemeifyoucan edited
https://github.com/llvm/llvm-project/pull/130138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cachemeifyoucan wrote:
@adrian-prantl for the debug directory option since that might interact how
debugger working with the option.
I think we need a solution approved by debugger forks for how to avoid stamping
CWD into debug info and when it is safe to do so (for example, we guarantee all
cachemeifyoucan wrote:
> This is clearer as we are currently only going to distribute the ThinLTO part
> and have no plans to distribute the FullLTO part. Making the name more
> general could confuse users who might then expect in e.g., a mixed Thin+Full
> link that the Full bitcode part would
https://github.com/cachemeifyoucan commented:
Some high level comments:
* Should we just call it distributedLTO, or DLTO? Feel like we can drop the
thin part for less typing, and from the user's point of view, using thinLTO
infrastructure is just implementation details.
* Are you going to imple
https://github.com/cachemeifyoucan closed
https://github.com/llvm/llvm-project/pull/125111
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cachemeifyoucan edited
https://github.com/llvm/llvm-project/pull/124786
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -63,7 +63,10 @@ enum class ScanningOptimizations {
/// Canonicalize -D and -U options.
Macros = 8,
- DSS_LAST_BITMASK_ENUM(Macros),
+ /// Ignore the compiler's working directory if it is safe.
+ IgnoreCWD = 0x10,
cachemeifyoucan wrote:
Nit: maybe up
https://github.com/cachemeifyoucan approved this pull request.
LGTM with some small style comments.
https://github.com/llvm/llvm-project/pull/124786
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
@@ -397,9 +397,91 @@ void
ModuleDepCollector::applyDiscoveredDependencies(CompilerInvocation &CI) {
}
}
+static bool isSafeToIgnoreCWD(const CowCompilerInvocation &CI) {
+ // Check if the command line input uses relative paths.
+ // It is not safe to ignore the current wo
cachemeifyoucan wrote:
Ping.
https://github.com/llvm/llvm-project/pull/125111
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cachemeifyoucan updated
https://github.com/llvm/llvm-project/pull/125111
>From d836f2f5da850f0d985f34253873c6c461606db0 Mon Sep 17 00:00:00 2001
From: Steven Wu
Date: Thu, 30 Jan 2025 11:51:41 -0800
Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
@@ -0,0 +1,111 @@
+// UNSUPPORTED: target=powerpc64-ibm-aix{{.*}}
+
+// RUN: rm -rf %t
+// RUN: split-file %s %t
+
+//--- module.modulemap
+module root { header "root.h" }
+module direct { header "direct.h" }
+module transitive { header "transitive.h" }
+module addition { header "
@@ -0,0 +1,111 @@
+// UNSUPPORTED: target=powerpc64-ibm-aix{{.*}}
+
+// RUN: rm -rf %t
+// RUN: split-file %s %t
+
+//--- module.modulemap
+module root { header "root.h" }
+module direct { header "direct.h" }
+module transitive { header "transitive.h" }
+module addition { header "
https://github.com/cachemeifyoucan created
https://github.com/llvm/llvm-project/pull/125111
Update Dependency scanner so it can scan the dependency of a TU with
a provided buffer rather than relying on the on disk file system to
provide the input file.
>From d836f2f5da850f0d985f34253873c6c4616
https://github.com/cachemeifyoucan commented:
Is it better if this optimization happens really early in the process since you
only visit all the options in CI? In that case, you can just reset the
`CurrentWorkingDirectory` in the VFS so all the searching is done without CWD.
This avoids any ha
https://github.com/cachemeifyoucan approved this pull request.
https://github.com/llvm/llvm-project/pull/124003
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cachemeifyoucan approved this pull request.
https://github.com/llvm/llvm-project/pull/123098
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -121,11 +121,12 @@ def InitPriorityDocs : Documentation {
In C++, the order in which global variables are initialized across translation
units is unspecified, unlike the ordering within a single translation unit. The
``init_priority`` attribute allows you to specify a relati
cachemeifyoucan wrote:
Merged. Thanks for your contribution!
https://github.com/llvm/llvm-project/pull/121231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cachemeifyoucan closed
https://github.com/llvm/llvm-project/pull/121231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cachemeifyoucan wrote:
I updated the title and PR message. Let me know if that looks ok for you.
https://github.com/llvm/llvm-project/pull/121231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cf
https://github.com/cachemeifyoucan edited
https://github.com/llvm/llvm-project/pull/121231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cachemeifyoucan edited
https://github.com/llvm/llvm-project/pull/121231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cachemeifyoucan wrote:
@khyperia Sure, I can help you merge. Code change looks good as I don't see any
open review feedback and no objection from adding the option.
Can you please update the PR message to be a better formatted commit message?
The squash commit will use that as commit message,
@@ -121,11 +121,12 @@ def InitPriorityDocs : Documentation {
In C++, the order in which global variables are initialized across translation
units is unspecified, unlike the ordering within a single translation unit. The
``init_priority`` attribute allows you to specify a relati
@@ -136,12 +137,18 @@ relative ordering of values is important. For example:
``Obj2`` will be initialized *before* ``Obj1`` despite the usual order of
initialization being the opposite.
+Note that this attribute does not control the initialization order of objects
+across fina
https://github.com/cachemeifyoucan closed
https://github.com/llvm/llvm-project/pull/122976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cachemeifyoucan approved this pull request.
This looks much better. Thanks!
https://github.com/llvm/llvm-project/pull/15
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
https://github.com/cachemeifyoucan updated
https://github.com/llvm/llvm-project/pull/122390
>From 1796a6e4fa0492b9676637245a394d3029474d4e Mon Sep 17 00:00:00 2001
From: Steven Wu
Date: Thu, 9 Jan 2025 15:46:06 -0800
Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
https://github.com/cachemeifyoucan created
https://github.com/llvm/llvm-project/pull/122390
Rename `ReadPCHAndPreprocessAction` class. This frontend action is used
for dependency scanning only and the current name is confusing for what
it actually does. Rename the class to `DependencyScanningFro
@@ -1346,14 +1344,30 @@ static void runThinLTOBackend(
}
}
-void clang::EmitBackendOutput(
-DiagnosticsEngine &Diags, const HeaderSearchOptions &HeaderOpts,
-const CodeGenOptions &CGOpts, const clang::TargetOptions &TOpts,
-const LangOptions &LOpts, StringRef TDe
@@ -1346,14 +1344,30 @@ static void runThinLTOBackend(
}
}
-void clang::EmitBackendOutput(
-DiagnosticsEngine &Diags, const HeaderSearchOptions &HeaderOpts,
-const CodeGenOptions &CGOpts, const clang::TargetOptions &TOpts,
-const LangOptions &LOpts, StringRef TDe
https://github.com/cachemeifyoucan approved this pull request.
https://github.com/llvm/llvm-project/pull/121231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cachemeifyoucan wrote:
> I tried to take precedence from -fuse-ld and --ld-path, so -fuse-lipo takes a
> name, and a hypothetical future --lipo-path would be a full path. Perhaps
> these are only named this way due to legacy compatibility though, and new
> naming conventions should be somethin
https://github.com/cachemeifyoucan edited
https://github.com/llvm/llvm-project/pull/121231
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cachemeifyoucan commented:
LGTM in general with a comment in test.
For discussion. Is it better if the option supplies the full path to lipo or
just the name? Full path seems to be easy to use, but might deserve a warning
if the tool doesn't exist.
If just the name, it might
@@ -0,0 +1,11 @@
+// RUN: %clang %s -### --target=arm64-apple-darwin -arch x86_64 -arch arm64
-fuse-lipo=llvm-lipo 2>&1 | FileCheck -check-prefix=TEST1 %s
cachemeifyoucan wrote:
Nit: Add a test case to check when the flag is not supplied.
https://github.com/llv
https://github.com/cachemeifyoucan approved this pull request.
https://github.com/llvm/llvm-project/pull/120149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -43,8 +43,8 @@
// RUN: %clang -target x86_64-apple-macos10.13 -mlinker-version=520 \
// RUN: -### %t.o 2>&1 \
-// RUN: | FileCheck --check-prefix=NOSDK %s
+// RUN: | FileCheck --check-prefix=INFERRED-SDK %s
cachemeifyoucan wrote:
I see. The value of
https://github.com/cachemeifyoucan approved this pull request.
LGTM after addressing the last comment.
https://github.com/llvm/llvm-project/pull/119670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
@@ -43,8 +43,8 @@
// RUN: %clang -target x86_64-apple-macos10.13 -mlinker-version=520 \
// RUN: -### %t.o 2>&1 \
-// RUN: | FileCheck --check-prefix=NOSDK %s
+// RUN: | FileCheck --check-prefix=INFERRED-SDK %s
cachemeifyoucan wrote:
I think you want to
cachemeifyoucan wrote:
> For reference, the failure from dropping `XFAIL` from
> `darwin-ld-platform-version-macos.c`:
>
> Failure Log
> ```
> + /Users/carlocab/github/llvm-project/build-xcselect/bin/FileCheck
> --check-prefix=NOSDK
> /Users/carlocab/github/llvm-project/clang/test/Driver/darw
https://github.com/cachemeifyoucan edited
https://github.com/llvm/llvm-project/pull/119670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2257,17 +2261,25 @@ void Darwin::AddDeploymentTarget(DerivedArgList &Args)
const {
// Warn if the path does not exist.
if (!getVFS().exists(A->getValue()))
getDriver().Diag(clang::diag::warn_missing_sysroot) << A->getValue();
- } else {
-if (char *env =
cachemeifyoucan wrote:
> Is there any reason why default builds don't just use the macOS spelling, at
> least for modern versions of macOS?
I don't think anyone has looked into changing the host guess script. I am ok to
switch to macOS spelling.
> I'm wondering if it's worth reviving the CLAN
https://github.com/cachemeifyoucan commented:
Let's investigate to see all those test failed (many of them have versioned
deployment target).
Maybe it is because the `darwin` legacy OS in the triple? Maybe don't use
`xcselect` when it is darwin since the modern spelling should `macOS` family?
https://github.com/cachemeifyoucan edited
https://github.com/llvm/llvm-project/pull/119670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1,3 +1,6 @@
+// XFAIL: xcselect
cachemeifyoucan wrote:
I don't feel XFAIL is correct to use here in general. It is possible to have a
different host SDK and the test will actually pass, right?
https://github.com/llvm/llvm-project/pull/119670
___
@@ -2257,17 +2261,26 @@ void Darwin::AddDeploymentTarget(DerivedArgList &Args)
const {
// Warn if the path does not exist.
if (!getVFS().exists(A->getValue()))
getDriver().Diag(clang::diag::warn_missing_sysroot) << A->getValue();
- } else {
-if (char *env =
https://github.com/cachemeifyoucan commented:
The idea looks good.
Need to add test. You should add `CLANG_USE_XCSELECT` as a requirement and
label all the tests properly (including those will break). Maybe you can also
remove the hack for `CLANG_NO_XCSELECT` but I am neutral on that.
https:
@@ -214,6 +214,39 @@ if(GCC_INSTALL_PREFIX AND NOT
USE_DEPRECATED_GCC_INSTALL_PREFIX)
"See https://github.com/llvm/llvm-project/pull/77537 for detail.")
endif()
+if(APPLE)
+ check_include_file(xcselect.h CLANG_HAVE_XCSELECT_H)
cachemeifyoucan wrote:
All
https://github.com/cachemeifyoucan edited
https://github.com/llvm/llvm-project/pull/119670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cachemeifyoucan approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/115993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -226,3 +226,26 @@
//
// RUN: HOME=%S/Inputs/config %clang -### --config-user-dir=~ -v 2>&1 |
FileCheck %s --check-prefix=CHECK-TILDE
// CHECK-TILDE: User configuration file directory: {{.*}}/Inputs/config
+
+//--- Fallback to stripping OS versions
+//
+// RUN: touch %t/test
https://github.com/cachemeifyoucan approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/111387
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cachemeifyoucan wrote:
Current patch breaks test:
```
// We pass --sysroot="" to defeat any -DDEFAULT_SYSROOT parameter.
```
I think that just a pure hack in the test case, we can just update the test.
@cyndyishida what do you think about the current approach?
https://github.com/llvm/llvm-proje
cachemeifyoucan wrote:
Ah, I see. I think `--sysroot` is not even involved when you use
`DEFAULT_SYSROOT`, it is injected here:
https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/Driver.cpp#L205
Maybe instead of, the logic in the patch should be setting `-syslibroot` for
linker in
cachemeifyoucan wrote:
> DEFAULT_SYSROOT was expected by some users to support setting a default SDK.
> Maybe this wasn't actually intended, but it came common enough knowledge to
> eventually be explicitly recommended in parts of LLVM documentation:
That is flang document, which is not endors
@@ -192,6 +192,17 @@ class DarwinSDKInfo {
Expected>
parseDarwinSDKInfo(llvm::vfs::FileSystem &VFS, StringRef SDKRootPath);
+/// Get the system platform prefix for the active target triple.
cachemeifyoucan wrote:
I feel this header is used for parsing `SDKSet
@@ -339,13 +340,11 @@ void InitHeaderSearch::AddDefaultIncludePaths(
if (triple.isOSDarwin()) {
cachemeifyoucan wrote:
Do you think we can just clean up this code block by moving all logics to
driver?
https://github.com/llvm/llvm-project/pull/118543
https://github.com/cachemeifyoucan edited
https://github.com/llvm/llvm-project/pull/118543
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cachemeifyoucan commented:
Some comments in line.
https://github.com/llvm/llvm-project/pull/118543
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cachemeifyoucan wrote:
I think the correct solution for Homebrew is to never use `--sysroot` and
switch to `-isysroot` since the former is almost never used on Darwin platforms.
https://github.com/llvm/llvm-project/pull/115993
___
cfe-commits mailing
cachemeifyoucan wrote:
Close as moving to new stacked PR for easy review.
https://github.com/llvm/llvm-project/pull/68447
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cachemeifyoucan closed
https://github.com/llvm/llvm-project/pull/68447
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cachemeifyoucan wrote:
@zmodem Sorry I totally missed you comments. I thought no one was reviewing so
I kind of abandoned the process.
Recreate the PR in a stack for new reviews. All of your comments should be
addressed:
```
3713985 Support: Add proxies for raw_ostream and raw_pwrite_stream
@@ -1024,6 +1042,16 @@ int clang_scan_deps_main(int argc, char **argv, const
llvm::ToolContext &) {
Pool.wait();
}
+ if (Verbose) {
+llvm::errs() << "\n*** Virtual File System Stats:\n"
+ << NumStatusCalls << " status() calls\n"
+ <<
https://github.com/cachemeifyoucan approved this pull request.
LGTM with a comment.
https://github.com/llvm/llvm-project/pull/108056
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cachemeifyoucan edited
https://github.com/llvm/llvm-project/pull/108056
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cachemeifyoucan edited
https://github.com/llvm/llvm-project/pull/105855
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1073,6 +1073,36 @@ static llvm::StringRef
canonicalizePlatformName(llvm::StringRef Platform) {
.Case("ShaderModel", "shadermodel")
.Default(Platform);
}
+static std::vector equivalentPlatformNames(llvm::StringRef
Platform) {
cach
https://github.com/cachemeifyoucan approved this pull request.
LGTM in general.
https://github.com/llvm/llvm-project/pull/105855
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1073,6 +1073,36 @@ static llvm::StringRef
canonicalizePlatformName(llvm::StringRef Platform) {
.Case("ShaderModel", "shadermodel")
.Default(Platform);
}
+static std::vector equivalentPlatformNames(llvm::StringRef
Platform) {
cach
https://github.com/cachemeifyoucan edited
https://github.com/llvm/llvm-project/pull/105855
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cachemeifyoucan wrote:
@jakeegan I will create a PR to restore this target to the previous
configuration but it would be good to figure out what flags/setting were
different that caused that failure for you.
https://github.com/llvm/llvm-project/pull/102396
_
cachemeifyoucan wrote:
That looks an unstable test the has been failed before.
https://github.com/llvm/llvm-project/pull/102396
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cachemeifyoucan closed
https://github.com/llvm/llvm-project/pull/102396
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cachemeifyoucan closed
https://github.com/llvm/llvm-project/pull/102348
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cachemeifyoucan wrote:
Try to fix https://github.com/llvm/llvm-project/pull/102138 after failing on
`clang-ppc64-aix` bot:
[https://lab.llvm.org/buildbot/#/builders/64/builds/62](https://lab.llvm.org/buildbot/#/builders/64/builds/620)
https://github.com/llvm/llvm-project/pull/102396
__
https://github.com/cachemeifyoucan created
https://github.com/llvm/llvm-project/pull/102396
Partially remove some of the changes from #102138 as
EXPORT_SYMBOLS_FOR_PLUGINS doesn't work on all the configurations.
>From 6eae32d099a2ae90428831dcf1fae8efa7a8070c Mon Sep 17 00:00:00 2001
From: Stev
https://github.com/cachemeifyoucan edited
https://github.com/llvm/llvm-project/pull/102348
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cachemeifyoucan wrote:
Maybe the next step is to get rid of
`"clang/Frontend/PCHContainerOperations.h"` but I don't know why it was there
in the first place.
https://github.com/llvm/llvm-project/pull/102348
___
cfe-commits mailing list
cfe-commits@l
https://github.com/cachemeifyoucan unassigned
https://github.com/llvm/llvm-project/pull/102348
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cachemeifyoucan created
https://github.com/llvm/llvm-project/pull/102348
Breakup the cyclic dependency in module 'Clang_Frontend':
Clang_Frontend -> Clang_Serialization -> Clang_Frontend
>From dcfd3b1cc4ba4ec71f3f89c28429e6f0dac3a400 Mon Sep 17 00:00:00 2001
From: Steven Wu
https://github.com/cachemeifyoucan closed
https://github.com/llvm/llvm-project/pull/102138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cachemeifyoucan wrote:
I will merge and watch Fuchsia bot to make sure it doesn't break.
https://github.com/llvm/llvm-project/pull/102138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
cachemeifyoucan wrote:
Thanks! Can this be fixed on `release/19.x` too?
https://github.com/llvm/llvm-project/pull/102226
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cachemeifyoucan closed
https://github.com/llvm/llvm-project/pull/102080
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cachemeifyoucan wrote:
@petrhosek Let me know if you want to check this offline before I merge or you
want me to merge and see if it breaks again.
https://github.com/llvm/llvm-project/pull/102138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/cachemeifyoucan edited
https://github.com/llvm/llvm-project/pull/102138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cachemeifyoucan created
https://github.com/llvm/llvm-project/pull/102138
Fix the builds with LLVM_TOOL_LLVM_DRIVER_BUILD enabled.
>From ea208594eca2af600cd38f618bada04d4b6b9a10 Mon Sep 17 00:00:00 2001
From: Steven Wu
Date: Tue, 6 Aug 2024 06:21:47 -0700
Subject: [PATCH] =?
cachemeifyoucan wrote:
Reverted. I suspect it is a LLVM_DRIVER build that is not covered by PR testing
and I missed some code path there. Let me improve later.
https://github.com/llvm/llvm-project/pull/101741
___
cfe-commits mailing list
cfe-commits@l
Author: Steven Wu
Date: 2024-08-06T06:08:16-07:00
New Revision: f9b69a378cb1acfedab7252b4d4dc3d0af282d0b
URL:
https://github.com/llvm/llvm-project/commit/f9b69a378cb1acfedab7252b4d4dc3d0af282d0b
DIFF:
https://github.com/llvm/llvm-project/commit/f9b69a378cb1acfedab7252b4d4dc3d0af282d0b.diff
LOG
Author: Steven Wu
Date: 2024-08-06T06:08:16-07:00
New Revision: f9b69a378cb1acfedab7252b4d4dc3d0af282d0b
URL:
https://github.com/llvm/llvm-project/commit/f9b69a378cb1acfedab7252b4d4dc3d0af282d0b
DIFF:
https://github.com/llvm/llvm-project/commit/f9b69a378cb1acfedab7252b4d4dc3d0af282d0b.diff
LOG
cachemeifyoucan wrote:
Yes, please revert. Do you have link to the build failure?
https://github.com/llvm/llvm-project/pull/101741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cachemeifyoucan closed
https://github.com/llvm/llvm-project/pull/101741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 237 matches
Mail list logo
