sdowney added a comment.
At least in my codebase, skipping templates is too strong. I run across ones
where the const& parameter is not one controlled by a template. It's often a
size_t.
I could easily see not fixing the typedef'd refs, also, although I think
warning on them is still useful. P
sdowney updated this revision to Diff 50986.
sdowney added a comment.
Add tests with functions generated with MACROS
http://reviews.llvm.org/D18191
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/ConstRefBuiltinCheck.cpp
clang-tidy/misc/ConstRefBuiltinCheck.h
clang-tidy/misc/MiscT
sdowney updated this revision to Diff 51000.
sdowney added a comment.
Add tests for FixIts
http://reviews.llvm.org/D18191
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/ConstRefBuiltinCheck.cpp
clang-tidy/misc/ConstRefBuiltinCheck.h
clang-tidy/misc/MiscTidyModule.cpp
docs/clang
sdowney updated this revision to Diff 50982.
sdowney added a comment.
Add more test cases, covering templates, template specializations, function
definitions, member function templates.
Check if parent function of the argument is a nullptr.
Fix spelling mistake.
http://reviews.llvm.org/D18191
sdowney added a comment.
In http://reviews.llvm.org/D18191#376471, @LegalizeAdulthood wrote:
> There is utility in the definition of a function in saying that an argument
> is `const int i` instead of `int i`. The const-ness declares the intent that
> this local variable is not going to be mod
sdowney created this revision.
sdowney added a reviewer: alexfh.
sdowney added a subscriber: cfe-commits.
Add a check for const& to builtin types. Add FixIt replacing, for example,
'const& int i' with 'int i'.
http://reviews.llvm.org/D18191
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/m
sdowney added a subscriber: sdowney.
sdowney added a comment.
I'll push up a review with the one line link addition later. Thanks!
The html copy should also get applied to the release_38 branch too, if
there's going to be another RC.
http://reviews.llvm.org/D16963
___
I'll push up a review with the one line link addition later. Thanks!
The html copy should also get applied to the release_38 branch too, if
there's going to be another RC.
On Tue, Feb 9, 2016 at 11:52 AM Manuel Klimek wrote:
> klimek added a subscriber: klimek.
> klimek added a comment.
>
> I h
sdowney created this revision.
sdowney added a reviewer: reames.
sdowney added a subscriber: cfe-commits.
The LibASTMatchersReference documentation is an html file, not an rst
document, so is not produced by sphinx. Copy the html into the proper
location as part of the sphinx html doc generation.
