That's not a great long-term solution for obvious reasons, but I think it's a
great quick fix.
Sent from my iPhone
> On Sep 23, 2016, at 5:53 PM, Hal Finkel wrote:
>
> We currently have logic in the test suite that sets -ffp-contract=off on
> PowerPC (because the default for GCC and other com
Without digging into them yet, these are almost caused by overly-sensitive
tests that are erroneously expecting bit-exact results.
- Steve
Sent from my iPhone
> On Sep 23, 2016, at 4:42 PM, Renato Golin wrote:
>
> rengolin added a subscriber: rengolin.
> rengolin added a comment.
>
> Folks,
scanon accepted this revision.
scanon added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D24481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
scanon added a comment.
I am not the right person to review the C++ template details, but everything
else seems OK to me.
https://reviews.llvm.org/D18639
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
scanon added a comment.
I agree with Marshall. Aside from the points he raises, this approach looks
fine.
http://reviews.llvm.org/D18639
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
scanon added a comment.
`-ffp-contract=on` obeys the semantics of C's FP_CONTRACT pragma. In
particular, it will not fuse:
float m = x*y;
float a = m + z;
Whereas you probably want that to fuse for your purposes. `-ffp-contract=fast`
seems more in line with your needs.
http://reviews.l
scanon added a comment.
LGTM.
http://reviews.llvm.org/D15165
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
scanon abandoned this revision.
scanon added a comment.
Abandoned for http://reviews.llvm.org/D15165.
http://reviews.llvm.org/D14891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
scanon added a comment.
This is mostly http://reviews.llvm.org/D14891 with a test case added, but
http://reviews.llvm.org/D14891 also fixed a second very minor issue: that the
"else if" should just be "if". Also, majnemer made a few style suggestions
there that it would be nice to adopt. Eith
scanon added a comment.
Friendly ping.
http://reviews.llvm.org/D14891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
scanon created this revision.
scanon added reviewers: hfinkel, resistor, lhames.
scanon added a subscriber: cfe-commits.
r253269 exposed a pre-existing issue in tryEmitFMulAdd, where we would assert
if a fusable operation had operands with multiple uses (we didn't see it
previously because FP_CO
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253269: Make FP_CONTRACT ON the default. (authored by
scanon).
Changed prior to commit:
http://reviews.llvm.org/D14200?vs=39205&id=40351#toc
Repository:
rL LLVM
http://reviews.llvm.org/D14200
Files
scanon updated this revision to Diff 39205.
scanon added a comment.
Additionally test contraction of compound assignment expressions.
http://reviews.llvm.org/D14200
Files:
include/clang/Basic/LangOptions.def
lib/Frontend/CompilerInvocation.cpp
test/CodeGen/aarch64-neon-fma.c
test/CodeGe
13 matches
Mail list logo
