[PATCH] D157613: [Clang][ExtendLifetimes][3/4] Add -fextend-lifetimes flag to Clang to extend the lifetime of local variables

StephenTozer added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:3492-3499 +// Ignore fake uses and the instructions that load their +// operands. +if (Intrinsic->getIntrinsicID() == llvm::Intrinsic::fake_use) { + const llvm::Value *Fa

[PATCH] D157615: [ExtendLifetimes][1/4] Add "disable-post-ra" function attribute to disable the post-regalloc scheduler

StephenTozer added a comment. In D157615#4646848 , @dblaikie wrote: > Might be worth rewording the commit, or splitting it - I'd say the > introduction of `optdebug` should be the noteworthier part of this patch (or > whichever patch introduces it) - s

[PATCH] D157615: [ExtendLifetimes][1/4] Add "disable-post-ra" function attribute to disable the post-regalloc scheduler

StephenTozer updated this revision to Diff 556011. StephenTozer added a comment. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. Significant patch updates: Changed attribute from "disable-post-ra" to `optdebug`, following the direction that the discussion on the O

[PATCH] D157618: [Clang][ExtendLifetimes][4/4] Add extend_lifetimes pragma to Clang to selectively disable -fextend-lifetimes for functions

StephenTozer created this revision. StephenTozer added reviewers: dblaikie, aprantl, echristo. StephenTozer added a project: debug-info. Herald added a reviewer: aaron.ballman. Herald added a project: All. StephenTozer requested review of this revision. Herald added subscribers: cfe-commits, wangpc

[PATCH] D157613: [Clang][ExtendLifetimes][3/4] Add -fextend-lifetimes flag to Clang to extend the lifetime of local variables

StephenTozer created this revision. StephenTozer added reviewers: dblaikie, aprantl, echristo. StephenTozer added a project: debug-info. Herald added a reviewer: aaron.ballman. Herald added a project: All. StephenTozer requested review of this revision. Herald added subscribers: cfe-commits, MaskRa

[PATCH] D152708: [RFC][Draft] Enable primitive support for Two-Level Line Tables in LLVM

StephenTozer added a comment. In D152708#4414402 , @dblaikie wrote: > It is unfortunate to hear that TLLT are a significant size increase, though > not entirely surprising - it's a bunch of extra info to encode. I'll be glad > to have this example to ex

[PATCH] D152708: [RFC][Draft] Enable primitive support for Two-Level Line Tables in LLVM

StephenTozer created this revision. StephenTozer added a project: debug-info. Herald added subscribers: ormris, hiraditya. Herald added a project: All. StephenTozer requested review of this revision. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, jplehr, sstefan1, MaskRay. Hera

[PATCH] D115622: [Debugify] Optimize debugify original mode

StephenTozer accepted this revision. StephenTozer added a comment. Latest change makes sense, LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115622/new/ https://reviews.llvm.org/D115622 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D115622: [Debugify] Optimize debugify original mode

StephenTozer accepted this revision. StephenTozer added a comment. This revision is now accepted and ready to land. Seems like a simple and sensible change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115622/new/ https://reviews.llvm.org/D115622

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

StephenTozer added a comment. Apart from the one comment, LGTM. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1644-1650 + Opts.EnableDIPreservationVerify = Args.hasArg(OPT_fverify_debuginfo_preserve); + // Ignore the option if the -fverify-debuginfo-preserve wasn't e