[PATCH] D138278: TableGen: honor LLVM_LINK_LLVM_DYLIB by default

stephenneuendorffer added a comment. I think the MLIR parts of this code were written before attempting to create libMLIR.so. Probably these tablegen binaries would have to also avoid linking against libMLIR.so and be statically linked to both llvmSupport and MLIRsupport to work properly.I

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

stephenneuendorffer added a comment. LGTM... Does LLVM_TOOLS_BINARY_DIR include CMAKE_CFG_INTDIR? Is this actually NFC? Comment at: clang/utils/hmaptool/CMakeLists.txt:1 -set(CLANG_HMAPTOOL hmaptool) Unused elsewhere, I assume? Repository: rG LLVM Githu

[PATCH] D113664: [cmake] use project relative paths when generating ASTNodeAPI.json

stephenneuendorffer accepted this revision. stephenneuendorffer added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113664/new/ https://reviews.llvm.org/D113664 _

[PATCH] D84691: [CMake] Move find_package(ZLIB) to LLVMConfig

stephenneuendorffer added a comment. Perfect! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84691/new/ https://reviews.llvm.org/D84691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

stephenneuendorffer added inline comments. Comment at: mlir/examples/standalone/CMakeLists.txt:35 +endif() + include(TableGen) mehdi_amini wrote: > mehdi_amini wrote: > > I am a bit unsure that it is desirable that it is desirable to need this > > change? > > T

[PATCH] D77156: [CMAKE] Plumb include_directories() into tablegen()

stephenneuendorffer edited the summary of this revision. stephenneuendorffer updated this revision to Diff 254867. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77156/new/ https://reviews.llvm.org/D77156 Files: clang/cmake/modules/AddClang.cmake

[PATCH] D77156: [CMAKE] Plumb include_directories() into tablegen()

This revision was automatically updated to reflect the committed changes. Closed by commit rGae044c5b0caa: [CMAKE] Plumb include_directories() into tablegen() (authored by stephenneuendorffer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77156/new/

[PATCH] D77156: [CMAKE] Plumb include_directories() into tablegen()

stephenneuendorffer created this revision. Herald added subscribers: cfe-commits, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, burmako, jpienaar, rriddle, mehdi_amini, mgorny. Herald added a project: clang. stephenneuendorffer add