Re: r286815 - Improve handling of floating point literals in OpenCL to only use double precision if the target supports fp64.

2016-11-15 Thread Stephen Canon via cfe-commits
The reason these commits bring it up is that I don’t see it clearly documented whether: float x = 340282356779733661637539395458142568447.0; is interpreted as float x = 340282356779733661637539395458142568447.0f; // x is FLT_MAX or as float x = (float)(3402823567797336

Re: r286815 - Improve handling of floating point literals in OpenCL to only use double precision if the target supports fp64.

2016-11-14 Thread Stephen Canon via cfe-commits
Can you add some non-trivial test cases that exercise double-rounding, especially near the overflow boundary? e.g. What is the expected value of x if the target does not support fp64?: float x = 340282356779733661637539395458142568447.0; – Steve > On Nov 14, 2016, at 6:15 AM, Neil Hick

Re: r253269 - Make FP_CONTRACT ON the default.

2016-09-06 Thread Stephen Canon via cfe-commits
Finkel via cfe-commits < >> cfe-commits@lists.llvm.org > wrote: >> >> >> - Original Message - >>> From: "Renato Golin via cfe-commits" < cfe-commits@lists.llvm.org > >>> To: "Stephen Canon" < sca...@apple.com > &

Re: r253269 - Make FP_CONTRACT ON the default.

2015-11-17 Thread Stephen Canon via cfe-commits
> On Nov 17, 2015, at 4:51 AM, Renato Golin wrote: > > On 16 November 2015 at 23:09, Stephen Canon via cfe-commits > wrote: >> Author: scanon >> Date: Mon Nov 16 17:09:11 2015 >> New Revision: 253269 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=2

r253269 - Make FP_CONTRACT ON the default.

2015-11-16 Thread Stephen Canon via cfe-commits
Author: scanon Date: Mon Nov 16 17:09:11 2015 New Revision: 253269 URL: http://llvm.org/viewvc/llvm-project?rev=253269&view=rev Log: Make FP_CONTRACT ON the default. Differential Revision: D14200 Added: cfe/trunk/test/CodeGen/aarch64-scalar-fma.c Modified: cfe/trunk/include/clang/Basic/L

r252050 - Allow compound assignment expressions to be contracted when licensed by the language or pragma.

2015-11-04 Thread Stephen Canon via cfe-commits
Author: scanon Date: Wed Nov 4 09:25:38 2015 New Revision: 252050 URL: http://llvm.org/viewvc/llvm-project?rev=252050&view=rev Log: Allow compound assignment expressions to be contracted when licensed by the language or pragma. Modified: cfe/trunk/lib/CodeGen/CGExprScalar.cpp Modified: cfe

r247643 - Prevent implicit re-interpret casts between ExtVector and Scalar types.

2015-09-14 Thread Stephen Canon via cfe-commits
Author: scanon Date: Mon Sep 14 19:21:56 2015 New Revision: 247643 URL: http://llvm.org/viewvc/llvm-project?rev=247643&view=rev Log: Prevent implicit re-interpret casts between ExtVector and Scalar types. Previously, in certain cases lax vector conversions could occur between scalar floating-poi