[PATCH] D138274: Add version to all LLVM cmake package

stellaraccident accepted this revision. stellaraccident added a comment. As mentioned, the duplication is annoying but I suspect is the least bad way to do it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138274/new/ https://reviews.llvm.org/D138

[PATCH] D137760: Add FP8 E4M3 support to APFloat.

stellaraccident accepted this revision. stellaraccident added a comment. Thanks for this. Patch lgtm. Has a couple of format issues but probably ok as-is (this file is very inconsistently formatted and it looks like you overrode clang-format a bit for consistency with adjacent code). Repositor

[PATCH] D133823: Add APFloat and MLIR type support for fp8 (e5m2).

stellaraccident added a comment. Ran the full clang/llvm/mlir test suite in debug mode just to be safe. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133823/new/ https://reviews.llvm.org/D133823 ___ cfe-

[PATCH] D133823: Add APFloat and MLIR type support for fp8 (e5m2).

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe28b15b572b5: Add APFloat and MLIR type support for fp8 (e5m2). (authored by stellaraccident). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D133823: Add APFloat and MLIR type support for fp8 (e5m2).

stellaraccident updated this revision to Diff 465233. stellaraccident marked an inline comment as done. stellaraccident added a comment. Remove break after llvm_unreachable for consistency with other switches in file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D133823: Add APFloat and MLIR type support for fp8 (e5m2).

stellaraccident updated this revision to Diff 465231. stellaraccident added a comment. Switch to explicit case per comment from ctopper. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133823/new/ https://reviews.llvm.org/D133823 Files: clang/lib/

[PATCH] D133823: Add APFloat and MLIR type support for fp8 (e5m2).

stellaraccident updated this revision to Diff 465230. stellaraccident added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add fix to MicrosoftMangle.cpp that caused buildbot failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D131919: Move googletest to the third-party directory

stellaraccident accepted this revision. stellaraccident added inline comments. Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:1257 + +set(LLVM_THIRD_PARTY_DIR ${CMAKE_CURRENT_SOURCE_DIR}/../third-party CACHE STRING +"Directory containing third party software used by

[PATCH] D131919: Move googletest to the third-party directory

stellaraccident added inline comments. Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:1257 + +set(LLVM_THIRD_PARTY_DIR ${CMAKE_CURRENT_SOURCE_DIR}/../third-party CACHE STRING +"Directory containing third party software used by LLVM (e.g. googletest)") --

[PATCH] D84058: Pass -rtlib=libgcc in tests conditioned on the default.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5d06e8b24f97: Pass -rtlib=libgcc in tests conditioned on the default. (authored by stellaraccident). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84058/new/

[PATCH] D84058: Pass -rtlib=libgcc in tests conditioned on the default.

stellaraccident updated this revision to Diff 278865. stellaraccident added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84058/new/ https://reviews.llvm.org/D84058 Files: clang/test/Driver/msp430-toolchain.c Index: clang/tes

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0

stellaraccident added a comment. The msp430-toolchain.c test was failing in our setup, and I've put together a fix in D84058 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81676/new/ https://reviews.llvm.org/D8167

[PATCH] D84058: Pass -rtlib=libgcc in tests conditioned on the default.

stellaraccident created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - This test was failing in our builds that configure compiler-rt as the configure-time rtlib. - Opted for this test fix instead of a rollback, and hopefully TI can fix forward if this we