https://github.com/weliveindetail closed
https://github.com/llvm/llvm-project/pull/97071
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
weliveindetail wrote:
Thanks for your feedback everyone!
https://github.com/llvm/llvm-project/pull/97071
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/97071
From ca2ab5f9e3470e87923c7b950b7b06e5ff21119e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Fri, 28 Jun 2024 16:43:42 +0200
Subject: [PATCH 1/3] [clang-repl] Fix RuntimeInterfaceBu
weliveindetail wrote:
> Any chance of adding a test case?
We could add a lot more tests in general, but I don't think this specific
detail requires a dedicated one. It's a fix for an existing bug, so we have
coverage already.
https://github.com/llvm/llvm-project/pull/97071
___
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/97071
From ca2ab5f9e3470e87923c7b950b7b06e5ff21119e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Fri, 28 Jun 2024 16:43:42 +0200
Subject: [PATCH 1/2] [clang-repl] Fix RuntimeInterfaceBu
weliveindetail wrote:
Superseded by https://github.com/llvm/llvm-project/pull/97071
https://github.com/llvm/llvm-project/pull/96900
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/weliveindetail closed
https://github.com/llvm/llvm-project/pull/96900
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/weliveindetail created
https://github.com/llvm/llvm-project/pull/97071
When generating runtime interface bindings, extend integral types to the native
register size rather than 64-bit per se
From ca2ab5f9e3470e87923c7b950b7b06e5ff21119e Mon Sep 17 00:00:00 2001
From: =?UTF-8
https://github.com/weliveindetail created
https://github.com/llvm/llvm-project/pull/96900
todo
From 2e1eac5919a56fd15a7c79281d6544c4958d6874 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Thu, 27 Jun 2024 14:28:03 +0200
Subject: [PATCH] [clang-repl] Fix unboxing of va_a
Author: Stefan Gränitz
Date: 2024-05-30T17:03:21+02:00
New Revision: 647d2728c4dbc387521ce3984ebfda78ff2b031f
URL:
https://github.com/llvm/llvm-project/commit/647d2728c4dbc387521ce3984ebfda78ff2b031f
DIFF:
https://github.com/llvm/llvm-project/commit/647d2728c4dbc387521ce3984ebfda78ff2b031f.diff
weliveindetail wrote:
Looking into https://lab.llvm.org/buildbot/#/builders/86/builds/81169 right
now. Pushing a fix soon.
https://github.com/llvm/llvm-project/pull/93816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/c
https://github.com/weliveindetail closed
https://github.com/llvm/llvm-project/pull/93816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/93816
From fd02a874601b8a72d05c3c1b219e28600851b56b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Thu, 30 May 2024 14:32:52 +0200
Subject: [PATCH 1/2] [clang-repl] Introduce common fixtu
weliveindetail wrote:
Oh interesting, the Windows test actually fails at this assertion:
```
DC->getLexicalParent() == CurContext && "The next DeclContext should be
lexically contained in the current one.", file
C:\ws\src\clang\lib\Sema\SemaDecl.cpp, line 1332
```
@vgvassilev Any ideas?
https
weliveindetail wrote:
Here we go: https://github.com/llvm/llvm-project/pull/93816
https://github.com/llvm/llvm-project/pull/84758
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/weliveindetail created
https://github.com/llvm/llvm-project/pull/93816
Reduce code bloat by checking test requirements in a common test fixture
From fd02a874601b8a72d05c3c1b219e28600851b56b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Thu, 30 May 20
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/89734
From 3aef8a0b009b54c4839a323b21cb5b09aa50d035 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Tue, 23 Apr 2024 12:23:11 +0200
Subject: [PATCH 1/3] [clang-repl] Add test for explicit
weliveindetail wrote:
@jakeegan Thanks for reporting! Should be fixed now. Hope we caught them all 🤞
https://github.com/llvm/llvm-project/pull/84758
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
Author: Stefan Gränitz
Date: 2024-05-30T11:52:15+02:00
New Revision: 4310988991b46c9a35f60abc27a08ee10309a50c
URL:
https://github.com/llvm/llvm-project/commit/4310988991b46c9a35f60abc27a08ee10309a50c
DIFF:
https://github.com/llvm/llvm-project/commit/4310988991b46c9a35f60abc27a08ee10309a50c.diff
weliveindetail wrote:
> Looks like you already implemented it. Nice.
Well, it's gonna be a bit more churn. Eventually, it will reduce coverage for
the incremental features in the frontend that are independent from the JIT. To
be honest, I don't mind because none of the targets seem relevant fo
weliveindetail wrote:
Oh indeed, it seems we can decide to skip tests in `SetUp()`
```
class FooTest : public ::testing:Test {
protected:
void SetUp()
{
GTEST_SKIP();
}
};
```
https://github.com/llvm/llvm-project/pull/84758
___
cfe
Author: Stefan Gränitz
Date: 2024-05-28T23:20:27+02:00
New Revision: df542e1ed82bd4e5a9e345d3a3ae63a76893a0cf
URL:
https://github.com/llvm/llvm-project/commit/df542e1ed82bd4e5a9e345d3a3ae63a76893a0cf
DIFF:
https://github.com/llvm/llvm-project/commit/df542e1ed82bd4e5a9e345d3a3ae63a76893a0cf.diff
weliveindetail wrote:
@vvereschaka Thanks for the note! should be fixed now.
> I am not sure how this patch changed these tests to start failing on Windows.
> Do you have any clue?
It's just cases I missed in the first quick-fix
> What do you mean?
This is adding a lot of boilerplate, becaus
Author: Stefan Gränitz
Date: 2024-05-28T22:48:55+02:00
New Revision: 6a47315a3cb2c6d381809f0ba5c89bd8dcdbcaa0
URL:
https://github.com/llvm/llvm-project/commit/6a47315a3cb2c6d381809f0ba5c89bd8dcdbcaa0
DIFF:
https://github.com/llvm/llvm-project/commit/6a47315a3cb2c6d381809f0ba5c89bd8dcdbcaa0.diff
weliveindetail wrote:
@vgvassilev I pushed a quick fix for the tests. I think we should
revisit/refactor the test story here though in the mid-term.
https://github.com/llvm/llvm-project/pull/84758
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
Author: Stefan Gränitz
Date: 2024-05-28T13:54:09+02:00
New Revision: 98f9bb384af1beb62eb62a353f0585281bee8c26
URL:
https://github.com/llvm/llvm-project/commit/98f9bb384af1beb62eb62a353f0585281bee8c26
DIFF:
https://github.com/llvm/llvm-project/commit/98f9bb384af1beb62eb62a353f0585281bee8c26.diff
weliveindetail wrote:
Some bots report failures after this patch landed. I will push a fix soon.
https://github.com/llvm/llvm-project/pull/84758
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
https://github.com/weliveindetail closed
https://github.com/llvm/llvm-project/pull/84758
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
weliveindetail wrote:
@vgvassilev Thanks for the ping. I got derailed and missed the fix for the
blocker!
https://github.com/llvm/llvm-project/pull/84758
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
@@ -407,6 +406,16 @@ void IncrementalParser::CleanUpPTU(PartialTranslationUnit
&PTU) {
}
}
}
+
+ // FIXME: We should de-allocate MostRecentTU
+ for (Decl *D : MostRecentTU->decls()) {
+if (!isa(D))
+ continue;
+// Check if we need to clean up the IdR
weliveindetail wrote:
> The Unix pre-merge seems okay, however the windows pre-merge check is doing
> nothing for more than 12h.
Yeah same here. I recognized that Windows PR checks are running Flang
regression tests now. I guess that adds a huge load on the builders and causes
the delays. Min
@@ -407,6 +406,16 @@ void IncrementalParser::CleanUpPTU(PartialTranslationUnit
&PTU) {
}
}
}
+
+ // FIXME: We should de-allocate MostRecentTU
+ for (Decl *D : MostRecentTU->decls()) {
+if (!isa(D))
+ continue;
+// Check if we need to clean up the IdR
https://github.com/weliveindetail edited
https://github.com/llvm/llvm-project/pull/89804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/weliveindetail commented:
I am not an expert on the behavior of IdResolver, but this patch works for me.
https://github.com/llvm/llvm-project/pull/89804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/c
@@ -0,0 +1,21 @@
+// REQUIRES: host-supports-jit
+// UNSUPPORTED: system-aix
+
+// RUN: cat %s | clang-repl -Xcc -xc -Xcc -Xclang -Xcc -verify | FileCheck %s
+// RUN: cat %s | clang-repl -Xcc -xc -Xcc -O2 -Xcc -Xclang -Xcc -verify|
FileCheck %s
+int printf(const char *, ...);
+in
https://github.com/weliveindetail edited
https://github.com/llvm/llvm-project/pull/89879
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/weliveindetail approved this pull request.
I assume the return code is supposed to reflect only frontend errors? (See my
note inline.) From reading the test it's not obvious what is interactive mode
and what is non-interactive/batch mode. Might be worth a note. Otherwise, thi
@@ -241,18 +243,13 @@ int main(int argc, const char **argv) {
break;
}
if (Input == R"(%undo)") {
-if (auto Err = Interp->Undo()) {
+if (auto Err = Interp->Undo())
llvm::logAllUnhandledErrors(std::move(Err), llvm::errs(), "error: "
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/89734
From 085a93919d8f65419cc856fe5584c83d3eceb142 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Tue, 23 Apr 2024 12:23:11 +0200
Subject: [PATCH 1/3] [clang-repl] Add test for explicit
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/89734
From 085a93919d8f65419cc856fe5584c83d3eceb142 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Tue, 23 Apr 2024 12:23:11 +0200
Subject: [PATCH 1/2] [clang-repl] Add test for explicit
weliveindetail wrote:
FYI: The run on the Windows bot failed even though tests worked as expected. In
particular, all `ClangReplInterpreterTests` unittests passed as well as all
`Interpreter` LIT tests. I could land this towards the end of the week.
https://github.com/llvm/llvm-project/pull/84
@@ -0,0 +1,13 @@
+// UNSUPPORTED: system-aix
+
+// RUN: cat %s | clang-repl | FileCheck %s
+int *x = new int();
+template struct GuardX { T *&x; GuardX(T *&x) : x(x) {}; ~GuardX();
};
+template GuardX::~GuardX() { delete x; x = nullptr; }
+
+// clang would normally defer codege
https://github.com/weliveindetail created
https://github.com/llvm/llvm-project/pull/89734
This patch adds test coverage for an edge case that is supported already.
From 085a93919d8f65419cc856fe5584c83d3eceb142 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Tue, 23 Apr 2
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/84758
From 7ee5d29f69daf626a4fdc2fced802fe7e881f31e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Sun, 10 Mar 2024 18:17:48 +0100
Subject: [PATCH 1/4] [clang-repl] Set up executor implic
weliveindetail wrote:
Taking this patch would mean that deriving from Interpreter won't hold as the
mechanism for extensions! At least for customizing the JITBuilder. I propose to
pass the `LLJITBuilder` to the constructor then and to store it as a member for
later `Create/ResetExecutor()` cal
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/84758
From 7ee5d29f69daf626a4fdc2fced802fe7e881f31e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Sun, 10 Mar 2024 18:17:48 +0100
Subject: [PATCH 1/3] [clang-repl] Set up executor implic
weliveindetail wrote:
> https://github.com/llvm/llvm-project/pull/89031 should unblock this PR.
@vgvassilev It did. And it uncovered an issue that I didn't think about before:
If we set up the executor in the constructor, then the interpreter instance
isn't fully initialized yet when we create
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/84758
From 7ee5d29f69daf626a4fdc2fced802fe7e881f31e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Sun, 10 Mar 2024 18:17:48 +0100
Subject: [PATCH 1/2] [clang-repl] Set up executor implic
https://github.com/weliveindetail closed
https://github.com/llvm/llvm-project/pull/87066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
weliveindetail wrote:
Possible, but might add limitations. The init process can be complex. I could
imagine a runtime to require actual execution of code (and not only parsing as
we'd implement it right now I guess) or load a dynamic library. The patch here
allows that, the constructor approac
https://github.com/weliveindetail created
https://github.com/llvm/llvm-project/pull/87066
None
From 1835e627203ece2e81787d6167ccc15b62c31f36 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Fri, 29 Mar 2024 13:37:36 +0100
Subject: [PATCH] [clang-repl] Minor cleanups in Va
https://github.com/weliveindetail created
https://github.com/llvm/llvm-project/pull/87064
Adding code for built-in functionality during initialization is very common.
Call this function afterwards to hide it from Undo. Any serious interpreter
needs it.
From e924da63f1e926f7a7008f661730b1fd478
https://github.com/weliveindetail closed
https://github.com/llvm/llvm-project/pull/85378
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
weliveindetail wrote:
@amy-kwan Thanks for your note and sorry for the long delay. There were so many
unrelated buildbot failures today, that I didn't catch this one. I think it was
fixed meanwhile with
https://github.com/llvm/llvm-project/commit/cb994d41c3afb2bd0b25a4c5b2ac48978bf1b23d
thank
weliveindetail wrote:
We do need the target and not just the symbols. It could be any non-native
target, but implementing a selection mechanism isn't worth the effort. We just
try ARM and (with my above patch) otherwise skip the test.
https://github.com/llvm/llvm-project/pull/84461
___
Author: Stefan Gränitz
Date: 2024-03-25T11:50:21+01:00
New Revision: 13078cbc3eeb0ae91c370ce0f604f7165b26e0c8
URL:
https://github.com/llvm/llvm-project/commit/13078cbc3eeb0ae91c370ce0f604f7165b26e0c8
DIFF:
https://github.com/llvm/llvm-project/commit/13078cbc3eeb0ae91c370ce0f604f7165b26e0c8.diff
weliveindetail wrote:
I will try this
https://github.com/llvm/llvm-project/blob/release/18.x/llvm/unittests/DebugInfo/LogicalView/CodeViewReaderTest.cpp#L482
and push a quick-fix.
https://github.com/llvm/llvm-project/pull/84461
___
cfe-commits mailin
weliveindetail wrote:
Thanks for your note. Looks like the problem is that the ARM target is not
registered. It's an uncommon requirement for a unitttest.. Will see how to
check that at runtime. If you have an idea, let me know. Thanks
https://github.com/llvm/llvm-project/pull/84461
__
https://github.com/weliveindetail closed
https://github.com/llvm/llvm-project/pull/84461
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/weliveindetail closed
https://github.com/llvm/llvm-project/pull/86118
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
weliveindetail wrote:
Windows buildbot failure is unrelated. This code is covered in unittest
ClangReplInterpreterTests and it passed.
https://github.com/llvm/llvm-project/pull/86118
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://list
weliveindetail wrote:
Let's give the pre-merge checks a 2nd chance..
https://github.com/llvm/llvm-project/pull/86118
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/86118
From 0b7f4bc8bf57219f5f1e5ffa06c986beb16b9546 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Thu, 21 Mar 2024 14:04:10 +0100
Subject: [PATCH 1/3] Add reproducer
---
clang/unittest
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/84461
From fae2f46d25650b8480f9d3135f33a0d6532f43ca Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Thu, 7 Mar 2024 23:04:22 +0100
Subject: [PATCH 1/2] [clang-repl] Add CreateJITBuilder()
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/84461
From fae2f46d25650b8480f9d3135f33a0d6532f43ca Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Thu, 7 Mar 2024 23:04:22 +0100
Subject: [PATCH] [clang-repl] Add CreateJITBuilder() for
https://github.com/weliveindetail created
https://github.com/llvm/llvm-project/pull/86118
Signedness of unqualified `char` is unspecified and varies between platforms.
This patch adds `Char_U` in `REPL_BUILTIN_TYPES` to account for platforms that
default to `unsigned char`.
From e0cdd176e35d0
@@ -375,16 +375,22 @@ void IncrementalParser::CleanUpPTU(PartialTranslationUnit
&PTU) {
TranslationUnitDecl *MostRecentTU = PTU.TUPart;
TranslationUnitDecl *FirstTU = MostRecentTU->getFirstDecl();
if (StoredDeclsMap *Map = FirstTU->getPrimaryContext()->getLookupPtr()) {
@@ -375,16 +375,22 @@ void IncrementalParser::CleanUpPTU(PartialTranslationUnit
&PTU) {
TranslationUnitDecl *MostRecentTU = PTU.TUPart;
TranslationUnitDecl *FirstTU = MostRecentTU->getFirstDecl();
if (StoredDeclsMap *Map = FirstTU->getPrimaryContext()->getLookupPtr()) {
@@ -205,7 +205,7 @@ class StoredDeclsList {
Data.setPointer(Head);
}
- /// Return an array of all the decls that this list represents.
+ /// Return the list of all the decls.
weliveindetail wrote:
This is not an array (otherwise we could have done era
@@ -375,16 +375,22 @@ void IncrementalParser::CleanUpPTU(PartialTranslationUnit
&PTU) {
TranslationUnitDecl *MostRecentTU = PTU.TUPart;
TranslationUnitDecl *FirstTU = MostRecentTU->getFirstDecl();
if (StoredDeclsMap *Map = FirstTU->getPrimaryContext()->getLookupPtr()) {
https://github.com/weliveindetail commented:
Two minor remarks
https://github.com/llvm/llvm-project/pull/85378
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/weliveindetail edited
https://github.com/llvm/llvm-project/pull/85378
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/85378
From 6fbd6e36133af7af008c84a1a2e44c243aed26be Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Fri, 15 Mar 2024 11:01:09 +0100
Subject: [PATCH 1/2] [clang-repl] Fix assertion failure
weliveindetail wrote:
I can reproduce it downstream in the implicit Undo after including a header
that causes a lot of parse errors in nested headers. I am afraid it's
unpractical to emulate in the test suite upstream.
The code is exercised in all Undo tests. They don't reproduce the issue rig
https://github.com/weliveindetail created
https://github.com/llvm/llvm-project/pull/85378
This assertion failure is one (fortunate) symptom:
```
clang/include/clang/AST/DeclBase.h:1337: reference
clang::DeclListNode::iterator::operator*() const: Assertion `Ptr &&
"dereferencing end() iterator"
weliveindetail wrote:
This should fix both: initializing the native target (your reported case) AND
skipping the test on platforms that don't support JIT (other build bots
complained).
https://github.com/llvm/llvm-project/pull/84460
___
cfe-commits m
Author: Stefan Gränitz
Date: 2024-03-12T23:14:23+01:00
New Revision: d73c2d5df21735805a1f46a85790db64c0615e1c
URL:
https://github.com/llvm/llvm-project/commit/d73c2d5df21735805a1f46a85790db64c0615e1c
DIFF:
https://github.com/llvm/llvm-project/commit/d73c2d5df21735805a1f46a85790db64c0615e1c.diff
weliveindetail wrote:
Yes, I think I can fix it quickly
https://github.com/llvm/llvm-project/pull/84460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Stefan Gränitz
Date: 2024-03-12T14:47:23+01:00
New Revision: ffd31c5e92da9da37cf57ca653e22db38b5af9a3
URL:
https://github.com/llvm/llvm-project/commit/ffd31c5e92da9da37cf57ca653e22db38b5af9a3
DIFF:
https://github.com/llvm/llvm-project/commit/ffd31c5e92da9da37cf57ca653e22db38b5af9a3.diff
weliveindetail wrote:
Build bot https://lab.llvm.org/buildbot/#/builders/196/builds/46799 detected an
issue with the test -- I will try and push a fix quickly:
```
tools/clang/unittests/Interpreter/CMakeFiles/ClangReplInterpreterTests.dir/InterpreterExtensionsTest.cpp.o:InterpreterExtensionsTest
https://github.com/weliveindetail edited
https://github.com/llvm/llvm-project/pull/84461
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/84461
From 88271c39b30b84041b4b7fb8b8f34c211d8190d5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Thu, 7 Mar 2024 23:04:22 +0100
Subject: [PATCH] [clang-repl] Add CreateJITBuilder() for
https://github.com/weliveindetail closed
https://github.com/llvm/llvm-project/pull/84460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/84460
From a8c9cf8901d3fc24f3a2c2161b4a8796a7b28989 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Thu, 7 Mar 2024 23:04:22 +0100
Subject: [PATCH] [clang-repl] Expose CreateExecutor() and
@@ -14,7 +14,7 @@ struct A { int a; A(int a) : a(a) {} virtual ~A(); };
// PartialTranslationUnit.
inline A::~A() { printf("~A(%d)\n", a); }
-// Create one instance with new and delete it.
+// Create one instance with new and delete it. We crash here now:
A *a1 = new A(1);
--
@@ -14,7 +14,7 @@ struct A { int a; A(int a) : a(a) {} virtual ~A(); };
// PartialTranslationUnit.
inline A::~A() { printf("~A(%d)\n", a); }
-// Create one instance with new and delete it.
+// Create one instance with new and delete it. We crash here now:
A *a1 = new A(1);
--
@@ -14,7 +14,7 @@ struct A { int a; A(int a) : a(a) {} virtual ~A(); };
// PartialTranslationUnit.
inline A::~A() { printf("~A(%d)\n", a); }
-// Create one instance with new and delete it.
+// Create one instance with new and delete it. We crash here now:
A *a1 = new A(1);
--
weliveindetail wrote:
> > Do you mind incorporating this patch so that we avoid churn?
>
> Sure. Essentially, this drops lazy creation of the executor and makes it
> dependent on the frontend action explicitly. Fine for me. We can still expose
> explicit setup/tear-down.
@vgvassilev I moved i
https://github.com/weliveindetail edited
https://github.com/llvm/llvm-project/pull/84758
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/weliveindetail created
https://github.com/llvm/llvm-project/pull/84758
Until now the IncrExecutor is created lazily on the first execution request. In
order to process the PTUs that come from initialization, we have to do it
upfront implicitly.
From 2f7b523472543a92a9770188
https://github.com/weliveindetail closed
https://github.com/llvm/llvm-project/pull/84176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/weliveindetail closed
https://github.com/llvm/llvm-project/pull/83126
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/84460
From 10f8d3eb040a5838d84d8a84fe636c7c2a7d196b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Fri, 8 Mar 2024 00:08:56 +0100
Subject: [PATCH 1/3] [clang-repl] Expose RuntimeInterface
weliveindetail wrote:
> Do you mind incorporating this patch so that we avoid churn?
Sure. Essentially, this drops lazy creation of the executor and makes it
dependent on the frontend action explicitly. Fine for me. We can still expose
explicit setup/tear-down.
https://github.com/llvm/llvm-pr
@@ -102,4 +124,97 @@ TEST(InterpreterExtensionsTest, FindRuntimeInterface) {
EXPECT_EQ(1U, Interp.RuntimeIBPtr->TransformerQueries);
}
+class CustomJBInterpreter : public Interpreter {
+ using CustomJITBuilderCreatorFunction =
+
std::function>()>;
+ CustomJITBuilderC
@@ -102,4 +124,97 @@ TEST(InterpreterExtensionsTest, FindRuntimeInterface) {
EXPECT_EQ(1U, Interp.RuntimeIBPtr->TransformerQueries);
}
+class CustomJBInterpreter : public Interpreter {
+ using CustomJITBuilderCreatorFunction =
+
std::function>()>;
+ CustomJITBuilderC
https://github.com/weliveindetail edited
https://github.com/llvm/llvm-project/pull/84461
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/weliveindetail commented:
This PR depends on two predecessor patches, but I wanted to share it for review
already. For the moment please refer to the single commit in
https://github.com/llvm/llvm-project/pull/84461/commits/cc46034e5288ba54dfc8a0ea7d54792cbb99227d
for review.
@@ -373,21 +373,32 @@ Interpreter::Parse(llvm::StringRef Code) {
static llvm::Expected
createJITTargetMachineBuilder(const std::string &TT) {
if (TT == llvm::sys::getProcessTriple())
+// This fails immediately if the target backend is not registered
return llvm::orc:
weliveindetail wrote:
This PR was factored out for isolated review and to reduce the size of the
follow-up patch in https://github.com/llvm/llvm-project/pull/84461. It depends
on the previous change in https://github.com/llvm/llvm-project/pull/83126.
Combined patch size will shrink significant
1 - 100 of 179 matches
Mail list logo
