stbuehler updated this revision to Diff 44973.
stbuehler added a comment.
integrate patch by Stephan Bergmann :
- Fix handling of abi_tag attribute on namespaces to match GCC behavior:
- Forbid the attribute on unnamed namespaces. (GCC merely produces a warning
instead of an error for unnamed
stbuehler updated this revision to Diff 44972.
stbuehler marked an inline comment as done.
stbuehler added a comment.
- disable dervied abi tags in some recursions to fix infinite recursions
- don't emit abi tags for NestedNameSpecifier::Identifier
Repository:
rL LLVM
http://reviews.llvm.org/
stbuehler added a comment.
Just for the record: substitution doesn't work yet (it should add available
tags from the substitution, but doesn't).
This example shows the difference: my patch mangles `T::F()` as
`N::Name(N::__test::Result)::T::F[abi:test](N::__test::Result)`, but actually
shouldn
5 12:36:19 -0700
David Majnemer wrote:
> Would you mind sticking abi-tag.patch in phabricator:
> http://llvm.org/docs/Phabricator.html ?
> Your patch is big enough that it would make it a little easier for me
> to review.
>
> On Sat, Sep 12, 2015 at 7:12 AM, Stefan Bühler via
Hi all,
I've been working on #23529.
The abi tag mangling implemented by gcc is horrible, but I think my
patch covers most of the incompatibilities with gcc5.
There might be some bugs with substitutions, although I have to come up
with a test case for that to see what gcc does...
Test cases com
