[PATCH] D20428: Tracking exception specification source locations

2016-10-07 Thread Stanisław Barzowski via cfe-commits
sbarzowski added a comment. What's happening here? It's accepted, but not merged and the last activity is 3 months old while my change is waiting for it. Can I help somehow? https://reviews.llvm.org/D20428 ___ cfe-commits mailing list cfe-commits@l

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

2016-06-10 Thread Stanisław Barzowski via cfe-commits
sbarzowski added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:41 @@ +40,3 @@ + // (and destructed) as in push_back case. + auto isCtorOfSmartPtr = hasDeclaration(cxxConstructorDecl( + ofClass(hasAnyName("std::shared_ptr", "std::unique_ptr", "std::au

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

2016-06-03 Thread Stanisław Barzowski via cfe-commits
sbarzowski added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:40 @@ +39,3 @@ + // passed pointer because smart pointer won't be constructed + // (and destructed) as in push_back case. + auto isCtorOfSmartPtr = hasDeclaration(cxxConstructorDecl(

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

2016-06-03 Thread Stanisław Barzowski via cfe-commits
sbarzowski added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:40 @@ +39,3 @@ + // passed pointer because smart pointer won't be constructed + // (and destructed) as in push_back case. + auto isCtorOfSmartPtr = hasDeclaration(cxxConstructorDecl(

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

2016-06-03 Thread Stanisław Barzowski via cfe-commits
sbarzowski added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:30 @@ +29,3 @@ + cxxMemberCallExpr(hasDeclaration(functionDecl(hasName(PushBackName))), +on(hasType(cxxRecordDecl(hasName(VectorName) + .bind("call"); -

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

2016-06-03 Thread Stanisław Barzowski via cfe-commits
sbarzowski added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:28 @@ +27,3 @@ + + auto callPushBack = + cxxMemberCallExpr(hasDeclaration(functionDecl(hasName(PushBackName))), Shouldn't it start with an uppercase letter? =

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

2016-06-03 Thread Stanisław Barzowski via cfe-commits
sbarzowski added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:57 @@ +56,3 @@ + + auto functionNameSourceRange = CharSourceRange::getCharRange( + PushBackExpr->getExprLoc(), Call->getArg(0)->getExprLoc()); capital letter? ===

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2016-06-01 Thread Stanisław Barzowski via cfe-commits
sbarzowski marked 11 inline comments as done. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:33 @@ +32,3 @@ +// token including trailing whitespace. +static SourceRange findToken(const SourceManager &Sources, LangOptions LangOpts, + SourceLocat

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2016-06-01 Thread Stanisław Barzowski via cfe-commits
sbarzowski updated this revision to Diff 59277. sbarzowski added a comment. Thanks for review, guys. I fixed as many easy problems as I had time for today, will continue later. Repository: rL LLVM http://reviews.llvm.org/D19201 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscT

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2016-06-01 Thread Stanisław Barzowski via cfe-commits
sbarzowski added a comment. Note ``FunctionProtoType::getNoExceptExpr`` is weird. If you have the same expr in multiple noexcepts, then it returns the same object for all of them, so it is useless for determining the location in code. I ended up finding it all "by hand" with lexer (looking for

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2016-06-01 Thread Stanisław Barzowski via cfe-commits
sbarzowski updated the summary for this revision. sbarzowski removed rL LLVM as the repository for this revision. sbarzowski updated this revision to Diff 59179. http://reviews.llvm.org/D19201 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/ThrowWith