slavapestov updated this revision to Diff 202084.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59628/new/
https://reviews.llvm.org/D59628
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/AttrDocs.td
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/include
slavapestov marked 2 inline comments as done.
slavapestov added inline comments.
Comment at: clang/include/clang/Basic/Attr.td:297
def CUDA : LangOpt<"CUDA">;
-def COnly : LangOpt<"CPlusPlus", 1>;
+def COnly : LangOpt<"COnly", "!LangOpts.CPlusPlus">;
def CPlusPlus : LangOpt<"CP
slavapestov updated this revision to Diff 200808.
slavapestov marked 6 inline comments as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59628/new/
https://reviews.llvm.org/D59628
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/AttrDocs.td
clang/include/clan
slavapestov updated this revision to Diff 199905.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59628/new/
https://reviews.llvm.org/D59628
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/AttrDocs.td
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/include
slavapestov updated this revision to Diff 199885.
slavapestov added a comment.
Updated patch to address review feedback.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59628/new/
https://reviews.llvm.org/D59628
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/AttrD
slavapestov updated this revision to Diff 193407.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59628/new/
https://reviews.llvm.org/D59628
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Basic/ObjCRuntime
slavapestov added a comment.
I don't know what the etiquette is around here about pinging reviewers for a
re-review, but this CL is ready for another look. Your feedback is much
appreciated!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59628/new/
https://reviews.llvm.org/D59628
__
slavapestov updated this revision to Diff 192378.
slavapestov marked 2 inline comments as done.
slavapestov added a comment.
Second revision adds the following:
- Validation of the attribute in Sema
- Sema tests for the above
- Correct behavior of super method calls of a class with the attribute
slavapestov marked 11 inline comments as done.
slavapestov added a comment.
Thanks for the comments everyone. In the next version of the patch, I fixed
most of the review feedback and also addressed an issue where super message
sends were not calling `objc_loadClassRef()`.
Co
slavapestov created this revision.
slavapestov added reviewers: rjmccall, dexonsmith, aaron.ballman.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
dexonsmith edited reviewers, added: erik.pilkington, arphaman; removed:
dexonsmith.
dexonsmith added a comment.
+Erik and Ale
10 matches
Mail list logo